From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Shahaf Shuler <shahafs@mellanox.com>,
Thomas Monjalon <thomas@monjalon.net>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>
Cc: Ophir Munk <ophirmu@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
Olga Shern <olgas@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v3] net/mlx4: support CRC strip toggling
Date: Wed, 28 Mar 2018 15:19:18 +0100 [thread overview]
Message-ID: <a6e38ef8-827b-97ac-1216-f59592ed8414@intel.com> (raw)
In-Reply-To: <DB7PR05MB44261E788F7F43C286F8B83FC3A30@DB7PR05MB4426.eurprd05.prod.outlook.com>
On 3/28/2018 7:03 AM, Shahaf Shuler wrote:
> Monday, March 26, 2018 3:31 PM, Thomas Monjalon:
>> 26/03/2018 13:54, Adrien Mazarguil:
>>> On Mon, Mar 26, 2018 at 12:38:22PM +0100, Ferruh Yigit wrote:
>>>> On 3/25/2018 9:19 PM, Ophir Munk wrote:
>>>>> Previous to this commit mlx4 CRC stripping was executed by default
>>>>> and there was no verbs API to disable it.
>>>>
>>>> Are you aware of the discussion about CRC [1]? Is this patch compatible
>> with plans?
>>>>
>>>> [1]
>>>>
>> https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fd
>>>>
>> pdk.org%2Fdev%2Fpatchwork%2Fpatch%2F36415%2F&data=02%7C01%7Csh
>> ahafs%
>>>>
>> 40mellanox.com%7C90c78c02ec954cc1dfda08d59315619f%7Ca652971c7d2e4
>> d9b
>>>>
>> a6a4d149256f461b%7C0%7C0%7C636576642435977344&sdata=broGz4U2Kw1
>> u9xJk
>>>> t%2FryP7j2CU9XN0GnM5jsUxHwiNg%3D&reserved=0
>>>
>>> I wasn't aware of this notice. Looks like it makes this patch
>>> unnecessary since mlx4 always strip by default; this patch makes it
>>> configurable at will and only exposes the capability when HW supports
>>> its configuration (i.e. the ability to leave CRC inside mbuf).
>>>
>>> We'd just need mlx4 to not expose DEV_RX_OFFLOAD_CRC_STRIP at all in
>>> mlx5_get_rx_queue_offloads() in order to fully comply.
>>>
>>> I leave it up to you, I don't mind if we include this patch only to
>>> revert it later when we finally get rid of DEV_RX_OFFLOAD_CRC_STRIP.
>>
>> A new flag to keep CRC will be introduced.
>> We will need toggling anyway.
>
> Do we have such CRC flag already? If not I will include this patch and we revert/adjust it when the new flag will be introduced.
Patch sent recently [1] but not merged yet, your review may help there :)
[1]
https://dpdk.org/dev/patchwork/patch/36416/
>
>>
>>
>
prev parent reply other threads:[~2018-03-28 14:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 9:00 [dpdk-dev] [PATCH v1] net/mlx4: disable CRC stripping Ophir Munk
2018-03-19 16:36 ` [dpdk-dev] [PATCH v2] net/mlx4: support CRC strip toggling Ophir Munk
2018-03-23 14:53 ` Adrien Mazarguil
2018-03-25 16:17 ` Ophir Munk
2018-03-25 20:19 ` [dpdk-dev] [PATCH v3] " Ophir Munk
2018-03-26 9:34 ` Adrien Mazarguil
2018-04-10 6:26 ` Shahaf Shuler
2018-03-26 11:38 ` Ferruh Yigit
2018-03-26 11:54 ` Adrien Mazarguil
2018-03-26 12:30 ` Thomas Monjalon
2018-03-28 6:03 ` Shahaf Shuler
2018-03-28 14:19 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6e38ef8-827b-97ac-1216-f59592ed8414@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).