From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>,
dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: rename folder to library name
Date: Tue, 3 Apr 2018 11:57:55 +0100 [thread overview]
Message-ID: <20180403105755.GB3544@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <8464158.iTavIsMWKz@xps>
On Tue, Apr 03, 2018 at 12:24:15PM +0200, Thomas Monjalon wrote:
> 03/04/2018 11:28, Ferruh Yigit:
> > Library folder name and output library name are same except a few flaws
> > including librte_ether.
> >
> > This library is network device abstraction layer, the name "ethdev" fits
> > better than "ether", and library & header files already named as ethdev.
> >
> > Also there is a rte_ether.h in the net library which can cause confusion.
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > ---
> > Not sure if the we are ready for this change J
> >
> > This is one the issues that the hassle of the change doesn't worth the
> > benefit and you may prefer to live with the flaw.
> >
> > Also a concern is this breaks the git history.
>
> Yes it breaks the git history.
> I am a big user of gitk. Do you know how to follow the history after rename
> with gitk?
>
> I think it is a good change but I would like to be sure it will not
> bother us every day.
>
For those of use with even slight OCD, having it the way it is bothers us
every day! :-)
I view this as something that we really should do some day - it's just
broken the way the way it is right now - and so the sooner we take the hit
and fix it, the better.
If you do need to find the history of the file, would git blame work well
enough for you?
/Bruce
next prev parent reply other threads:[~2018-04-03 10:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 9:28 Ferruh Yigit
2018-04-03 9:58 ` Bruce Richardson
2018-04-03 10:24 ` Thomas Monjalon
2018-04-03 10:57 ` Bruce Richardson [this message]
2018-04-03 12:20 ` Thomas Monjalon
2018-04-03 12:33 ` Bruce Richardson
2018-04-03 13:23 ` Wiles, Keith
2018-04-03 13:17 ` Wiles, Keith
2018-04-03 13:29 ` Ferruh Yigit
2018-04-03 16:43 ` Thomas Monjalon
2018-04-04 0:50 ` Jerin Jacob
2018-04-26 21:25 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-04-27 0:08 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403105755.GB3544@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).