From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/5] net/virtio: prevent simple Tx path selection by default
Date: Thu, 7 Jun 2018 15:53:53 +0800 [thread overview]
Message-ID: <20180607075353.GA15456@debian> (raw)
In-Reply-To: <d3327c7c-33b0-fdf6-9223-96bc926bb07c@redhat.com>
On Thu, Jun 07, 2018 at 09:40:35AM +0200, Maxime Coquelin wrote:
> On 06/07/2018 07:43 AM, Tiwei Bie wrote:
> > On Wed, Jun 06, 2018 at 02:31:24PM +0200, Maxime Coquelin wrote:
> > [...]
> > > +
> > > +static int
> > > +virtio_dev_args(struct rte_eth_dev *dev)
> > > +{
> > > + struct rte_kvargs *kvlist;
> > > + struct rte_devargs *devargs;
> > > + const char *valid_args[] = {
> > > + VIRTIO_SIMPLE_TX_SUPPORT,
> > > + NULL,
> > > + };
> > > + int ret;
> > > + int i;
> > > +
> > > + devargs = dev->device->devargs;
> > > + if (!devargs)
> > > + return 0; /* return success */
> > > +
> > > + kvlist = rte_kvargs_parse(devargs->args, valid_args);
> > > + if (kvlist == NULL)
> > > + return -EINVAL;
> >
> > Virtio-user has defined some other mandatory devargs.
> > The parse will fail when other devargs have been
> > specified.
>
> Ok, so IIUC, just returning 0 here should do the trick, right?
I think you can't just return 0 in this case,
because you still need to find and parse the
VIRTIO_SIMPLE_TX_SUPPORT devarg.
I didn't look into the kvargs code. It seems
that you can pass NULL as the second param
when calling rte_kvargs_parse(), i.e. just
get the KV list without valid keys check.
Best regards,
Tiwei Bie
>
> > > +
> > > + /* Process parameters. */
> > > + for (i = 0; (valid_args[i] != NULL); ++i) {
> >
> > There is an extra space before the comment.
> > The () around `valid_args[i] != NULL` isn't necessary.
>
> Fixed.
>
> > > + if (rte_kvargs_count(kvlist, valid_args[i])) {
> > > + ret = rte_kvargs_process(kvlist, valid_args[i],
> > > + virtio_dev_args_check, dev);
> > > + if (ret) {
> > > + rte_kvargs_free(kvlist);
> > > + return ret;
> > > + }
> > > + }
> > > + }
> > > + rte_kvargs_free(kvlist);
> > > +
> > > + return 0;
> > > +}
> > > +
> > [...]
> >
>
> Thanks!
> Maxime
next prev parent reply other threads:[~2018-06-07 7:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 12:31 [dpdk-dev] [PATCH v2 0/5] net/virtio: Tx path selection and offload improvements Maxime Coquelin
2018-06-06 12:31 ` [dpdk-dev] [PATCH v2 1/5] net/virtio: prevent simple Tx path selection by default Maxime Coquelin
2018-06-07 5:43 ` Tiwei Bie
2018-06-07 7:40 ` Maxime Coquelin
2018-06-07 7:53 ` Tiwei Bie [this message]
2018-06-06 12:31 ` [dpdk-dev] [PATCH v2 2/5] net/virtio: use simple path for Tx even if Rx mergeable Maxime Coquelin
2018-06-07 5:18 ` Tiwei Bie
2018-06-06 12:31 ` [dpdk-dev] [PATCH v2 3/5] net/vhost: improve Tx path selection Maxime Coquelin
2018-06-07 5:13 ` Tiwei Bie
2018-06-07 7:34 ` Maxime Coquelin
2018-06-06 12:31 ` [dpdk-dev] [PATCH v2 4/5] net/virtio: don't use simple Rx if TCP LRO or VLAN strip requested Maxime Coquelin
2018-06-07 4:58 ` Tiwei Bie
2018-06-06 12:31 ` [dpdk-dev] [PATCH v2 5/5] net/virtio: improve offload check performance Maxime Coquelin
2018-06-07 4:51 ` Tiwei Bie
2018-06-07 7:22 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607075353.GA15456@debian \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).