From: Bruce Richardson <bruce.richardson@intel.com>
To: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
Cc: dev@dpdk.org, alejandro.lucero@netronome.com,
allain.legacy@windriver.com, jasvinder.singh@intel.com,
keith.wiles@intel.com, matan@mellanox.com,
reshma.pattan@intel.com
Subject: Re: [dpdk-dev] [PATCH 1/6] build: fix for FREEBSD build via meson
Date: Thu, 27 Sep 2018 15:49:04 +0100 [thread overview]
Message-ID: <20180927144903.GB2380@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <1538054652-20820-2-git-send-email-agalyax.babu.radhakrishnan@intel.com>
On Thu, Sep 27, 2018 at 02:24:07PM +0100, Agalya Babu RadhaKrishnan wrote:
> FreeBSD compilation was failing through meson build.
> RTE_EAL_VFIO is not supported in FreeBSD.
> But RTE_EAL_VFIO was enabled for both linux and freebsd.
> So RTE_EAL_VFIO is removed from config/rte_config.h and
> based on the platform RTE_EAL_VFIO flag is enabled/disabled appropriately.
>
> Fixes: 6e8a721044 ("vfio: export functions even when disabled")
>
> Signed-off-by: Agalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>
> ---
> config/rte_config.h | 1 -
> lib/meson.build | 6 ++++++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/config/rte_config.h b/config/rte_config.h
> index 567051b9c..53c568929 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -34,7 +34,6 @@
> #define RTE_MAX_TAILQ 32
> #define RTE_LOG_DP_LEVEL RTE_LOG_INFO
> #define RTE_BACKTRACE 1
> -#define RTE_EAL_VFIO 1
> #define RTE_MAX_VFIO_CONTAINERS 64
>
> /* bsd module defines */
> diff --git a/lib/meson.build b/lib/meson.build
> index 3acc67e6e..1b20027a5 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -31,6 +31,12 @@ if cc.has_argument('-Wno-format-truncation')
> default_cflags += '-Wno-format-truncation'
> endif
>
> +if host_machine.system() == 'linux'
> + dpdk_conf.set('RTE_EAL_VFIO', true)
> +else
> + dpdk_conf.set('RTE_EAL_VFIO', false)
> +endif
> +
I think this can be shortened in a number of ways. If we don't have vfio, I
don't think you need to set it to false, so the else leg can be removed.
Even shorter again could be:
dpdk_conf.set('RTE_EAL_VFIO', host_machine.system() == 'linux')
/Bruce
next prev parent reply other threads:[~2018-09-27 14:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 13:24 [dpdk-dev] [PATCH 0/6] fix for meson builds in freebsd Agalya Babu RadhaKrishnan
2018-09-27 13:24 ` [dpdk-dev] [PATCH 1/6] build: fix for FREEBSD build via meson Agalya Babu RadhaKrishnan
2018-09-27 14:49 ` Bruce Richardson [this message]
2018-09-27 14:49 ` Bruce Richardson
2018-09-27 13:24 ` [dpdk-dev] [PATCH 2/6] net/nfp: disable nfp build in FREEBSD Agalya Babu RadhaKrishnan
2018-09-27 13:24 ` [dpdk-dev] [PATCH 3/6] net/avp: disable avp " Agalya Babu RadhaKrishnan
2018-09-27 13:24 ` [dpdk-dev] [PATCH 4/6] net/softnic: disable softnic " Agalya Babu RadhaKrishnan
2018-09-27 13:49 ` Singh, Jasvinder
2018-09-27 13:24 ` [dpdk-dev] [PATCH 5/6] net/tap: disable tap " Agalya Babu RadhaKrishnan
2018-09-27 13:45 ` Wiles, Keith
2018-09-27 13:24 ` [dpdk-dev] [PATCH 6/6] net/vdev_netvsc: disable vdev netvsc " Agalya Babu RadhaKrishnan
2018-09-27 13:42 ` Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180927144903.GB2380@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=agalyax.babu.radhakrishnan@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=allain.legacy@windriver.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=keith.wiles@intel.com \
--cc=matan@mellanox.com \
--cc=reshma.pattan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).