From: "John Daley (johndale)" <johndale@cisco.com>
To: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
"Hyong Youb Kim (hyonkim)" <hyonkim@cisco.com>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
Qi Zhang <qi.z.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
"David Marchand" <david.marchand@6wind.com>,
Maxime Coquelin <maxime.coquelin@redhat.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/enic: add private API to set ingress VLAN rewrite mode
Date: Wed, 13 Mar 2019 21:11:23 +0000 [thread overview]
Message-ID: <CY4PR1101MB221537E6A8EF8295F4BDBCDACF4A0@CY4PR1101MB2215.namprd11.prod.outlook.com> (raw)
Message-ID: <20190313211123.OFNK_09YjNjYwBduJlwTlG9ia_N_6zkO7FDiNTe54jw@z> (raw)
In-Reply-To: <155267265.tCld3OmuaL@xps>
Due to time zone differences, I'll answer for Hyong (below).
-john
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, March 13, 2019 1:36 PM
> To: Ferruh Yigit <ferruh.yigit@intel.com>; Hyong Youb Kim (hyonkim)
> <hyonkim@cisco.com>
> Cc: Andrew Rybchenko <arybchenko@solarflare.com>; Qi Zhang
> <qi.z.zhang@intel.com>; dev@dpdk.org; John Daley (johndale)
> <johndale@cisco.com>; Shahaf Shuler <shahafs@mellanox.com>; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>; David Marchand
> <david.marchand@6wind.com>; Maxime Coquelin
> <maxime.coquelin@redhat.com>; Konstantin Ananyev
> <konstantin.ananyev@intel.com>; Hemant Agrawal
> <hemant.agrawal@nxp.com>; Stephen Hemminger
> <stephen@networkplumber.org>
> Subject: Re: [PATCH v2] net/enic: add private API to set ingress VLAN rewrite
> mode
>
> 13/03/2019 19:32, Ferruh Yigit:
> > On 3/5/2019 7:11 AM, Hyong Youb Kim wrote:
> > > The driver currently has a devarg to set the rewrite mode during
> > > init. Some apps want to programatically set it after running
> > > rte_eal_init() and finding that ports are VIC. Add a private
> > > function to support such applications.
> >
> > It is not good idea to have PMD specific APIs (although we already have
> some).
> >
> > Specific to this case, as far as I can see it is to pass a config
> > value and do the action related to it, what would you think having a
> > generic key/value set/get API in ethdev for this? Similar to rawdev
> get_attr/set_attr [1]?
> >
> > My concern is it may turn into something like ioctl with many things
> > pushed to it, and cause possible duplication ...
>
> Yes, it is clearly ioctl style.
>
> Please could you explain more what is the rewrite mode?
> Does it apply to the port or the queue?
>
It applies to a port. By default the Cisco VIC VLAN tags every packet on ingress even if they were untagged coming in on the wire. They are tagged with VLAN 0 or a VLAN id programmed into the NIC depending on the configuration. Its part of the original design, to maintain priority bits, ancient history.
Some apps don't like this (VPP) or take a slower path (OVS). Hyong added a ig-vlan-rewrite=untag devarg to disable this (leave untagged/default vlan packets untagged) during rte_eal_init and this is helpful for OVS, but VPP likes to set the rewrite mode after rte_eal_init() and finding the ports are VIC ports. So that is the reasoning behind the private API call.
next prev parent reply other threads:[~2019-03-13 21:11 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 5:56 [dpdk-dev] [PATCH] " Hyong Youb Kim
2019-03-05 7:11 ` [dpdk-dev] [PATCH v2] " Hyong Youb Kim
2019-03-13 18:32 ` Ferruh Yigit
2019-03-13 20:36 ` Thomas Monjalon
2019-03-13 20:36 ` Thomas Monjalon
2019-03-13 21:11 ` John Daley (johndale) [this message]
2019-03-13 21:11 ` John Daley (johndale)
2019-03-13 21:29 ` Thomas Monjalon
2019-03-13 21:29 ` Thomas Monjalon
2019-03-14 2:58 ` Hyong Youb Kim
2019-03-14 2:58 ` Hyong Youb Kim
2019-03-14 22:04 ` Thomas Monjalon
2019-03-14 22:04 ` Thomas Monjalon
2019-03-19 17:29 ` Ferruh Yigit
2019-03-19 17:29 ` Ferruh Yigit
2019-03-19 17:36 ` Thomas Monjalon
2019-03-19 17:36 ` Thomas Monjalon
2019-03-19 18:00 ` Ferruh Yigit
2019-03-19 18:00 ` Ferruh Yigit
2019-03-19 20:30 ` Thomas Monjalon
2019-03-19 20:30 ` Thomas Monjalon
2019-03-20 10:45 ` Ferruh Yigit
2019-03-20 10:45 ` Ferruh Yigit
2019-03-20 11:46 ` Thomas Monjalon
2019-03-20 11:46 ` Thomas Monjalon
2019-03-25 11:49 ` Ferruh Yigit
2019-03-25 11:49 ` Ferruh Yigit
2019-03-25 13:26 ` Gaëtan Rivet
2019-03-25 13:26 ` Gaëtan Rivet
2019-03-25 13:33 ` Gaëtan Rivet
2019-03-25 13:33 ` Gaëtan Rivet
2019-03-26 6:39 ` Hyong Youb Kim
2019-03-26 6:39 ` Hyong Youb Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CY4PR1101MB221537E6A8EF8295F4BDBCDACF4A0@CY4PR1101MB2215.namprd11.prod.outlook.com \
--to=johndale@cisco.com \
--cc=arybchenko@solarflare.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=hyonkim@cisco.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=konstantin.ananyev@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=qi.z.zhang@intel.com \
--cc=shahafs@mellanox.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).