From: Bruce Richardson <bruce.richardson@intel.com>
To: Luca Boccassi <bluca@debian.org>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
Thomas Monjalon <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] meson: remove build warnings
Date: Tue, 19 Mar 2019 09:50:29 +0000 [thread overview]
Message-ID: <20190319095029.GB318652@bricha3-MOBL.ger.corp.intel.com> (raw)
Message-ID: <20190319095029.FR_KvLluZ-DTKNNPApZ2A3VJR7EwNYBng6FN7uiLfXI@z> (raw)
In-Reply-To: <f9211941b408b96779905fdaf7d0c0a0128d00f4.camel@debian.org>
On Mon, Mar 18, 2019 at 05:15:25PM +0000, Luca Boccassi wrote:
> On Mon, 2019-03-18 at 16:28 +0000, Jerin Jacob Kollanukkaran wrote:
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > Remove the following meson build warnings
> >
> > 1) WARNING: Project specifies a minimum meson_version '>= 0.47.1'
> > but uses features which were added in newer versions:
> > * 0.48.0: {'console arg in custom_target'}
> >
> > 2) config/arm/meson.build:153: WARNING: Trying to compare values of
> > different types (list, str) using ==.
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > ---
> > config/arm/meson.build | 4 ++--
> > meson.build | 2 +-
> > 2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/config/arm/meson.build b/config/arm/meson.build
> > index 8e892fa77..170a4981a 100644
> > --- a/config/arm/meson.build
> > +++ b/config/arm/meson.build
> > @@ -116,8 +116,8 @@ else
> > cmd_output =
> > cmd.stdout().to_lower().strip().split(' ')
> > endif
> > # Set to generic if variable is not found
> > - machine = get_variable('impl_' + cmd_output[0],
> > 'generic')
> > - if machine == 'generic'
> > + machine = get_variable('impl_' + cmd_output[0],
> > ['generic'])
> > + if machine[0] == 'generic'
> > machine = impl_generic
> > cmd_output = cmd_generic
> > endif
> > diff --git a/meson.build b/meson.build
> > index 69833de82..f1abf1e59 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -5,7 +5,7 @@ project('DPDK', 'C',
> > version: '19.05.0-rc0',
> > license: 'BSD',
> > default_options: ['buildtype=release',
> > 'default_library=static'],
> > - meson_version: '>= 0.47.1'
> > + meson_version: '>= 0.48.0'
> > )
> >
> > # set up some global vars for compiler, platform, configuration,
> > etc.
>
> Bumping minimum dependency requirements needs an approval from the tech
> board. Incidentally we just got it, and the bump to 0.47.1 just
> happened.
>
> You can remove this and ignore the warning about the console arg - it's
> harmless if ran on a previous version which does not support it.
>
+1 to this. The first fix is good though - perhaps do a V2 with just that.
Sadly meson warnings for versions have too many false positives right now -
the devs are aware of it, but don't have any good fixes for it yet, as far
as I know. For our case, we will continue to have meson warnings, most of
which are false positives like this one.
Regards,
/Bruce
next prev parent reply other threads:[~2019-03-19 9:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 16:28 Jerin Jacob Kollanukkaran
2019-03-18 16:28 ` Jerin Jacob Kollanukkaran
2019-03-18 17:15 ` Luca Boccassi
2019-03-18 17:15 ` Luca Boccassi
2019-03-19 9:50 ` Bruce Richardson [this message]
2019-03-19 9:50 ` Bruce Richardson
2019-03-27 15:28 ` Aaron Conole
2019-03-27 15:28 ` Aaron Conole
2019-03-27 15:44 ` Luca Boccassi
2019-03-27 15:44 ` Luca Boccassi
2019-03-19 17:22 ` [dpdk-dev] [PATCH v2] " Jerin Jacob Kollanukkaran
2019-03-19 17:22 ` Jerin Jacob Kollanukkaran
2019-03-19 17:36 ` Luca Boccassi
2019-03-19 17:36 ` Luca Boccassi
2019-03-26 22:32 ` Thomas Monjalon
2019-03-26 22:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190319095029.GB318652@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).