From: Jens Freimann <jfreimann@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: maxime.coquelin@redhat.com, zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/virtio: define avail and used flags as constants
Date: Mon, 25 Mar 2019 08:47:35 +0100 [thread overview]
Message-ID: <20190325074735.t5mziidmukza5lpg@jenstp.localdomain> (raw)
Message-ID: <20190325074735.Vu0poa1e1OA8VGfAyPI6F9ePNKBt1rs88Ex05QS4HC8@z> (raw)
In-Reply-To: <20190325052716.7730-1-tiwei.bie@intel.com>
On Mon, Mar 25, 2019 at 01:27:16PM +0800, Tiwei Bie wrote:
>We are consistently passing 1 as the argument in the data path,
>so there is no need to define avail/used flags as function-like
>macros anymore. This patch changes the avail and used flags to
>constants. And a frequently used combination is also introduced.
>
>Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
>---
> drivers/net/virtio/virtio_ethdev.c | 10 ++++------
> drivers/net/virtio/virtio_ring.h | 9 +++++++--
> drivers/net/virtio/virtio_rxtx.c | 9 ++++-----
> .../net/virtio/virtio_user/virtio_user_dev.c | 17 ++++++++++-------
> drivers/net/virtio/virtqueue.h | 4 ++--
> 5 files changed, 27 insertions(+), 22 deletions(-)
>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
next prev parent reply other threads:[~2019-03-25 7:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 5:27 Tiwei Bie
2019-03-25 5:27 ` Tiwei Bie
2019-03-25 7:47 ` Jens Freimann [this message]
2019-03-25 7:47 ` Jens Freimann
2019-03-27 10:30 ` Maxime Coquelin
2019-03-27 10:30 ` Maxime Coquelin
2019-03-27 11:14 ` Maxime Coquelin
2019-03-27 11:14 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325074735.t5mziidmukza5lpg@jenstp.localdomain \
--to=jfreimann@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).