From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
tiwei.bie@intel.com, zhihong.wang@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] net/virtio: fix lgtm static checker complaint
Date: Thu, 28 Mar 2019 12:04:37 +0100 [thread overview]
Message-ID: <24a20bda-5c84-21df-53b5-7c1a811a9eb0@redhat.com> (raw)
Message-ID: <20190328110437.phe1C-4n2s-Y5lu60vRpra0J2vZMsFcI_6Vz2eT6VZY@z> (raw)
In-Reply-To: <20190327210843.13813-3-stephen@networkplumber.org>
On 3/27/19 10:08 PM, Stephen Hemminger wrote:
> Since previous test is for mtu < 1519 the next else if
> is always true. This causes the lgtm static tool to complain.
> Not a real issue, just cosmetic.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/virtio/virtio_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio/virtio_rxtx.c b/drivers/net/virtio/virtio_rxtx.c
> index 5f6796bdba37..268fe3b8f156 100644
> --- a/drivers/net/virtio/virtio_rxtx.c
> +++ b/drivers/net/virtio/virtio_rxtx.c
> @@ -1110,7 +1110,7 @@ virtio_update_packet_stats(struct virtnet_stats *stats, struct rte_mbuf *mbuf)
> stats->size_bins[0]++;
> else if (s < 1519)
> stats->size_bins[6]++;
> - else if (s >= 1519)
> + else
> stats->size_bins[7]++;
> }
>
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
next prev parent reply other threads:[~2019-03-28 11:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 21:08 [dpdk-dev] [PATCH 0/2] minor lgtm warning fixes Stephen Hemminger
2019-03-27 21:08 ` Stephen Hemminger
2019-03-27 21:08 ` [dpdk-dev] [PATCH 1/2] net/netvsc: fix lgtm static checker complaint Stephen Hemminger
2019-03-27 21:08 ` Stephen Hemminger
2019-03-28 0:25 ` Rami Rosen
2019-03-28 0:25 ` Rami Rosen
2019-03-27 21:08 ` [dpdk-dev] [PATCH 2/2] net/virtio: " Stephen Hemminger
2019-03-27 21:08 ` Stephen Hemminger
2019-03-28 0:28 ` Rami Rosen
2019-03-28 0:28 ` Rami Rosen
2019-03-28 11:04 ` Maxime Coquelin [this message]
2019-03-28 11:04 ` Maxime Coquelin
2019-03-28 17:11 ` [dpdk-dev] [PATCH 0/2] minor lgtm warning fixes Ferruh Yigit
2019-03-28 17:11 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24a20bda-5c84-21df-53b5-7c1a811a9eb0@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).