From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>, dev@dpdk.org
Cc: james.r.harris@intel.com, changpeng.liu@intel.com,
gavin.hu@arm.com, thomas@monjalon.net
Subject: Re: [dpdk-dev] [PATCH v2] fbarray: fix attach deadlock
Date: Fri, 29 Mar 2019 10:42:55 +0000 [thread overview]
Message-ID: <ca3531a9-7f3a-fd59-88fc-7efb2a718518@intel.com> (raw)
Message-ID: <20190329104255.RmQzee_yTq_WsxvWT1J1oslno2uv2Ry-Qp4_rf1uBHY@z> (raw)
In-Reply-To: <20190329095239.9646-1-dariusz.stojaczyk@intel.com>
On 29-Mar-19 9:52 AM, Darek Stojaczyk wrote:
> rte_fbarray_attach() currently locks its internal
> spinlock, but never releases it. Secondary processes
> won't even start if there is more than one fbarray
> to be attached to - the second rte_fbarray_attach()
> would be just stuck.
>
> Fix it by releasing the lock at the end of
> rte_fbarray_attach(). I believe this was the original
> intention.
>
> Fixes: 5b61c62cfd76 ("fbarray: add internal tailq for mapped areas")
> Cc: anatoly.burakov@intel.com
> Cc: thomas@monjalon.net
>
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
> v2:
> - fixed one more case where we could unlock the spinlock
> before locking it
Thanks for catching this!
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
There is one more case where we do unlock on init without locking, i'll
submit a patch separately (and will check other functions with a
microscope just in case).
--
Thanks,
Anatoly
next prev parent reply other threads:[~2019-03-29 10:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 5:09 [dpdk-dev] [PATCH] " Darek Stojaczyk
2019-03-29 5:09 ` Darek Stojaczyk
2019-03-29 8:53 ` Gavin Hu (Arm Technology China)
2019-03-29 8:53 ` Gavin Hu (Arm Technology China)
2019-03-29 9:52 ` [dpdk-dev] [PATCH v2] " Darek Stojaczyk
2019-03-29 9:52 ` Darek Stojaczyk
2019-03-29 10:42 ` Burakov, Anatoly [this message]
2019-03-29 10:42 ` Burakov, Anatoly
2019-03-29 11:15 ` Thomas Monjalon
2019-03-29 11:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca3531a9-7f3a-fd59-88fc-7efb2a718518@intel.com \
--to=anatoly.burakov@intel.com \
--cc=changpeng.liu@intel.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=james.r.harris@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).