DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Ilya Maximets <i.maximets@samsung.com>, dev@dpdk.org
Cc: Tiwei Bie <tiwei.bie@intel.com>,
	Jens Freimann <jfreimann@redhat.com>,
	David Marchand <david.marchand@redhat.com>,
	stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] vhost: fix silent queue enabling with legacy guests
Date: Wed, 17 Apr 2019 09:32:15 +0200	[thread overview]
Message-ID: <eb0c8109-f262-5563-c7ef-db733908f135@redhat.com> (raw)
Message-ID: <20190417073215.TBmXqe5UnLWt3nDuumSo5Ho9I93kC2C9xSynX8j9ZbU@z> (raw)
In-Reply-To: <20190412130949.14299-1-i.maximets@samsung.com>



On 4/12/19 3:09 PM, Ilya Maximets wrote:
> vhost should notify the application in case of all vring state changes.
> 
> In general, application should not care about negotiation of
> VHOST_USER_F_PROTOCOL_FEATURES. Protocol details like this should
> be hidden by the vhost library.
> 
> With this patch applications like OVS will be able to assume that
> all vrings disabled by default and only process 'vring_state_changed'
> events.
> 
> Fixes: 321203a54ba7 ("vhost: enable rings at the right time")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
> ---
>   lib/librte_vhost/vhost_user.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> index 23beed97d..c9e29ece8 100644
> --- a/lib/librte_vhost/vhost_user.c
> +++ b/lib/librte_vhost/vhost_user.c
> @@ -1231,8 +1231,12 @@ vhost_user_set_vring_kick(struct virtio_net **pdev, struct VhostUserMsg *msg,
>   	 * the ring starts already enabled. Otherwise, it is enabled via
>   	 * the SET_VRING_ENABLE message.
>   	 */
> -	if (!(dev->features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES)))
> +	if (!(dev->features & (1ULL << VHOST_USER_F_PROTOCOL_FEATURES))) {
>   		vq->enabled = 1;
> +		if (dev->notify_ops->vring_state_changed)
> +			dev->notify_ops->vring_state_changed(
> +				dev->vid, file.index, 1);
> +	}
>   
>   	if (vq->kickfd >= 0)
>   		close(vq->kickfd);
> 

Nice, this is indeed the right thing to do:

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

  parent reply	other threads:[~2019-04-17  7:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190412130955eucas1p114cc8050bf475c1df7b50572da718fb8@eucas1p1.samsung.com>
2019-04-12 13:09 ` Ilya Maximets
2019-04-12 13:09   ` Ilya Maximets
2019-04-17  7:32   ` Maxime Coquelin [this message]
2019-04-17  7:32     ` Maxime Coquelin
2019-04-17  7:53   ` Maxime Coquelin
2019-04-17  7:53     ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb0c8109-f262-5563-c7ef-db733908f135@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=i.maximets@samsung.com \
    --cc=jfreimann@redhat.com \
    --cc=stable@dpdk.org \
    --cc=tiwei.bie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).