From: Yongseok Koh <yskoh@mellanox.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Shahaf Shuler <shahafs@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: check Tx queue size overflow
Date: Wed, 1 May 2019 00:43:23 +0000 [thread overview]
Message-ID: <769F5F97-2566-4826-89BB-441B97481E44@mellanox.com> (raw)
Message-ID: <20190501004323.aQliTk9E3qfgGwLjrRxTK75KGXXoFIS_5J1chQ4j_-w@z> (raw)
In-Reply-To: <20190430134619.36cc9b21@hermes.lan>
> On Apr 30, 2019, at 1:46 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> On Tue, 30 Apr 2019 12:04:26 -0700
> Yongseok Koh <yskoh@mellanox.com> wrote:
>
>> + priv->sh->device_attr.orig_attr.max_qp_wr) {
>> + DRV_LOG(DEBUG,
>> + "port %u Tx WQEBB count exceeds the limit (%d),"
>> + " try smaller queue size again",
>> + dev->data->port_id,
>
> The patch looks good, but it could be improved to make life easier
> for the users.
>
> This is an error, why not print it at NOTICE level since DEBUG messages
> are usually suppressed.
Okay, better to set ERROR.
> Please don't break long lines in log messages.
That doesn't add new-line and mlx5 specific coding style.
> The latter part of the message
> is obvious, why not skip it.
Because not all users know what WQEBB means, I wanted to make user's life easier
by informing what to do.
> Also since max_qp_wr is __u32, the print format should be %u
It was copied from the removing line but agree to change.
> Instead:
> DRV_LOG(NOTICE,
> "port %u Tx WQEBB count (%u) exceeds the limit (%u)",
> dev->data->port_id,
> txq_calc_wqebb_cnt(tmpl),
> priv->sh->device_attr.orig_attr.max_qp_wr);
>
> Also, should it have a Fixes: tag to backport to stable?
Okay, no harm to give more information.
Thanks for the review.
Yongseok
next prev parent reply other threads:[~2019-05-01 0:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-30 19:04 Yongseok Koh
2019-04-30 19:04 ` Yongseok Koh
2019-04-30 20:46 ` Stephen Hemminger
2019-04-30 20:46 ` Stephen Hemminger
2019-05-01 0:43 ` Yongseok Koh [this message]
2019-05-01 0:43 ` Yongseok Koh
2019-05-01 0:56 ` Yongseok Koh
2019-05-01 0:56 ` Yongseok Koh
2019-05-01 1:01 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
2019-05-01 1:01 ` Yongseok Koh
2019-05-01 1:15 ` Yongseok Koh
2019-05-01 1:15 ` Yongseok Koh
2019-05-01 6:10 ` Shahaf Shuler
2019-05-01 6:10 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=769F5F97-2566-4826-89BB-441B97481E44@mellanox.com \
--to=yskoh@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).