From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Luca Boccassi <bluca@debian.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file
Date: Thu, 2 May 2019 16:30:40 +0100 [thread overview]
Message-ID: <20190502153040.GA322@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <5943797.eKmBmZ8x9O@xps>
On Thu, May 02, 2019 at 05:11:30PM +0200, Thomas Monjalon wrote:
> 02/05/2019 16:08, Luca Boccassi:
> > On Thu, 2019-05-02 at 14:17 +0100, Bruce Richardson wrote:
> > > On Thu, May 02, 2019 at 03:11:10PM +0200, Thomas Monjalon wrote:
> > > > 26/04/2019 16:56, Bruce Richardson:
> > > > > On Wed, Apr 24, 2019 at 02:37:58PM +0100, Luca Boccassi wrote:
> > > > > > On Wed, 2019-04-24 at 13:31 +0100, Bruce Richardson wrote:
> > > > > > > On Wed, Apr 24, 2019 at 12:02:24PM +0100, Luca Boccassi
> > > > > > > wrote:
> > > > > > > > On Wed, 2019-04-24 at 11:41 +0100, Bruce Richardson wrote:
> > > > > > > > > On Wed, Apr 24, 2019 at 10:22:04AM +0100, Luca Boccassi
> > > > > > > > > wrote:
> > > > > > > > > > On Tue, 2019-04-23 at 23:06 +0100, Bruce Richardson
> > > > > > > > > > wrote:
> > > > > > > > > > > +#
> > > > > > > > > > > rather
> > > > > > > > > > > than hacking our environment, just edit the .pc file
> > > > > > > > > > > prefix
> > > > > > > > > > > value
> > > > > > > > > > > +sed
> > > > > > > > > > > -i "s|prefix=|prefix=$DESTDIR|"
> > > > > > > > > > > $PKG_CONFIG_PATH/libdpdk.pc
> > > > > > > > > >
> > > > > > > > > > What about just using meson's prefix option instead?
> > > > > > > > > > Which is
> > > > > > > > > > how
> > > > > > > > > > it
> > > > > > > > > > would be used in a real use case
> > > > > > > > >
> > > > > > > > > I don't think that would fully work, as my understanding
> > > > > > > > > is that
> > > > > > > > > the
> > > > > > > > > prefix
> > > > > > > > > option would apply only to the /usr/local parts, but not
> > > > > > > > > to the
> > > > > > > > > kernel
> > > > > > > > > modules which would still try and install in /lib/.
> > > > > > > >
> > > > > > > > What about doing a meson configure -Denable_kmods=false
> > > > > > > > before the
> > > > > > > > ninja install? The modules are not needed for that test
> > > > > > > > anyway,
> > > > > > > > right?
> > > > > > > > Alternatively, the kernel src dir could be symlinked in the
> > > > > > > > build
> > > > > > > > path,
> > > > > > > > and the kernel_dir option could be used
> > > > > > > >
> > > > > > > > I'm just worried that the test should be as "realistic" as
> > > > > > > > possible, to
> > > > > > > > avoid missing something
> > > > > > >
> > > > > > > Yes, I did think of that too, but it does mean doing another
> > > > > > > configuration
> > > > > > > run in meson, and possibly a rebuild too if the
> > > > > > > rte_build_config.h
> > > > > > > file
> > > > > > > changes. Therefore I decided to use DESTDIR for the sake of
> > > > > > > speed
> > > > > > > here. I
> > > > > > > assumed there would be a pkg-config variable to adjust the
> > > > > > > output
> > > > > > > paths
> > > > > > > based on a sysroot, but couldn't find a suitable one.
> > > >
> > > > [...]
> > > > > > There actually is a pkg-config binary option, I just tried and
> > > > > > it works
> > > > > > (it seems to be disabled by default on Debian and derivatives):
> > > > > > --
> > > > > > define-prefix
> > > > > >
> > > > >
> > > > > Any cmdline options to pkg-config don't solve the problem here as
> > > > > it means
> > > > > that the makefiles for any app need to be modified to use all
> > > > > those.
> > > >
> > > > It looks to be a good solution.
> > > > Being able to update the DPDK install directory when building
> > > > an application should be a mandatory requirement.
> > > > I suggest to wrap the call to pkg-config so we can have this
> > > > ability.
> > > >
> > >
> > > I would have expected that this issue has already been solved for
> > > packagers. I was surprised that I couldn't find an easy way to do so.
> >
> > Packagers use standard paths - so it never becomes a problem.
> >
> > If editing the file on the fly is not acceptable for the test script,
> > then I'd suggest to fall back to the pkg-config option, and just
> > document the need to use it in the docs for this scenarios.
>
> What I mean is that we should be able to compile our apps
> after using DESTDIR, not related to the test script.
> Can we use an environment variable like RTE_TARGET? DPDK_DIR?
>
We can certainly add one to our example Makefiles, it's just a couple of
lines change to each one to add a prefix to the return value from
pkg-config. I can attempt to do so in a later version of this patch, though
I'd prefer to take more time over it than we have in 19.05.
Alternatively, we can defer the last couple of patches in this set to
19.08, though again I'd prefer to have even this level of minimal testing
of pkg-config into 19.05.
Let me know what you think is best?
/Bruce
next prev parent reply other threads:[~2019-05-02 15:30 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 22:06 [dpdk-dev] [PATCH 0/4] add testing of libdpdk " Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-23 22:06 ` [dpdk-dev] [PATCH 1/4] examples: install examples as part of ninja install Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-23 22:06 ` [dpdk-dev] [PATCH 2/4] examples: simplify getting list of all examples Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-23 22:06 ` [dpdk-dev] [PATCH 3/4] devtools/test-meson-builds: add testing of pkg-config file Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-24 9:22 ` Luca Boccassi
2019-04-24 9:22 ` Luca Boccassi
2019-04-24 10:41 ` Bruce Richardson
2019-04-24 10:41 ` Bruce Richardson
2019-04-24 11:02 ` Luca Boccassi
2019-04-24 11:02 ` Luca Boccassi
2019-04-24 12:31 ` Bruce Richardson
2019-04-24 12:31 ` Bruce Richardson
2019-04-24 13:37 ` Luca Boccassi
2019-04-24 13:37 ` Luca Boccassi
2019-04-26 14:56 ` Bruce Richardson
2019-04-26 14:56 ` Bruce Richardson
2019-04-26 16:10 ` Luca Boccassi
2019-04-26 16:10 ` Luca Boccassi
2019-05-02 13:11 ` Thomas Monjalon
2019-05-02 13:11 ` Thomas Monjalon
2019-05-02 13:17 ` Bruce Richardson
2019-05-02 13:17 ` Bruce Richardson
2019-05-02 14:08 ` Luca Boccassi
2019-05-02 14:08 ` Luca Boccassi
2019-05-02 15:11 ` Thomas Monjalon
2019-05-02 15:11 ` Thomas Monjalon
2019-05-02 15:30 ` Bruce Richardson [this message]
2019-05-02 15:30 ` Bruce Richardson
2019-05-02 15:38 ` Thomas Monjalon
2019-05-02 15:38 ` Thomas Monjalon
2019-05-02 15:41 ` Bruce Richardson
2019-05-02 15:41 ` Bruce Richardson
2019-04-23 22:06 ` [dpdk-dev] [PATCH 4/4] build: add libbsd to pkg-config file if enabled Bruce Richardson
2019-04-23 22:06 ` Bruce Richardson
2019-04-23 23:04 ` [dpdk-dev] [PATCH 0/4] add testing of libdpdk pkg-config file Stephen Hemminger
2019-04-23 23:04 ` Stephen Hemminger
2019-04-24 8:54 ` Bruce Richardson
2019-04-24 8:54 ` Bruce Richardson
2019-04-24 9:00 ` Bruce Richardson
2019-04-24 9:00 ` Bruce Richardson
2019-04-26 16:11 ` Luca Boccassi
2019-04-26 16:11 ` Luca Boccassi
2019-04-26 16:20 ` Bruce Richardson
2019-04-26 16:20 ` Bruce Richardson
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 0/6] " Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 1/6] examples/l3fwd: fix compile on FreeBSD Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-05-01 10:10 ` Luca Boccassi
2019-05-01 10:10 ` Luca Boccassi
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 2/6] examples: install examples as part of ninja install Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 3/6] build: fix ninja install on FreeBSD Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-05-01 10:10 ` Luca Boccassi
2019-05-01 10:10 ` Luca Boccassi
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 4/6] devtools/test-meson-builds: add testing of pkg-config file Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-05-02 12:38 ` Thomas Monjalon
2019-05-02 12:38 ` Thomas Monjalon
2019-05-02 12:54 ` Luca Boccassi
2019-05-02 12:54 ` Luca Boccassi
2019-05-02 13:21 ` Bruce Richardson
2019-05-02 13:21 ` Bruce Richardson
2019-05-02 13:57 ` Thomas Monjalon
2019-05-02 13:57 ` Thomas Monjalon
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 5/6] build: add libbsd to pkg-config file if enabled Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-04-26 16:50 ` [dpdk-dev] [PATCH v2 6/6] examples: remove auto-generation of examples list Bruce Richardson
2019-04-26 16:50 ` Bruce Richardson
2019-05-01 10:10 ` Luca Boccassi
2019-05-01 10:10 ` Luca Boccassi
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 0/4] file meson compilation and install issues Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 1/4] examples/l3fwd: fix compile on FreeBSD Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 2/4] examples: install examples as part of ninja install Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 3/4] build: fix ninja install on FreeBSD Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 16:51 ` [dpdk-dev] [PATCH v4 4/4] build: add libbsd to pkg-config file if enabled Bruce Richardson
2019-05-02 16:51 ` Bruce Richardson
2019-05-02 21:09 ` [dpdk-dev] [PATCH v4 0/4] file meson compilation and install issues Thomas Monjalon
2019-05-02 21:09 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190502153040.GA322@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).