DPDK patches and discussions
 help / color / mirror / Atom feed
From: Qi Zhang <qi.z.zhang@intel.com>
To: beilei.xing@intel.com, wenzhuo.lu@intel.com,
	qiming.yang@intel.com, konstantin.ananyev@intel.com
Cc: dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>
Subject: [dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup
Date: Sat,  4 May 2019 17:29:36 +0800	[thread overview]
Message-ID: <20190504092939.25326-1-qi.z.zhang@intel.com> (raw)
Message-ID: <20190504092936.wBT9-sqDHbabXWG8Y1YncpdRlbmY3BYgJz330zRf6E8@z> (raw)

When tx_free_thresh + tx_rs_thresh > nb_desc, it is possible
that an outdated DD status be checked as tx_next_dd, then segment fault
happen due to free a NULL mbuf pointer.

The issue usually happens with an aggresive tx_free_thresh, for example:

./testpmd -c 0x3 -n 4 -- -i --rxq=16 --txq=16 --rxd=1024 --txd=1024 --txfreet=1020

The patchset fix this issue on i40e, ixgbe and ice.

Qi Zhang (3):
  net/i40e: fix invalid Tx threshold setup
  net/ice: fix invalid Tx threshold setup
  net/ixgbe: fix invalid Tx threshold setup

 drivers/net/i40e/i40e_rxtx.c   | 19 +++++++++++++++++--
 drivers/net/ice/ice_rxtx.c     | 21 ++++++++++++++++++---
 drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++--
 3 files changed, 52 insertions(+), 7 deletions(-)

-- 
2.13.6


             reply	other threads:[~2019-05-04  9:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-04  9:29 Qi Zhang [this message]
2019-05-04  9:29 ` Qi Zhang
2019-05-04  9:29 ` [dpdk-dev] [PATCH 1/3] net/i40e: fix invalid Tx threshold setup Qi Zhang
2019-05-04  9:29   ` Qi Zhang
2019-05-04  9:29 ` [dpdk-dev] [PATCH 2/3] net/ice: " Qi Zhang
2019-05-04  9:29   ` Qi Zhang
2019-05-04  9:29 ` [dpdk-dev] [PATCH 3/3] net/ixgbe: " Qi Zhang
2019-05-04  9:29   ` Qi Zhang
2019-05-15  6:36 ` [dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup Xing, Beilei
2019-05-15  6:36   ` Xing, Beilei
2019-05-15  7:09   ` Zhang, Qi Z
2019-05-15  7:09     ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190504092939.25326-1-qi.z.zhang@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).