From: Thomas Monjalon <thomas@monjalon.net>
To: "Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>,
"Kovacevic, Marko" <marko.kovacevic@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: fix broken link in programmers guide lpm library references
Date: Sat, 04 May 2019 23:41:20 +0200 [thread overview]
Message-ID: <2780130.9Jl3BgUzFK@xps> (raw)
Message-ID: <20190504214120.S3-4f-Xb0c-GyC0FKOWMJobRYIi5G30cxXdrHbHCKNc@z> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23F60A1EE@IRSMSX103.ger.corp.intel.com>
01/05/2019 16:12, Mcnamara, John:
> From: Lipiec, Herakliusz
> >
> > Bugzilla ID: 235
>
> The fix is good and should be applied.
>
> However, if viewed strictly, that `Link text <https://url/>`_ syntax is only required if the link text and the url are different.
>
> So in this case you could (or the original author) just use a simple url without any additional syntax.
>
> However, better still would be if we did something like this to put the links inline in the text:
Yes, that would be good to do this kind of cleanup in the guides.
[...]
> However, the fix is better than a broken link so:
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Applied, thanks
next prev parent reply other threads:[~2019-05-04 21:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 15:35 Herakliusz Lipiec
2019-04-24 15:35 ` Herakliusz Lipiec
2019-04-24 18:52 ` Rami Rosen
2019-04-24 18:52 ` Rami Rosen
2019-04-25 10:21 ` Medvedkin, Vladimir
2019-04-25 10:21 ` Medvedkin, Vladimir
2019-05-01 14:12 ` Mcnamara, John
2019-05-01 14:12 ` Mcnamara, John
2019-05-04 21:41 ` Thomas Monjalon [this message]
2019-05-04 21:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2780130.9Jl3BgUzFK@xps \
--to=thomas@monjalon.net \
--cc=bernard.iremonger@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=herakliusz.lipiec@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).