From: Alexander Kozyrev <akozyrev@nvidia.com>
To: <dev@dpdk.org>
Cc: <stable@dpdk.org>, <rasland@nvidia.com>, <viacheslavo@nvidia.com>,
<matan@nvidia.com>
Subject: [PATCH 3/3] app/testpmd: fix meter mark handle update
Date: Tue, 11 Jul 2023 18:20:44 +0300 [thread overview]
Message-ID: <20230711152044.3141138-3-akozyrev@nvidia.com> (raw)
In-Reply-To: <20230711152044.3141138-1-akozyrev@nvidia.com>
The indirect action handle update for the METER_MERK action
was implemented only for the async RTE Flow API.
Allow updating the METER_MARK parameters via the old sync method.
Fixes: 9c4a0c1859a3 ("ethdev: add meter color mark flow action")
Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
---
app/test-pmd/config.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index c4784b7f2c..58ac1576b7 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1943,6 +1943,7 @@ port_action_handle_update(portid_t port_id, uint32_t id,
struct rte_flow_error error;
struct rte_flow_action_handle *action_handle;
struct port_indirect_action *pia;
+ struct rte_flow_update_meter_mark mtr_update;
const void *update;
action_handle = port_action_handle_get_by_id(port_id, id);
@@ -1956,6 +1957,17 @@ port_action_handle_update(portid_t port_id, uint32_t id,
case RTE_FLOW_ACTION_TYPE_CONNTRACK:
update = action->conf;
break;
+ case RTE_FLOW_ACTION_TYPE_METER_MARK:
+ rte_memcpy(&mtr_update.meter_mark, action->conf,
+ sizeof(struct rte_flow_action_meter_mark));
+ if (mtr_update.meter_mark.profile)
+ mtr_update.profile_valid = 1;
+ if (mtr_update.meter_mark.policy)
+ mtr_update.policy_valid = 1;
+ mtr_update.color_mode_valid = 1;
+ mtr_update.state_valid = 1;
+ update = &mtr_update;
+ break;
default:
update = action;
break;
@@ -3162,8 +3174,10 @@ port_queue_action_handle_update(portid_t port_id,
case RTE_FLOW_ACTION_TYPE_METER_MARK:
rte_memcpy(&mtr_update.meter_mark, action->conf,
sizeof(struct rte_flow_action_meter_mark));
- mtr_update.profile_valid = 1;
- mtr_update.policy_valid = 1;
+ if (mtr_update.meter_mark.profile)
+ mtr_update.profile_valid = 1;
+ if (mtr_update.meter_mark.policy)
+ mtr_update.policy_valid = 1;
mtr_update.color_mode_valid = 1;
mtr_update.init_color_valid = 1;
mtr_update.state_valid = 1;
--
2.18.2
next prev parent reply other threads:[~2023-07-11 15:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-11 15:20 [PATCH 1/3] net/mlx5: fix validation for conntrack indirect action Alexander Kozyrev
2023-07-11 15:20 ` [PATCH 2/3] net/mlx5: fix handle validation for meter mark Alexander Kozyrev
2023-07-18 9:02 ` Suanming Mou
2023-07-11 15:20 ` Alexander Kozyrev [this message]
2023-07-11 16:15 ` [PATCH 3/3] app/testpmd: fix meter mark handle update Stephen Hemminger
2023-07-18 13:27 ` Alexander Kozyrev
2023-07-18 9:01 ` [PATCH 1/3] net/mlx5: fix validation for conntrack indirect action Suanming Mou
2023-07-18 13:32 ` [PATCH v2 " Alexander Kozyrev
2023-07-18 13:32 ` [PATCH v2 2/3] net/mlx5: fix handle validation for meter mark Alexander Kozyrev
2023-07-18 14:31 ` Ori Kam
2023-07-18 13:32 ` [PATCH v2 3/3] app/testpmd: fix meter mark handle update Alexander Kozyrev
2023-07-18 14:32 ` Ori Kam
2023-07-18 14:29 ` [PATCH v2 1/3] net/mlx5: fix validation for conntrack indirect action Ori Kam
2023-07-18 15:51 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230711152044.3141138-3-akozyrev@nvidia.com \
--to=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).