DPDK patches and discussions
 help / color / mirror / Atom feed

From: Ferruh Yigit <ferruh.yigit@intel.com>
To: alvinx.zhang@intel.com, haiyue.wang@intel.com,
	qi.z.zhang@intel.com, beilei.xing@intel.com,
	xiaolong.ye@intel.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [RFC 1/7] net/igc: base driver
Date: Tue, 21 Jan 2020 16:27:11 +0000	[thread overview]
Message-ID: <227edcf2-2365-8f9e-186a-fb00b1a6ae80@intel.com> (raw)
In-Reply-To: <1578625225-110361-1-git-send-email-alvinx.zhang@intel.com>

On 1/10/2020 3:00 AM, alvinx.zhang@intel.com wrote:
> From: Alvin Zhang <alvinx.zhang@intel.com>
> 
> Add shared code source files to support basic operations to be
> called in poll mode driver.
> 
> Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>

Hi Alvin,

I would suggest a different organization of the patches.

Currently first patch dumps all shared code, second all the DPDK driver files.
Later patches does in each patch, Makefile based build system, meson based build
system and documentation.

First question if all shared code are used, if not please drop the ones that are
not used as much as possible.

Second please try to split into the logical pieces, like a logical piece can be
setting MTU (just a sample) and you can put shared code, dpdk code and
documentation related to it in same patch.

Also can you please start the series with a skeleton, which introduces the build
system files, configs, Maintainer file update, generic docs. At this stage code
can be empty, and the driver can be disabled by default.
And if you have to, second patch can have a minimum required shared code drop.
After this the driver can be built gradually feature by feature, perhaps
starting from the probe/remove support.

Thanks,
ferruh

next prev parent reply	other threads:[~2020-01-21 16:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10  3:00 alvinx.zhang
2020-01-10  3:00 ` [dpdk-dev] [RFC 2/7] net/igc: igc poll mode driver alvinx.zhang
2020-01-10  3:00 ` [dpdk-dev] [RFC 3/7] drivers/net: add igc make alvinx.zhang
2020-01-21 16:43   ` Ferruh Yigit
2020-02-24  4:06     ` Zhang, AlvinX
2020-01-10  3:00 ` [dpdk-dev] [RFC 4/7] igc: add igc library alvinx.zhang
2020-01-10  3:00 ` [dpdk-dev] [RFC 5/7] drivers/net: add meson build for igc alvinx.zhang
2020-01-10  3:00 ` [dpdk-dev] [RFC 6/7] config/common_base: add igc PMD flags alvinx.zhang
2020-01-10  3:00 ` [dpdk-dev] [RFC 7/7] doc: add igc guide and feature list alvinx.zhang
2020-01-21 16:27 ` Ferruh Yigit [this message]
2020-02-24  3:58   ` [dpdk-dev] [RFC 1/7] net/igc: base driver Zhang, AlvinX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=227edcf2-2365-8f9e-186a-fb00b1a6ae80@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=alvinx.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).