From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"marcel@redhat.com" <marcel@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [dpdk-dev] [PATCH v6 10/13] ixgbe: support VMDq RSS in non-SRIOV environment
Date: Wed, 21 Oct 2015 13:03:28 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836AB34A6@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <20151021130114.GI3115@yliu-dev.sh.intel.com>
Hi Yliu,
> -----Original Message-----
> From: Yuanhan Liu [mailto:yuanhan.liu@linux.intel.com]
> Sent: Wednesday, October 21, 2015 2:01 PM
> To: Ananyev, Konstantin
> Cc: dev@dpdk.org; Michael S. Tsirkin; marcel@redhat.com
> Subject: Re: [dpdk-dev] [PATCH v6 10/13] ixgbe: support VMDq RSS in non-SRIOV environment
>
> > > static int
> > > +ixgbe_config_vmdq_rss(struct rte_eth_dev *dev)
> > > +{
> > > + struct ixgbe_hw *hw;
> > > + uint32_t mrqc;
> > > +
> > > + ixgbe_rss_configure(dev);
> > > +
> > > + hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> > > +
> > > + /* MRQC: enable VMDQ RSS */
> > > + mrqc = IXGBE_READ_REG(hw, IXGBE_MRQC);
> > > + mrqc &= ~IXGBE_MRQC_MRQE_MASK;
> > > +
> > > + switch (RTE_ETH_DEV_SRIOV(dev).nb_q_per_pool) {
> > > + case 2:
> > > + mrqc |= IXGBE_MRQC_VMDQRSS64EN;
> > > + break;
> > > +
> > > + case 4:
> > > + mrqc |= IXGBE_MRQC_VMDQRSS32EN;
> > > + break;
> > > +
> > > + default:
> > > + PMD_INIT_LOG(ERR, "Invalid pool number in non-IOV mode with VMDQ RSS");
> > > + return -EINVAL;
> > > + }
> > > +
> > > + IXGBE_WRITE_REG(hw, IXGBE_MRQC, mrqc);
> > > +
> > > + ixgbe_vmdq_pool_configure(dev);
> > > +
> > > + return 0;
> > > +}
> >
> > So ixgbe_config_vmdq_rss() checks nb_q_per_pool value, and might return an error if the value is invalid.
> > Though this return value seems just ignored by ixgbe_dev_mq_rx_configure() below.
> > Probably, it is better to move nb_q_per_pool value checking into rte_eth_dev_check_mq_mode(),
> > as is done for other modes?
> > I know it is no ideal, as it probably should be HW specific check,
> > but seems anyway better than just ignoring the error.
> >
>
> Hi,
>
> Thanks for the review. However, as you might have seen, I dropped this
> patch in the lastest version. This patch is for using the NIC VMDq
> feature to link with VM multiple queue to demonstrate the multiple
> queue feature. However, this introduces too much limitation. So,
> I dropped it.
Ah sorry, didn't notice it - too many patches are flying around these days.
>
> However, despite of above usage, if you think it's necessary to add
> such ability (support VMDq RSS in non-SRIOV), I could update this patch
> based on your comments, and sent it out as a standalone patch. Otherwise,
> I'll simply drop it.
That's ok by me.
Konstantin
>
> --yliu
next prev parent reply other threads:[~2015-10-21 13:03 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 5:45 [dpdk-dev] [PATCH v6 00/13] vhost-user multiple queues enabling Yuanhan Liu
2015-10-09 5:46 ` [dpdk-dev] [PATCH v6 01/13] vhost-user: add protocol features support Yuanhan Liu
2015-10-09 5:46 ` [dpdk-dev] [PATCH v6 02/13] vhost-user: add VHOST_USER_GET_QUEUE_NUM message Yuanhan Liu
2015-10-09 5:46 ` [dpdk-dev] [PATCH v6 03/13] vhost: vring queue setup for multiple queue support Yuanhan Liu
2015-10-20 6:49 ` Thomas Monjalon
2015-10-20 6:56 ` Yuanhan Liu
2015-10-09 5:46 ` [dpdk-dev] [PATCH v6 04/13] vhost: rxtx: prepare work " Yuanhan Liu
2015-10-20 6:57 ` Thomas Monjalon
2015-10-20 7:10 ` Yuanhan Liu
2015-10-20 7:24 ` Thomas Monjalon
2015-10-09 5:46 ` [dpdk-dev] [PATCH v6 05/13] vhost-user: handle VHOST_USER_RESET_OWNER correctly Yuanhan Liu
2015-10-20 7:03 ` Thomas Monjalon
2015-10-20 7:14 ` Yuanhan Liu
2015-10-09 5:46 ` [dpdk-dev] [PATCH v6 06/13] virtio: read virtio_net_config correctly Yuanhan Liu
2015-10-20 7:07 ` Thomas Monjalon
2015-10-20 7:23 ` Yuanhan Liu
2015-10-20 7:27 ` Thomas Monjalon
2015-10-20 8:00 ` Yuanhan Liu
2015-10-09 5:46 ` [dpdk-dev] [PATCH v6 07/13] vhost-user: enable vhost-user multiple queue Yuanhan Liu
2015-10-09 5:46 ` [dpdk-dev] [PATCH v6 08/13] vhost: add VHOST_USER_SET_VRING_ENABLE message Yuanhan Liu
2015-10-09 5:46 ` [dpdk-dev] [PATCH v6 09/13] vhost: add API bind a virtq to a specific core Yuanhan Liu
[not found] ` <C37D651A908B024F974696C65296B57B4B12E8D3@SHSMSX101.ccr.corp.intel.com>
2015-10-20 6:25 ` Yuanhan Liu
2015-10-20 7:17 ` Thomas Monjalon
2015-10-09 5:46 ` [dpdk-dev] [PATCH v6 10/13] ixgbe: support VMDq RSS in non-SRIOV environment Yuanhan Liu
2015-10-20 7:46 ` Thomas Monjalon
[not found] ` <2601191342CEEE43887BDE71AB97725836AB3299@irsmsx105.ger.corp.intel.com>
2015-10-21 13:01 ` Yuanhan Liu
2015-10-21 13:03 ` Ananyev, Konstantin [this message]
2015-10-09 5:46 ` [dpdk-dev] [PATCH v6 11/13] examples/vhost: demonstrate the usage of vhost mq feature Yuanhan Liu
2015-10-09 5:46 ` [dpdk-dev] [PATCH v6 12/13] examples/vhost: add per queue stats Yuanhan Liu
2015-10-09 5:46 ` [dpdk-dev] [PATCH v6 13/13] doc: update release note for vhost-user mq support Yuanhan Liu
2015-10-09 13:45 ` [dpdk-dev] [PATCH v6 00/13] vhost-user multiple queues enabling Marcel Apfelbaum
2015-10-19 13:16 ` Flavio Leitner
2015-10-20 10:39 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836AB34A6@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).