From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v3] i40: fix the VXLAN TSO issue
Date: Fri, 29 Jul 2016 08:45:42 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB97725836B8AF7D@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <3d08c8b3-fc33-ddbc-196b-c43a65d5779f@intel.com>
Hi Jianfeng,
>
> Hi,
>
> On 7/18/2016 7:56 PM, Zhe Tao wrote:
> > Problem:
> > When using the TSO + VXLAN feature in i40e, the outer UDP length
> > fields in the multiple UDP segments which are TSOed by the i40e will
> > have a wrong value.
> >
> > Fix this problem by adding the tunnel type field in the i40e
> > descriptor which was missed before.
> >
> > Fixes: 77b8301733c3 ("i40e: VXLAN Tx checksum offload")
> >
> > Signed-off-by: Zhe Tao <zhe.tao@intel.com>
> > ---
> > v2: edited the comments
> > v3: added external IP offload flag when TSO is enabled for tunnelling
> > packets
> >
> > app/test-pmd/csumonly.c | 29 +++++++++++++++++++++--------
> > drivers/net/i40e/i40e_rxtx.c | 12 +++++++++---
> > lib/librte_mbuf/rte_mbuf.h | 16 +++++++++++++++-
> > 3 files changed, 45 insertions(+), 12 deletions(-)
> >
> ...
> > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> > index 15e3a10..90812ea 100644
> > --- a/lib/librte_mbuf/rte_mbuf.h
> > +++ b/lib/librte_mbuf/rte_mbuf.h
> > @@ -133,6 +133,17 @@ extern "C" {
> > /* add new TX flags here */
> >
> > /**
> > + * Bits 45:48 used for the tunnel type.
> > + * When doing Tx offload like TSO or checksum, the HW needs to
> > +configure the
> > + * tunnel type into the HW descriptors.
> > + */
> > +#define PKT_TX_TUNNEL_VXLAN (1ULL << 45)
> > +#define PKT_TX_TUNNEL_GRE (2ULL << 45)
> > +#define PKT_TX_TUNNEL_IPIP (3ULL << 45)
> > +/* add new TX TUNNEL type here */
> > +#define PKT_TX_TUNNEL_MASK (0xFULL << 45)
> > +
>
> Above flag bits are added so that i40e driver can tell tunnel type of this packet (udp or gre or ipip), just interested to know how about just do
> a simple analysis like below without introducing these flags?
>
> if outer_ether.proto == ipv4
> l4_proto = ipv4_hdr->next_proto;
> else outer_ether.proto == ipv6
> l4_proto = ipv6_hdr->next_proto;
>
> switch (l4_proto)
> case ipv4:
> case ipv6:
> tunnel_type = ipip;
> break;
> case udp:
> tunnel_type = udp;
> break;
> case gre:
> tunnel_type = gre;
> break;
> default:
> error;
Right now none of our PMDs reads/writes actual packet data,
and I think it is better to keep it that way.
It is an upper layer responsibility to specify which offload
needs to be enabled and provide necessary information.
Konstantin
>
> Thanks,
> Jianfeng
>
>
> > +/**
> > * Second VLAN insertion (QinQ) flag.
> > */
> > #define PKT_TX_QINQ_PKT (1ULL << 49) /**< TX packet with double VLAN inserted. */
> > @@ -867,7 +878,10 @@ struct rte_mbuf {
> > union {
> > uint64_t tx_offload; /**< combined for easy fetch */
> > struct {
> > - uint64_t l2_len:7; /**< L2 (MAC) Header Length. */
> > + uint64_t l2_len:7;
> > + /**< L2 (MAC) Header Length if it isn't a tunneling pkt.
> > + * for tunnel it is outer L4 len+tunnel len+inner L2 len
> > + */
> > uint64_t l3_len:9; /**< L3 (IP) Header Length. */
> > uint64_t l4_len:8; /**< L4 (TCP/UDP) Header Length. */
> > uint64_t tso_segsz:16; /**< TCP TSO segment size */
next prev parent reply other threads:[~2016-07-29 8:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 20:59 [dpdk-dev] [PATCH v1] " Zhe Tao
2016-07-06 5:38 ` Wu, Jingjing
2016-07-07 4:27 ` [dpdk-dev] [PATCH v2] " Zhe Tao
2016-07-07 10:01 ` Ananyev, Konstantin
2016-07-07 10:50 ` Ananyev, Konstantin
2016-07-07 12:24 ` Ananyev, Konstantin
2016-07-15 15:40 ` Bruce Richardson
2016-07-18 2:57 ` Zhe Tao
2016-07-18 11:56 ` [dpdk-dev] [PATCH v3] " Zhe Tao
2016-07-19 10:29 ` Ananyev, Konstantin
2016-07-26 12:22 ` Tan, Jianfeng
2016-07-29 7:11 ` Tan, Jianfeng
2016-07-29 8:45 ` Ananyev, Konstantin [this message]
2016-07-29 10:11 ` Tan, Jianfeng
2016-10-10 3:58 ` [dpdk-dev] [PATCH v2] " Wu, Jingjing
2016-10-10 4:14 ` Yuanhan Liu
2016-08-01 3:56 ` [dpdk-dev] [PATCH v4 0/3] Add TSO on tunneling packet Jianfeng Tan
2016-08-01 3:56 ` [dpdk-dev] [PATCH v4 1/3] mbuf: add Tx side tunneling type Jianfeng Tan
2016-08-01 3:56 ` [dpdk-dev] [PATCH v4 2/3] net/i40e: add TSO support on tunneling packet Jianfeng Tan
2016-08-01 3:56 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: fix Tx offload " Jianfeng Tan
2016-09-19 12:09 ` Ananyev, Konstantin
2016-09-21 12:36 ` Tan, Jianfeng
2016-09-21 15:47 ` Ananyev, Konstantin
2016-09-22 1:29 ` Tan, Jianfeng
2016-09-22 9:15 ` Ananyev, Konstantin
[not found] ` <ED26CBA2FAD1BF48A8719AEF02201E364E5E09BC@SHSMSX103.ccr.corp.intel.com>
[not found] ` <2601191342CEEE43887BDE71AB97725836BA2698@irsmsx105.ger.corp.intel.com>
2016-09-27 17:29 ` [dpdk-dev] [PATCH v4 0/3] Add TSO " Ananyev, Konstantin
2016-09-27 17:52 ` Tan, Jianfeng
2016-09-27 19:47 ` Thomas Monjalon
2016-10-09 21:27 ` Thomas Monjalon
2016-09-26 13:48 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: support tunneled TSO in csum fwd engine Jianfeng Tan
2016-09-27 17:25 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB97725836B8AF7D@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).