From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 3/3] app/testpmd: support tunneled TSO in csum fwd engine
Date: Tue, 27 Sep 2016 17:25:56 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772583F0BBE86@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <1474897714-28037-1-git-send-email-jianfeng.tan@intel.com>
> -----Original Message-----
> From: Tan, Jianfeng
> Sent: Monday, September 26, 2016 2:49 PM
> To: dev@dpdk.org
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Tan, Jianfeng
> <jianfeng.tan@intel.com>; Zhe Tao <zhe.tao@intel.com>
> Subject: [PATCH v5 3/3] app/testpmd: support tunneled TSO in csum fwd engine
>
> Add a new command "tunnel_tso set <tso_segsz> <port>" to enable
> segmentation offload and set MSS to tso_segsz. Another command,
> "tunnel_tso show <port>" is added to show tunneled packet MSS.
> Result 0 means tunnel_tso is disabled.
>
> The original commands, "tso set <tso_segsz> <port>" and "tso show
> <port>" are only reponsible for non-tunneled packets. And the new
> commands are for tunneled packets.
>
> Below conditions are needed to make it work:
> a. tunnel TSO is supported by the NIC;
> b. "csum parse_tunnel" must be set so that tunneled pkts are
> recognized;
> c. for tunneled pkts with outer L3 is IPv4, "csum set outer-ip"
> must be set to hw, because after tso, total_len of outer IP
> header is changed, and the checksum of outer IP header calculated
> by sw should be wrong; that is not necessary for IPv6 tunneled
> pkts because there's no checksum field to be filled anymore.
>
> Suggested-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> Signed-off-by: Zhe Tao <zhe.tao@intel.com>
> Signed-off-by: Jianfeng Tan <jianfeng.tan@intel.com>
> ---
> v5:
> -- Instead of reuse original tso command, add a new command for
> tunneled tso;
> -- Fix a implicit conversion from long -> int bug, as the parameter
> of process_outer_cksums() in previous version.
> app/test-pmd/cmdline.c | 132 +++++++++++++++++++++++++++++++++++++++++++++---
> app/test-pmd/csumonly.c | 69 ++++++++++++++++++-------
> app/test-pmd/testpmd.h | 3 +-
> 3 files changed, 179 insertions(+), 25 deletions(-)
>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
prev parent reply other threads:[~2016-09-27 17:25 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 20:59 [dpdk-dev] [PATCH v1] i40: fix the VXLAN TSO issue Zhe Tao
2016-07-06 5:38 ` Wu, Jingjing
2016-07-07 4:27 ` [dpdk-dev] [PATCH v2] " Zhe Tao
2016-07-07 10:01 ` Ananyev, Konstantin
2016-07-07 10:50 ` Ananyev, Konstantin
2016-07-07 12:24 ` Ananyev, Konstantin
2016-07-15 15:40 ` Bruce Richardson
2016-07-18 2:57 ` Zhe Tao
2016-07-18 11:56 ` [dpdk-dev] [PATCH v3] " Zhe Tao
2016-07-19 10:29 ` Ananyev, Konstantin
2016-07-26 12:22 ` Tan, Jianfeng
2016-07-29 7:11 ` Tan, Jianfeng
2016-07-29 8:45 ` Ananyev, Konstantin
2016-07-29 10:11 ` Tan, Jianfeng
2016-10-10 3:58 ` [dpdk-dev] [PATCH v2] " Wu, Jingjing
2016-10-10 4:14 ` Yuanhan Liu
2016-08-01 3:56 ` [dpdk-dev] [PATCH v4 0/3] Add TSO on tunneling packet Jianfeng Tan
2016-08-01 3:56 ` [dpdk-dev] [PATCH v4 1/3] mbuf: add Tx side tunneling type Jianfeng Tan
2016-08-01 3:56 ` [dpdk-dev] [PATCH v4 2/3] net/i40e: add TSO support on tunneling packet Jianfeng Tan
2016-08-01 3:56 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: fix Tx offload " Jianfeng Tan
2016-09-19 12:09 ` Ananyev, Konstantin
2016-09-21 12:36 ` Tan, Jianfeng
2016-09-21 15:47 ` Ananyev, Konstantin
2016-09-22 1:29 ` Tan, Jianfeng
2016-09-22 9:15 ` Ananyev, Konstantin
[not found] ` <ED26CBA2FAD1BF48A8719AEF02201E364E5E09BC@SHSMSX103.ccr.corp.intel.com>
[not found] ` <2601191342CEEE43887BDE71AB97725836BA2698@irsmsx105.ger.corp.intel.com>
2016-09-27 17:29 ` [dpdk-dev] [PATCH v4 0/3] Add TSO " Ananyev, Konstantin
2016-09-27 17:52 ` Tan, Jianfeng
2016-09-27 19:47 ` Thomas Monjalon
2016-10-09 21:27 ` Thomas Monjalon
2016-09-26 13:48 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: support tunneled TSO in csum fwd engine Jianfeng Tan
2016-09-27 17:25 ` Ananyev, Konstantin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772583F0BBE86@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).