From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Ilya Matveychikov <matvejchikov@gmail.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] mbuf: remove redundant line in rte_pktmbuf_attach
Date: Sat, 21 Jan 2017 16:28:29 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772583F10925D@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <37EFD294-2DEE-4140-9A74-423429B82B02@gmail.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ilya Matveychikov
> Sent: Saturday, January 21, 2017 3:08 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] mbuf: remove redundant line in rte_pktmbuf_attach
>
>
> > On Jan 20, 2017, at 4:08 PM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >
> > On 1/20/2017 12:19 AM, Ilya Matveychikov wrote:
> >> mi->next will be assigned to NULL few lines later, trivial patch
> >>
> >> Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> >> ---
> >> lib/librte_mbuf/rte_mbuf.h | 1 -
> >> 1 file changed, 1 deletion(-)
> >>
> >> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> >> index ead7c6e..5589d54 100644
> >> --- a/lib/librte_mbuf/rte_mbuf.h
> >> +++ b/lib/librte_mbuf/rte_mbuf.h
> >> @@ -1139,7 +1139,6 @@ static inline void rte_pktmbuf_attach(struct rte_mbuf *mi, struct rte_mbuf *m)
> >> mi->buf_addr = m->buf_addr;
> >> mi->buf_len = m->buf_len;
> >>
> >> - mi->next = m->next;
> >
> > Do you know why attaching mbuf is not supporting multi-segment?
This is supported, but you have to do it segment by segment.
Actually rte_pktmbuf_clone() does that.
Konstantin
> > Perhaps this can be documented in function comment, as one of the "not
> > supported" items.
>
> No, I don’t know. For my application I’ve found that nb_segs with it’s limit in 256 segments is very annoying and I’ve decided not to use
> DPDK functions that dealt with nb_segs… But it is not about the rte_pktmbuf_attach() function and the patch.
>
> > Also, should we check mi->next before overwriting, in case it is not NULL?
> >
> >> mi->data_off = m->data_off;
> >> mi->data_len = m->data_len;
> >> mi->port = m->port;
> >>
> >
>
> I don’t know. It depends of the usage. Will someone needs to chain two chains of mbuf?
next prev parent reply other threads:[~2017-01-21 16:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 0:19 Ilya Matveychikov
2017-01-20 12:08 ` Ferruh Yigit
2017-01-21 15:08 ` Ilya Matveychikov
2017-01-21 16:28 ` Ananyev, Konstantin [this message]
2017-01-24 12:56 ` Olivier MATZ
2017-01-24 15:57 ` Ilya Matveychikov
2017-01-24 16:19 ` Olivier MATZ
2017-01-30 8:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772583F10925D@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matvejchikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).