From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: make txonly mode generate multiple flows
Date: Fri, 19 Jan 2018 11:02:18 +0000 [thread overview]
Message-ID: <2601191342CEEE43887BDE71AB9772588628095E@irsmsx105.ger.corp.intel.com> (raw)
In-Reply-To: <AC95B62A-F642-4897-B627-96A4D4ACDD13@mellanox.com>
> -----Original Message-----
> From: Yongseok Koh [mailto:yskoh@mellanox.com]
> Sent: Friday, January 19, 2018 7:10 AM
> To: Ananyev, Konstantin <konstantin.ananyev@intel.com>
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; dev@dpdk.org; Jerin Jacob
> <jerin.jacob@caviumnetworks.com>
> Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: make txonly mode generate multiple flows
>
>
> > On Jan 18, 2018, at 4:21 AM, Ananyev, Konstantin <konstantin.ananyev@intel.com> wrote:
> >
> > Hi,
> >
> >> -----Original Message-----
> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yongseok Koh
> >> Sent: Wednesday, January 17, 2018 6:19 PM
> >> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>
> >> Cc: dev@dpdk.org; Yongseok Koh <yskoh@mellanox.com>
> >> Subject: [dpdk-dev] [PATCH v2] app/testpmd: make txonly mode generate multiple flows
> >>
> >> Testpmd can generate multiple flows without taking much cost and this could
> >> be a simple traffic generator for developer's quick tests. IP destination
> >> address is varied.
> >
> > Correct me if I am wrong - but that the change of existing behavior.
> > Without any announcement and without ability to the user to keep
> > current one (command-line option, new CLI command, etc.).
> > What if there are people who rely on existing behavior
> > (some test scripts or so)?
> > Konstantin
>
> Good point. But I think it is unlikely. Currently, it generates single fat flow
> and if someone uses it for testing, then Rx side likely uses single core. Even
> if it gets to generate multiple flows, it would be same to such a case.
>
> However, it is my speculation. If you disagree anyway, I'll stash it for 18.05
> and add a new knob to enable it. I'm okay with that because it is just for
> convenience, not an urgent issue.
>
Yes, I think some sort of announcement would be good.
Another alternative - add for user an ability to choose - new CLI command or so.
Konstantin
next prev parent reply other threads:[~2018-01-19 11:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 21:11 [dpdk-dev] [PATCH] " Yongseok Koh
2018-01-12 18:08 ` Thomas Monjalon
2018-01-16 2:40 ` Lu, Wenzhuo
2018-01-17 18:04 ` Yongseok Koh
2018-01-17 18:18 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
2018-01-18 1:22 ` Lu, Wenzhuo
2018-01-18 12:21 ` Ananyev, Konstantin
2018-01-19 7:09 ` Yongseok Koh
2018-01-19 11:02 ` Ananyev, Konstantin [this message]
2018-01-18 13:55 ` Jerin Jacob
2019-03-28 1:51 ` [dpdk-dev] [PATCH v3] " Yongseok Koh
2019-03-28 1:51 ` Yongseok Koh
2019-03-28 10:24 ` Iremonger, Bernard
2019-03-28 10:24 ` Iremonger, Bernard
2019-03-28 17:33 ` Yongseok Koh
2019-03-28 17:33 ` Yongseok Koh
2019-03-28 17:42 ` Iremonger, Bernard
2019-03-28 17:42 ` Iremonger, Bernard
2019-03-28 18:46 ` [dpdk-dev] [PATCH v4] " Yongseok Koh
2019-03-28 18:46 ` Yongseok Koh
2019-03-29 9:55 ` Iremonger, Bernard
2019-03-29 9:55 ` Iremonger, Bernard
2019-03-29 18:44 ` Ferruh Yigit
2019-03-29 18:44 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2601191342CEEE43887BDE71AB9772588628095E@irsmsx105.ger.corp.intel.com \
--to=konstantin.ananyev@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jingjing.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).