From: Yongseok Koh <yskoh@mellanox.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "Wu, Jingjing" <jingjing.wu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: make txonly mode generate multiple flows
Date: Wed, 17 Jan 2018 18:04:06 +0000 [thread overview]
Message-ID: <755704D8-192C-43E6-9EC5-BCB7FA4591C3@mellanox.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B710FEA@shsmsx102.ccr.corp.intel.com>
> On Jan 15, 2018, at 6:40 PM, Lu, Wenzhuo <wenzhuo.lu@intel.com> wrote:
>
> Hi Yongseok,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yongseok Koh
>> Sent: Saturday, December 16, 2017 5:11 AM
>> To: Wu, Jingjing <jingjing.wu@intel.com>
>> Cc: dev@dpdk.org; Yongseok Koh <yskoh@mellanox.com>
>> Subject: [dpdk-dev] [PATCH] app/testpmd: make txonly mode generate
>> multiple flows
>>
>> Testpmd can generate multiple flows without taking much cost and this
>> could be a simple traffic generator for developer's quick tests. IP destination
>> address is varied.
>>
>> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
>> ---
>> app/test-pmd/txonly.c | 12 +++++++++++-
>> 1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index
>> 309c73893..aa4c379c4 100644
>> --- a/app/test-pmd/txonly.c
>> +++ b/app/test-pmd/txonly.c
>> @@ -73,7 +73,7 @@
>> #define UDP_DST_PORT 1024
>>
>> #define IP_SRC_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 1) -#define
>> IP_DST_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 2)
>> +#define IP_DST_ADDR ((192U << 24) | (168 << 16))
>>
>> #define IP_DEFTTL 64 /* from RFC 1340. */
>> #define IP_VERSION 0x40
>> @@ -81,6 +81,7 @@
>> #define IP_VHL_DEF (IP_VERSION | IP_HDRLEN)
>>
>> static struct ipv4_hdr pkt_ip_hdr; /**< IP header of transmitted packets. */
>> +static __thread uint8_t ip_var; /**< IP address variation */
>> static struct udp_hdr pkt_udp_hdr; /**< UDP header of transmitted packets.
>> */
>>
>> static void
>> @@ -187,6 +188,7 @@ pkt_burst_transmit(struct fwd_stream *fs)
>> struct rte_mbuf *pkt_seg;
>> struct rte_mempool *mbp;
>> struct ether_hdr eth_hdr;
>> + struct ipv4_hdr *ip_hdr;
>> uint16_t nb_tx;
>> uint16_t nb_pkt;
>> uint16_t vlan_tci, vlan_tci_outer;
>> @@ -263,6 +265,14 @@ pkt_burst_transmit(struct fwd_stream *fs)
>> copy_buf_to_pkt(ð_hdr, sizeof(eth_hdr), pkt, 0);
>> copy_buf_to_pkt(&pkt_ip_hdr, sizeof(pkt_ip_hdr), pkt,
>> sizeof(struct ether_hdr));
>> + ip_hdr = rte_pktmbuf_mtod_offset(pkt, struct ipv4_hdr *,
>> + sizeof(struct ether_hdr));
>> + /*
>> + * Generate multiple flows by varying IP dest addr.
>> + */
>> + ip_hdr->dst_addr =
>> + rte_cpu_to_be_32(IP_DST_ADDR | (ip_var++ << 8) |
>> + (rte_lcore_id() + 1));
> Just curious if we can avoid call rte_lcore_id for every packet?
rte_lcore_id() is just to read a per-lcore variable and it is an inline
function, not a real branch. I don't think it has any performance hit.
Actually, I'm using txonly with this patch as a good packet generator to
test development tasks. Mellanox ConnectX-5 can generate 100Gbps @ 64B
(149Mpps) with multiple IP flows.
> And suggest to add more explanation here, like purpose, scenario. So when we want to change the behavior, for example, like adding a parameter to make IP addresses configurable, we know what we will break.
Okay, will add more comment here.
Thanks,
Yongseok
next prev parent reply other threads:[~2018-01-17 18:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-15 21:11 Yongseok Koh
2018-01-12 18:08 ` Thomas Monjalon
2018-01-16 2:40 ` Lu, Wenzhuo
2018-01-17 18:04 ` Yongseok Koh [this message]
2018-01-17 18:18 ` [dpdk-dev] [PATCH v2] " Yongseok Koh
2018-01-18 1:22 ` Lu, Wenzhuo
2018-01-18 12:21 ` Ananyev, Konstantin
2018-01-19 7:09 ` Yongseok Koh
2018-01-19 11:02 ` Ananyev, Konstantin
2018-01-18 13:55 ` Jerin Jacob
2019-03-28 1:51 ` [dpdk-dev] [PATCH v3] " Yongseok Koh
2019-03-28 1:51 ` Yongseok Koh
2019-03-28 10:24 ` Iremonger, Bernard
2019-03-28 10:24 ` Iremonger, Bernard
2019-03-28 17:33 ` Yongseok Koh
2019-03-28 17:33 ` Yongseok Koh
2019-03-28 17:42 ` Iremonger, Bernard
2019-03-28 17:42 ` Iremonger, Bernard
2019-03-28 18:46 ` [dpdk-dev] [PATCH v4] " Yongseok Koh
2019-03-28 18:46 ` Yongseok Koh
2019-03-29 9:55 ` Iremonger, Bernard
2019-03-29 9:55 ` Iremonger, Bernard
2019-03-29 18:44 ` Ferruh Yigit
2019-03-29 18:44 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=755704D8-192C-43E6-9EC5-BCB7FA4591C3@mellanox.com \
--to=yskoh@mellanox.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).