From: "Wiles, Keith" <keith.wiles@intel.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/2] test/test: introduce new test-case for rte_smp_mb()
Date: Sat, 13 Jan 2018 13:54:16 +0000 [thread overview]
Message-ID: <26167454-CC6E-44DF-9469-B7C24389BA65@intel.com> (raw)
In-Reply-To: <1513611253-8785-2-git-send-email-konstantin.ananyev@intel.com>
> On Dec 18, 2017, at 9:34 AM, Konstantin Ananyev <konstantin.ananyev@intel.com> wrote:
>
> Simple functional test for rte_smp_mb() implementations.
> Also when executed on a single lcore could be used as rough
> estimation how many cycles particular implementation of rte_smp_mb()
> might take.
>
> Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> ---
> test/test/Makefile | 1 +
> test/test/test_mb.c | 315 ++++++++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 316 insertions(+)
> create mode 100644 test/test/test_mb.c
>
> diff --git a/test/test/Makefile b/test/test/Makefile
> index bb54c9808..3134283a8 100644
> --- a/test/test/Makefile
> +++ b/test/test/Makefile
> @@ -95,6 +95,7 @@ SRCS-y += test_spinlock.c
> SRCS-y += test_memory.c
> SRCS-y += test_memzone.c
> SRCS-y += test_bitmap.c
> +SRCS-y += test_mb.c
>
> SRCS-y += test_ring.c
> SRCS-y += test_ring_perf.c
> diff --git a/test/test/test_mb.c b/test/test/test_mb.c
> new file mode 100644
> index 000000000..52c73fb6b
> --- /dev/null
> +++ b/test/test/test_mb.c
> @@ -0,0 +1,315 @@
> +/*-
> + * BSD LICENSE
> + *
> + * Copyright(c) 2010-2017 Intel Corporation. All rights reserved.
> + * All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * * Redistributions of source code must retain the above copyright
> + * notice, this list of conditions and the following disclaimer.
> + * * Redistributions in binary form must reproduce the above copyright
> + * notice, this list of conditions and the following disclaimer in
> + * the documentation and/or other materials provided with the
> + * distribution.
> + * * Neither the name of Intel Corporation nor the names of its
> + * contributors may be used to endorse or promote products derived
> + * from this software without specific prior written permission.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
> + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
> + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
> + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
> + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
SPDX header should be used, correct?
> +
> + /*
> + * This is a simple functional test for rte_smp_mb() implementation.
> + * I.E. make sure that LOAD and STORE operations that precede the
> + * rte_smp_mb() call are globally visible across the lcores
> + * before the the LOAD and STORE operations that follows it.
> + * The test uses simple implementation of Peterson's lock algorithm
> + * (https://en.wikipedia.org/wiki/Peterson%27s_algorithm)
> + * for two execution units to make sure that rte_smp_mb() prevents
> + * store-load reordering to happen.
> + * Also when executed on a single lcore could be used as a approxiamate
> + * estimation of number of cycles particular implementation of rte_smp_mb()
> + * will take.
> + */
> +
>
Regards,
Keith
next prev parent reply other threads:[~2018-01-13 13:54 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 11:12 [dpdk-dev] [PATCH " Konstantin Ananyev
2017-12-01 11:12 ` [dpdk-dev] [PATCH 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb() Konstantin Ananyev
2017-12-01 18:04 ` Stephen Hemminger
2017-12-01 23:08 ` Ananyev, Konstantin
2018-03-08 21:15 ` Stephen Hemminger
2017-12-11 17:11 ` Bruce Richardson
2017-12-11 17:30 ` Ananyev, Konstantin
2017-12-18 15:34 ` [dpdk-dev] [PATCH v2 0/2] eal/x86: Optimize rte_smp_mb() and create a new test case for it Konstantin Ananyev
2017-12-18 15:34 ` [dpdk-dev] [PATCH v2 1/2] test/test: introduce new test-case for rte_smp_mb() Konstantin Ananyev
2018-01-12 17:23 ` Thomas Monjalon
2018-01-12 17:58 ` Ananyev, Konstantin
2018-01-13 13:54 ` Wiles, Keith
2018-01-13 13:54 ` Wiles, Keith [this message]
2018-01-15 15:04 ` [dpdk-dev] [PATCH v3 0/2] eal/x86: Optimize rte_smp_mb() and create a new test case for it Konstantin Ananyev
2018-01-15 15:04 ` [dpdk-dev] [PATCH v3 1/2] test/test: introduce new test-case for rte_smp_mb() Konstantin Ananyev
2018-01-16 0:16 ` Thomas Monjalon
2018-01-15 15:04 ` [dpdk-dev] [PATCH v3 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb() Konstantin Ananyev
2018-01-15 15:09 ` Konstantin Ananyev
[not found] ` <8b05f533-d146-7f97-48f4-82ddcfc3613b@redhat.com>
2018-01-16 1:54 ` [dpdk-dev] Fwd: " Michael S. Tsirkin
2018-01-29 9:29 ` Ananyev, Konstantin
2018-01-29 17:29 ` Michael S. Tsirkin
2018-01-29 15:47 ` [dpdk-dev] " Thomas Monjalon
2018-01-30 19:33 ` Stephen Hemminger
2017-12-18 15:34 ` [dpdk-dev] [PATCH v2 " Konstantin Ananyev
2017-12-18 15:46 ` Bruce Richardson
2017-12-11 17:08 ` [dpdk-dev] [PATCH 1/2] test/test: introduce new test-case for rte_smp_mb() Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26167454-CC6E-44DF-9469-B7C24389BA65@intel.com \
--to=keith.wiles@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).