From: "Wiles, Keith" <keith.wiles@intel.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: "Hunt, David" <david.hunt@intel.com>,
Olivier MATZ <olivier.matz@6wind.com>, DPDK <dev@dpdk.org>,
Thomas Monjalon <thomas.monjalon@6wind.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack mempool handler as driver
Date: Tue, 21 Mar 2017 14:45:13 +0000 [thread overview]
Message-ID: <3328419E-C4DF-464B-AF4F-F73D7CC0179C@intel.com> (raw)
In-Reply-To: <43b90881-7fc7-8f75-f040-2ad8ea922333@nxp.com>
> On Mar 21, 2017, at 1:25 AM, Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
>
> Hello Keith,
>
> On Tuesday 21 March 2017 11:32 AM, Wiles, Keith wrote:
>>
>>> On Mar 20, 2017, at 11:55 PM, Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
>>>
>>> Hello David,
>>>
>>> On Monday 20 March 2017 08:20 PM, Hunt, David wrote:
>>>>
>>>> On 20/3/2017 10:03 AM, Shreyansh Jain wrote:
>>>>> CONFIG_RTE_DRIVER_MEMPOOL_STACK option added to common_base.
>>>>> Stack mempool handler moved from lib/librte_mempool into drivers/mempool.
>>>>>
>>>
>>> <...>
>>>
>>>>> -}
>>>>> -
>>>>> -static struct rte_mempool_ops ops_stack = {
>>>>> - .name = "stack",
>>>>> - .alloc = stack_alloc,
>>>>> - .free = stack_free,
>>>>> - .enqueue = stack_enqueue,
>>>>> - .dequeue = stack_dequeue,
>>>>> - .get_count = stack_get_count
>>>>> -};
>>>>> -
>>>>> -MEMPOOL_REGISTER_OPS(ops_stack);
>>>>
>>>> Shreyansh,
>>>> Could I suggest you add the parameter "--find-renames" when
>>>> generating the patch files, as this will reduce the size of the patches
>>>> significantly, making for easier review. The patch line count in this
>>>> particular case would be reduced by approx 75%.
>>>
>>> Thanks for suggestion.
>>> Yes, I forgot to use this option while creating this patch. If there
>>> are comments and v2 needs to be created, I will keep this in mind.
>>>
>>>> Regards,
>>>> Dave.
>>
>> I guess I missed an email, but what is the advantage of moving the ring/stack files to the drivers directory as they are not drivers in the sense of a NIC PMD or any other driver. You can still enable/disable them in the config files right?
>>
>
> Just as reference, following is where this was being discussed:
>
> http://dpdk.org/ml/archives/dev/2017-March/059690.html
> http://dpdk.org/ml/archives/dev/2017-March/059753.html
> and
> http://dpdk.org/ml/archives/dev/2017-March/060501.html
>
> Also, a while back (I can't trace that mailing list exchange), it was
> decided that all mempool drivers (stack, ring, others...) would be
> moved to drivers/mempool.
>
> For NXP's DPAA2 PMD, we use an offloaded mempool for which there was a
> patchset by Hemant [1] which adds that driver to drivers/mempool. In
> the same breadth, ring and stack are also being moved to
> drivers/mempool as independent drivers (non-offloaded category).
>
> [1] http://dpdk.org/ml/archives/dev/2017-March/060476.html
>
> In my opinion, this would make the lib/* area free of handler/drivers
> (almost) and it is a good change. Also, ring and stack use a 'registration' mechanism - just like PMD and are good candidate to be treated as 'drivers' now even though not entirely like a PMD.
>
> You see any downside of this?
OK, I am up to date now. The only downside is splitting the mempool code up and making it a bit harder to manage, but it is a minor point. I do not see any stopper to prevent the change. Thanks.
>
>> Regards,
>> Keith
>>
>>
>
> -
> Shreyansh
Regards,
Keith
next prev parent reply other threads:[~2017-03-21 14:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-20 10:03 Shreyansh Jain
2017-03-20 10:03 ` [dpdk-dev] [PATCH 2/2] drivers/mempool: add ring " Shreyansh Jain
2017-03-20 14:50 ` [dpdk-dev] [PATCH 1/2] drivers/mempool: add stack " Hunt, David
2017-03-21 4:55 ` Shreyansh Jain
2017-03-21 6:02 ` Wiles, Keith
2017-03-21 6:25 ` Shreyansh Jain
2017-03-21 6:28 ` Shreyansh Jain
2017-03-21 14:45 ` Wiles, Keith [this message]
2017-03-24 16:22 ` Olivier Matz
2017-03-27 4:54 ` Shreyansh Jain
2017-03-27 7:22 ` Olivier Matz
2017-03-28 11:42 ` Shreyansh Jain
2017-03-29 8:18 ` Olivier Matz
2017-03-29 12:55 ` Shreyansh Jain
2017-03-30 12:35 ` Olivier Matz
2017-03-31 5:29 ` [dpdk-dev] [PATCH 1/3] mempool: fix segfault for unlinked mempool handler Shreyansh Jain
2017-03-31 5:29 ` [dpdk-dev] [PATCH 2/3] mempool: introduce ring mempool driver Shreyansh Jain
2017-03-31 5:29 ` [dpdk-dev] [PATCH 3/3] mempool: introduce stack " Shreyansh Jain
2017-03-31 5:31 ` [dpdk-dev] [PATCH 1/3] mempool: fix segfault for unlinked mempool handler Shreyansh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3328419E-C4DF-464B-AF4F-F73D7CC0179C@intel.com \
--to=keith.wiles@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=olivier.matz@6wind.com \
--cc=shreyansh.jain@nxp.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).