From: Thomas Monjalon <thomas@monjalon.net>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, david.marchand@redhat.com, jerinjacobk@gmail.com,
mb@smartsharesystems.com
Subject: Re: [PATCH v7 3/5] eal: set thread name on Windows worker threads
Date: Tue, 24 Jan 2023 16:25:34 +0100 [thread overview]
Message-ID: <3854099.WbyNdk4fJJ@thomas> (raw)
In-Reply-To: <1674502774-20253-4-git-send-email-roretzla@linux.microsoft.com>
23/01/2023 20:39, Tyler Retzlaff:
> Bring Windows EAL worker thread initialization in line with linux &
> freebsd by setting the worker thread name using the new
> platform agnostic rte_thread_set_name API.
>
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
>
> ---
> lib/eal/windows/eal.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c
> index b9f95ed..e561f87 100644
> --- a/lib/eal/windows/eal.c
> +++ b/lib/eal/windows/eal.c
> @@ -282,6 +282,7 @@ enum rte_proc_type_t
> enum rte_iova_mode iova_mode;
> int ret;
> char cpuset[RTE_CPU_AFFINITY_STR_LEN];
> + char thread_name[RTE_MAX_THREAD_NAME_LEN];
>
> eal_log_init(NULL, 0);
>
> @@ -437,6 +438,12 @@ enum rte_proc_type_t
> if (rte_thread_create(&lcore_config[i].thread_id, NULL,
> eal_thread_loop, (void *)(uintptr_t)i) != 0)
> rte_panic("Cannot create thread\n");
> +
> + /* Set thread_name for aid in debugging. */
No need of underscore in "thread name".
> + snprintf(thread_name, sizeof(thread_name),
> + "rte-worker-%d", i);
> + rte_thread_set_name(lcore_config[i].thread_id, thread_name);
Thanks for making implementations more uniform.
next prev parent reply other threads:[~2023-01-24 15:25 UTC|newest]
Thread overview: 91+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 19:00 [PATCH 0/5] add lcore set name and get name API Tyler Retzlaff
2022-12-07 19:00 ` [PATCH 1/5] eal: " Tyler Retzlaff
2022-12-07 21:03 ` Stephen Hemminger
2022-12-07 22:33 ` Tyler Retzlaff
2022-12-08 4:07 ` Stephen Hemminger
2022-12-08 17:11 ` Tyler Retzlaff
2022-12-07 19:00 ` [PATCH 2/5] eal: set lcore config thread for lcore main Tyler Retzlaff
2022-12-07 19:00 ` [PATCH 3/5] test: add a unit test for set and get lcore name APIs Tyler Retzlaff
2022-12-07 19:00 ` [PATCH 4/5] eal: remove thread getname API Tyler Retzlaff
2022-12-07 19:00 ` [PATCH 5/5] eal: deprecate rte thread setname API Tyler Retzlaff
2022-12-14 16:47 ` [PATCH v2 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2022-12-14 16:47 ` [PATCH v2 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-11 16:09 ` David Marchand
2023-01-12 21:32 ` Tyler Retzlaff
2023-01-13 4:36 ` Jerin Jacob
2023-01-13 17:09 ` Tyler Retzlaff
2023-01-13 18:56 ` Tyler Retzlaff
2022-12-14 16:47 ` [PATCH v2 2/4] eal: remove thread getname API Tyler Retzlaff
2022-12-14 16:47 ` [PATCH v2 3/4] eal: deprecate rte thread setname API Tyler Retzlaff
2022-12-14 16:47 ` [PATCH v2 4/4] drivers: mlx5 use rte thread set name Tyler Retzlaff
2022-12-14 16:51 ` Morten Brørup
2023-01-10 20:53 ` [PATCH v2 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-11 7:55 ` Morten Brørup
2023-01-12 21:55 ` [PATCH v3 " Tyler Retzlaff
2023-01-12 21:55 ` [PATCH v3 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-12 21:55 ` [PATCH v3 2/4] eal: remove thread getname API Tyler Retzlaff
2023-01-12 21:55 ` [PATCH v3 3/4] drivers: mlx5 use rte thread set name Tyler Retzlaff
2023-01-12 21:55 ` [PATCH v3 4/4] eal: deprecate rte thread setname API Tyler Retzlaff
2023-01-13 18:51 ` [PATCH v4 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-13 18:52 ` [PATCH v4 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-13 18:52 ` [PATCH v4 2/4] eal: remove thread getname API Tyler Retzlaff
2023-01-17 7:49 ` Jerin Jacob
2023-01-17 18:22 ` Tyler Retzlaff
2023-01-13 18:52 ` [PATCH v4 3/4] drivers: mlx5 use rte thread set name Tyler Retzlaff
2023-01-13 18:52 ` [PATCH v4 4/4] eal: deprecate rte thread setname API Tyler Retzlaff
2023-01-17 18:21 ` [PATCH v5 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-17 18:21 ` [PATCH v5 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-18 14:50 ` David Marchand
2023-01-17 18:21 ` [PATCH v5 2/4] eal: remove thread getname API Tyler Retzlaff
2023-01-18 6:28 ` Jerin Jacob
2023-01-18 14:51 ` David Marchand
2023-01-17 18:21 ` [PATCH v5 3/4] drivers: mlx5 use rte thread set name Tyler Retzlaff
2023-01-17 18:21 ` [PATCH v5 4/4] eal: deprecate rte thread setname API Tyler Retzlaff
2023-01-18 11:49 ` David Marchand
2023-01-18 19:54 ` [PATCH v6 0/5] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-18 19:54 ` [PATCH v6 1/5] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-18 23:13 ` Stephen Hemminger
2023-01-18 23:44 ` Tyler Retzlaff
2023-01-18 19:54 ` [PATCH v6 2/5] eal: remove thread getname API Tyler Retzlaff
2023-01-18 19:54 ` [PATCH v6 3/5] eal: set thread name on Windows worker threads Tyler Retzlaff
2023-01-18 19:54 ` [PATCH v6 4/5] drivers: mlx5 use rte thread set name Tyler Retzlaff
2023-01-18 19:54 ` [PATCH v6 5/5] eal: deprecation notice for rte thread setname API Tyler Retzlaff
2023-01-22 13:55 ` [PATCH v6 0/5] add rte_thread_set_name API for rte_thread_t David Marchand
2023-01-23 18:57 ` Tyler Retzlaff
2023-01-23 19:39 ` [PATCH v7 " Tyler Retzlaff
2023-01-23 19:39 ` [PATCH v7 1/5] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-24 15:21 ` Thomas Monjalon
2023-01-23 19:39 ` [PATCH v7 2/5] eal: remove thread getname API Tyler Retzlaff
2023-01-24 15:24 ` Thomas Monjalon
2023-01-24 15:33 ` Tyler Retzlaff
2023-01-23 19:39 ` [PATCH v7 3/5] eal: set thread name on Windows worker threads Tyler Retzlaff
2023-01-24 15:25 ` Thomas Monjalon [this message]
2023-01-24 15:33 ` Tyler Retzlaff
2023-01-24 15:47 ` Thomas Monjalon
2023-01-23 19:39 ` [PATCH v7 4/5] drivers: mlx5 use rte thread set name Tyler Retzlaff
2023-01-24 15:50 ` Thomas Monjalon
2023-01-23 19:39 ` [PATCH v7 5/5] eal: deprecation notice for rte thread setname API Tyler Retzlaff
2023-01-24 16:03 ` Thomas Monjalon
2023-01-24 17:42 ` [PATCH v8 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-24 17:42 ` [PATCH v8 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-24 17:42 ` [PATCH v8 2/4] eal: remove thread getname API Tyler Retzlaff
2023-01-24 17:42 ` [PATCH v8 3/4] eal: set thread name on Windows worker threads Tyler Retzlaff
2023-01-24 17:42 ` [PATCH v8 4/4] eal: deprecation notice for rte thread setname API Tyler Retzlaff
2023-01-24 18:02 ` [PATCH v9 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-24 18:02 ` [PATCH v9 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-24 18:02 ` [PATCH v9 2/4] eal: remove thread getname API Tyler Retzlaff
2023-01-24 18:02 ` [PATCH v9 3/4] eal: set thread name on Windows worker threads Tyler Retzlaff
2023-01-24 18:02 ` [PATCH v9 4/4] eal: deprecation notice for rte thread setname API Tyler Retzlaff
2023-01-24 18:05 ` Thomas Monjalon
2023-01-24 18:21 ` Tyler Retzlaff
2023-01-24 18:12 ` [PATCH v10 0/4] add rte_thread_set_name API for rte_thread_t Tyler Retzlaff
2023-01-24 18:12 ` [PATCH v10 1/4] eal: add thread set name API operating on rte thread Tyler Retzlaff
2023-01-24 18:12 ` [PATCH v10 2/4] eal: remove thread getname API Tyler Retzlaff
2023-01-24 18:12 ` [PATCH v10 3/4] eal: set thread name on Windows worker threads Tyler Retzlaff
2023-01-24 18:12 ` [PATCH v10 4/4] eal: deprecation notice for rte thread setname API Tyler Retzlaff
2023-01-30 15:46 ` Thomas Monjalon
2023-01-30 16:19 ` David Marchand
2023-01-30 20:34 ` Tyler Retzlaff
2023-01-31 9:53 ` David Marchand
2023-01-31 17:09 ` Tyler Retzlaff
2023-01-31 9:54 ` [PATCH v10 0/4] add rte_thread_set_name API for rte_thread_t David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3854099.WbyNdk4fJJ@thomas \
--to=thomas@monjalon.net \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinjacobk@gmail.com \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).