From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "Nicolau, Radu" <radu.nicolau@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"piotrx.t.azarewicz@intel.com" <piotrx.t.azarewicz@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000
Date: Wed, 5 Jul 2017 13:02:19 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831F2A21C0FC@irsmsx110.ger.corp.intel.com> (raw)
In-Reply-To: <1ab6bff3-7f84-ef00-b015-edb92ee73d40@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, June 27, 2017 12:36 PM
> > For 2, does the "use existing methods" include calling xstats? If so,
> > then we can just drop the requirement for 2 to have any new functions
> > implemented in the driver. Instead, have the information provided by
> > drivers in the normal xstats call, but have a new ethdev API to
> > provide that information to the app - basically hiding the xstats
> > complexity underneath.
>
> I was thinking another dev_ops similar to xstats, but re-using xstats can be
> better idea here.
>
> so option 2 becomes:
> [2] An eth_dev API to use existing APIs to get information from PMDs and
> wrap MIBs related xstats calls.
>
Instead of getting information/configuration related mib attributes in xstats_get, we should have new eth_dev op to get all those mib attributes which don’t have any ethdev API.
Then the new eth_dev API can call this new eth_dev op and other existing ethdev APIs to gather all mib information and expose that to user.
Thanks,
Reshma
next prev parent reply other threads:[~2017-07-05 13:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 14:31 [dpdk-dev] [PATCH 0/3] drivers/net: add support for IF-MIB and EtherLike-MIB Michal Jastrzebski
2017-05-22 14:32 ` [dpdk-dev] [PATCH 1/3] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 Michal Jastrzebski
2017-05-22 16:16 ` Pattan, Reshma
2017-05-22 16:34 ` Pattan, Reshma
2017-05-23 5:53 ` Lu, Wenzhuo
2017-06-20 11:38 ` Radu Nicolau
2017-06-26 9:42 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2017-06-27 11:08 ` Ferruh Yigit
2017-06-27 11:21 ` Bruce Richardson
2017-06-27 11:36 ` Ferruh Yigit
2017-07-05 13:02 ` Pattan, Reshma [this message]
2017-06-27 22:26 ` Stephen Hemminger
2017-07-06 11:48 ` Pattan, Reshma
2017-07-19 10:40 ` Ferruh Yigit
2017-05-22 14:32 ` [dpdk-dev] [PATCH 2/3] drivers/net: add support for IF-MIB and EtherLike-MIB for i40e Michal Jastrzebski
2017-05-31 5:29 ` Xing, Beilei
2017-06-26 9:41 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2017-05-22 14:32 ` [dpdk-dev] [PATCH 3/3] drivers/net: add support for IF-MIB and EtherLike-MIB for ixgbe Michal Jastrzebski
2017-06-26 9:39 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2017-06-27 22:27 ` Stephen Hemminger
2017-05-22 16:11 ` [dpdk-dev] [PATCH 0/3] drivers/net: add support for IF-MIB and EtherLike-MIB Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831F2A21C0FC@irsmsx110.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=bruce.richardson@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=harry.van.haaren@intel.com \
--cc=michalx.k.jastrzebski@intel.com \
--cc=piotrx.t.azarewicz@intel.com \
--cc=radu.nicolau@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).