From: "Pattan, Reshma" <reshma.pattan@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7] distributor_app: new sample app
Date: Fri, 14 Nov 2014 08:44:25 +0000 [thread overview]
Message-ID: <3AEA2BF9852C6F48A459DA490692831FE35F2D@IRSMSX109.ger.corp.intel.com> (raw)
In-Reply-To: <2996275.IBF3pFpS8C@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, November 13, 2014 9:30 PM
> To: Pattan, Reshma
> Cc: dev@dpdk.org; De Lara Guarch, Pablo
> Subject: Re: [dpdk-dev] [PATCH v7] distributor_app: new sample app
>
> Hi Reshma,
>
> > > From: Reshma Pattan <reshma.pattan@intel.com>
> > >
> > > A new sample app that shows the usage of the distributor library.
> > > This app works as follows:
> > >
> > > * An RX thread runs which pulls packets from each ethernet port in turn
> > > and passes those packets to worker using a distributor component.
> > > * The workers take the packets in turn, and determine the output port
> > > for those packets using basic l2forwarding doing an xor on the source
> > > port id.
> > > * The RX thread takes the returned packets from the workers and enqueue
> > > those packets into an rte_ring structure.
> > > * A TX thread pulls the packets off the rte_ring structure and then
> > > sends each packet out the output port specified previously by the
> > > worker
> > > * Command-line option support provided only for portmask.
> > >
> > > v5 change:
> > > * Handled gracefull shutdown of rx and tx threads upon SIGINT.
> > >
> > > v6 change:
> > > * modified graceful shutdown logic to handle all threads upon SIGINT
> > > * removed call to rte_eal_pci_probe()
> > > * added seperate print_stats function
> > >
> > > v7 change:
> > > * passing NULL as rxconf/txconf parameter for rx/tx queue setup
> > > * removed zero-ed fields from port conf structure
> > > * fixed style related comments
> > >
> > >
> > > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> >
> > Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
>
> Before applying this patch, I have 2 comments:
> - Other examples directories don't have _app suffix.
> - checkpatch reports "switch and case should be at the same indent"
>
> If you agree I will fix these 2 minor issues before applying.
Fine with me. You can proceed.
Thanks,
Reshma
>
> Thanks
> --
> Thomas
next prev parent reply other threads:[~2014-11-14 8:36 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 12:13 [dpdk-dev] [PATCH 0/3] distributor_app: new sample application for distributor library reshmapa
2014-09-16 12:13 ` [dpdk-dev] [PATCH 1/3] distributor_app: new sample app reshmapa
2014-09-16 12:13 ` [dpdk-dev] [PATCH 2/3] distributor_app: code review comments implementation reshmapa
2014-09-16 12:13 ` [dpdk-dev] [PATCH 3/3] distributor_app: removed extra spaces reshmapa
2014-09-23 12:55 ` [dpdk-dev] [PATCH 0/3] distributor_app: new sample application for distributor library Bruce Richardson
2014-09-24 14:16 ` [dpdk-dev] [PATCH v2] distributor_app: new sample app reshmapa
2014-09-26 15:11 ` De Lara Guarch, Pablo
2014-09-26 15:51 ` Ananyev, Konstantin
2014-09-29 12:39 ` Pattan, Reshma
2014-09-29 13:06 ` Ananyev, Konstantin
2014-09-29 13:35 ` De Lara Guarch, Pablo
2014-09-29 14:35 ` Neil Horman
2014-09-30 8:02 ` Pattan, Reshma
2014-09-30 9:21 ` Ananyev, Konstantin
2014-09-30 10:39 ` [dpdk-dev] [PATCH v3] " reshmapa
2014-09-30 11:34 ` Neil Horman
2014-09-30 12:18 ` Bruce Richardson
2014-09-30 13:39 ` Neil Horman
2014-10-01 14:47 ` Pattan, Reshma
2014-10-01 14:56 ` Neil Horman
2014-10-01 15:37 ` Bruce Richardson
2014-10-01 16:07 ` Neil Horman
2014-10-06 14:16 ` Pattan, Reshma
2014-10-06 14:44 ` Neil Horman
2014-10-06 17:34 ` Pattan, Reshma
2014-10-06 19:02 ` Neil Horman
2014-10-02 9:04 ` Ananyev, Konstantin
2014-10-01 13:33 ` [dpdk-dev] [PATCH v4] distributor_app: gracefull shutdown of tx/rx threads on SIGINT reshmapa
2014-10-01 13:46 ` Pattan, Reshma
2014-10-01 13:49 ` Thomas Monjalon
2014-10-01 14:33 ` [dpdk-dev] [PATCH v5] distributor_app: new sample app reshmapa
2014-10-17 13:59 ` [dpdk-dev] [PATCH v6] " Reshma Pattan
2014-11-02 20:08 ` De Lara Guarch, Pablo
2014-11-03 15:49 ` [dpdk-dev] [PATCH v7] " Reshma Pattan
2014-11-03 16:03 ` De Lara Guarch, Pablo
2014-11-13 21:30 ` Thomas Monjalon
2014-11-14 8:44 ` Pattan, Reshma [this message]
2014-11-16 21:59 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3AEA2BF9852C6F48A459DA490692831FE35F2D@IRSMSX109.ger.corp.intel.com \
--to=reshma.pattan@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).