From: "Di, ChenxuX" <chenxux.di@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Yang, Qiming" <qiming.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4 1/5] net/e1000: release port upon close
Date: Thu, 26 Sep 2019 03:21:59 +0000 [thread overview]
Message-ID: <3B926E44943CB04AA3A39AC16328CE39B4BABB@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190925154112.GH60476@intel.com>
> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Wednesday, September 25, 2019 11:41 PM
> To: Di, ChenxuX <chenxux.di@intel.com>
> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v4 1/5] net/e1000: release port upon close
>
> On 09/19, Di ChenxuX wrote:
> >Set RTE_ETH_DEV_CLOSE_REMOVE upon probe so all the private resources
> >for the port can be freed by rte_eth_dev_close().
> >
> >Signed-off-by: Di ChenxuX <chenxux.di@intel.com>
> >---
> > doc/guides/rel_notes/release_19_11.rst | 5 +
> > drivers/net/e1000/igb_ethdev.c | 144 ++++++++++++-------------
>
> As I commented before, you also need to do the migration for the em_ethdev.c.
Ok , I will do it in the next version of patch.
>
> > 2 files changed, 77 insertions(+), 72 deletions(-)
> >
> >diff --git a/doc/guides/rel_notes/release_19_11.rst
> >b/doc/guides/rel_notes/release_19_11.rst
> >index 27cfbd9e3..334756906 100644
> >--- a/doc/guides/rel_notes/release_19_11.rst
> >+++ b/doc/guides/rel_notes/release_19_11.rst
> >@@ -56,6 +56,11 @@ New Features
> > Also, make sure to start the actual text at the margin.
> > =========================================================
> >
> >+* **Updated the Intel drivers.**
> >+
> >+ * Added support for the ``RTE_ETH_DEV_CLOSE_REMOVE`` flag for
> >+ e1000, fm10k, i40e, ice, ixgbe.
> >+
>
> I think it makes more scene to separate release notes in respective patches, as
> this patch just update e1000 pmd.
>
OK. I will do it in the next version of patch.
> >
> > Removed Items
> > -------------
> >diff --git a/drivers/net/e1000/igb_ethdev.c
> >b/drivers/net/e1000/igb_ethdev.c index fec2b4289..c610042c3 100644
> >--- a/drivers/net/e1000/igb_ethdev.c
> >+++ b/drivers/net/e1000/igb_ethdev.c
> >@@ -843,6 +843,11 @@ eth_igb_dev_init(struct rte_eth_dev *eth_dev)
> > rte_ether_addr_copy((struct rte_ether_addr *)hw->mac.addr,
> > ð_dev->data->mac_addrs[0]);
> >
>
> [snip]
>
> > static int
> >@@ -1579,14 +1532,13 @@ static void
> > eth_igb_close(struct rte_eth_dev *dev) {
> > struct e1000_hw *hw = E1000_DEV_PRIVATE_TO_HW(dev->data-
> >dev_private);
> >- struct e1000_adapter *adapter =
> >- E1000_DEV_PRIVATE(dev->data->dev_private);
> > struct rte_eth_link link;
> > struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
> > struct rte_intr_handle *intr_handle = &pci_dev->intr_handle;
> >+ struct e1000_filter_info *filter_info =
> >+ E1000_DEV_PRIVATE_TO_FILTER_INFO(dev->data-
> >dev_private);
> >
> > eth_igb_stop(dev);
> >- adapter->stopped = 1;
> >
> > e1000_phy_hw_reset(hw);
> > igb_release_manageability(hw);
> >@@ -1610,6 +1562,40 @@ eth_igb_close(struct rte_eth_dev *dev)
> >
> > memset(&link, 0, sizeof(link));
> > rte_eth_linkstatus_set(dev, &link);
> >+
> >+ dev->dev_ops = NULL;
> >+ dev->rx_pkt_burst = NULL;
> >+ dev->tx_pkt_burst = NULL;
> >+
> >+ /* Reset any pending lock */
> >+ igb_reset_swfw_lock(hw);
> >+
> >+ /* uninitialize PF if max_vfs not zero */
> >+ igb_pf_host_uninit(dev);
> >+
> >+ rte_intr_callback_unregister(intr_handle,
> >+ eth_igb_interrupt_handler, dev);
>
> why rte_intr_disable(intr_handle) is missing here?
>
rte_intr_disable(intr_handle) has been called in eth_igb_stop(dev). So I delete it to prevent the repeat.
> >+
[snip]
> Ditto.
>
> Thanks,
> Xiaolong
>
> > }
> >
> > static void
> >--
> >2.17.1
> >
next prev parent reply other threads:[~2019-09-26 3:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 5:01 [dpdk-dev] [PATCH] drivers/net: " chenxux.di
2019-08-27 6:23 ` Ye Xiaolong
2019-09-05 11:03 ` [dpdk-dev] [PATCH v3 0/5] " Di ChenxuX
2019-09-05 11:03 ` [dpdk-dev] [PATCH v3 1/5] net/e1000: " Di ChenxuX
2019-09-05 11:03 ` [dpdk-dev] [PATCH v3 2/5] net/fm10k: " Di ChenxuX
2019-09-05 11:03 ` [dpdk-dev] [PATCH v3 3/5] net/i40e: " Di ChenxuX
2019-09-05 11:03 ` [dpdk-dev] [PATCH v3 4/5] net/ice: " Di ChenxuX
2019-09-05 11:03 ` [dpdk-dev] [PATCH v3 5/5] net/ixgbe: " Di ChenxuX
2019-09-19 2:47 ` [dpdk-dev] [PATCH v4 0/5] drivers/net: " Di ChenxuX
2019-09-19 2:47 ` [dpdk-dev] [PATCH v4 1/5] net/e1000: " Di ChenxuX
2019-09-25 15:41 ` Ye Xiaolong
2019-09-26 3:21 ` Di, ChenxuX [this message]
2019-09-19 2:47 ` [dpdk-dev] [PATCH v4 2/5] net/fm10k: " Di ChenxuX
2019-09-19 2:47 ` [dpdk-dev] [PATCH v4 3/5] net/i40e: " Di ChenxuX
2019-09-19 2:47 ` [dpdk-dev] [PATCH v4 4/5] net/ice: " Di ChenxuX
2019-09-19 2:47 ` [dpdk-dev] [PATCH v4 5/5] net/ixgbe: " Di ChenxuX
2019-09-23 2:27 ` [dpdk-dev] [PATCH v4 0/5] drivers/net: " Yang, Qiming
2019-09-26 7:30 ` [dpdk-dev] [PATCH v5 " Di ChenxuX
2019-09-26 7:30 ` [dpdk-dev] [PATCH v5 1/5] net/e1000: " Di ChenxuX
2019-09-26 7:30 ` [dpdk-dev] [PATCH v5 2/5] net/fm10k: " Di ChenxuX
2019-09-26 7:30 ` [dpdk-dev] [PATCH v5 3/5] net/i40e: " Di ChenxuX
2019-09-26 7:30 ` [dpdk-dev] [PATCH v5 4/5] net/ice: " Di ChenxuX
2019-09-26 7:30 ` [dpdk-dev] [PATCH v5 5/5] net/ixgbe: " Di ChenxuX
2019-09-26 10:42 ` [dpdk-dev] [PATCH v5 0/5] drivers/net: " Ye Xiaolong
2019-09-26 10:00 ` [dpdk-dev] [PATCH v6 " Di ChenxuX
2019-09-26 10:00 ` [dpdk-dev] [PATCH v6 1/5] net/e1000: " Di ChenxuX
2019-09-26 10:00 ` [dpdk-dev] [PATCH v6 2/5] net/fm10k: " Di ChenxuX
2019-09-26 10:00 ` [dpdk-dev] [PATCH v6 3/5] net/i40e: " Di ChenxuX
2019-09-26 10:00 ` [dpdk-dev] [PATCH v6 4/5] net/ice: " Di ChenxuX
2019-09-26 10:00 ` [dpdk-dev] [PATCH v6 5/5] net/ixgbe: " Di ChenxuX
2019-09-27 2:46 ` [dpdk-dev] [PATCH v6 0/5] drivers/net: " Yang, Qiming
2019-09-27 9:09 ` [dpdk-dev] [PATCH v7 " Di ChenxuX
2019-09-27 9:09 ` [dpdk-dev] [PATCH v7 1/5] net/e1000: " Di ChenxuX
2019-09-27 9:09 ` [dpdk-dev] [PATCH v7 2/5] net/fm10k: " Di ChenxuX
2019-09-27 9:09 ` [dpdk-dev] [PATCH v7 3/5] net/i40e: " Di ChenxuX
2019-09-27 9:09 ` [dpdk-dev] [PATCH v7 4/5] net/ice: " Di ChenxuX
2019-09-27 9:09 ` [dpdk-dev] [PATCH v7 5/5] net/ixgbe: " Di ChenxuX
2019-09-27 10:50 ` [dpdk-dev] [PATCH v7 0/5] drivers/net: " Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3B926E44943CB04AA3A39AC16328CE39B4BABB@SHSMSX101.ccr.corp.intel.com \
--to=chenxux.di@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).