From: "Mokhtar, Amr" <amr.mokhtar@intel.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 6/6] bbdev: auxiliary changes to DPDK framework
Date: Mon, 16 Oct 2017 09:00:22 +0000 [thread overview]
Message-ID: <3D3765A8CDB52A4C8B410430AA19CB236EC41037@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <dcb14ca4-e35e-292a-3dda-aa58db35f45f@intel.com>
My initial thought was that the whole patchset is applied as a whole at once to dpdk.
Will get the source files submitted with belonging Makefiles to get it incrementally compilable.
Thanks Anatoly for catching this.
> -----Original Message-----
> From: Burakov, Anatoly
> Sent: Wednesday 4 October 2017 17:14
> To: Mokhtar, Amr <amr.mokhtar@intel.com>; dev@dpdk.org
> Cc: Power, Niall <niall.power@intel.com>; Macnamara, Chris
> <chris.macnamara@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v1 6/6] bbdev: auxiliary changes to DPDK
> framework
>
> On 30-Sep-17 2:37 AM, Amr Mokhtar wrote:
> > diff --git a/mk/rte.app.mk b/mk/rte.app.mk index c25fdd9..7286ad9
> > 100644
> > --- a/mk/rte.app.mk
> > +++ b/mk/rte.app.mk
> > @@ -93,6 +93,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_NET) += -lrte_net
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_ETHER) += -lrte_ethdev
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += -lrte_cryptodev
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += -lrte_eventdev
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_BBDEV) += -lrte_bbdev
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_MEMPOOL) += -lrte_mempool
> > _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING) += -lrte_mempool_ring
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_RING) += -lrte_ring
> > @@ -146,6 +147,18 @@ endif # $(CONFIG_RTE_LIBRTE_VHOST)
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += -
> lrte_pmd_vmxnet3_uio
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lrte_pmd_xenvirt -
> lxenstore
> >
> > +ifeq ($(CONFIG_RTE_LIBRTE_BBDEV),y)
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_NULL) += -
> lrte_pmd_bbdev_null
> > +
> > +# TURBO SOFTWARE PMD is dependent on the BBLIB library
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) +=
> > +-lrte_pmd_bbdev_turbo_sw
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) +=
> > +-L$(BBLIB_PATH)/lib_common -lcommon
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) +=
> > +-L$(BBLIB_PATH)/lib_crc -lcrc
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) +=
> > +-L$(BBLIB_PATH)/lib_turbo -lturbo
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) +=
> > +-L$(BBLIB_PATH)/lib_rate_matching -lrate_matching
> > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW) += -lirc -limf
> > +-lstdc++ -lipps endif # CONFIG_RTE_LIBRTE_BBDEV
> > +
> > ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += -lrte_pmd_aesni_mb
> > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += -
> L$(AESNI_MULTI_BUFFER_LIB_PATH) -lIPSec_MB
> >
>
> Changes to makefiles should probably go in with the patches that introduce the
> libraries. As it stands, if something breaks the build inside one of the PMD's or
> BBDEV itself (which is the case right now), we won't know about it until this
> patch.
>
> --
> Thanks,
> Anatoly
next prev parent reply other threads:[~2017-10-16 9:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-30 1:37 [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library Amr Mokhtar
2017-09-30 1:37 ` [dpdk-dev] [PATCH v1 2/6] bbdev: PMD drivers (null/turbo_sw) Amr Mokhtar
2017-09-30 1:37 ` [dpdk-dev] [PATCH v1 3/6] bbdev: test applications Amr Mokhtar
2017-09-30 1:37 ` [dpdk-dev] [PATCH v1 4/6] bbdev: sample app Amr Mokhtar
2017-09-30 1:37 ` [dpdk-dev] [PATCH v1 5/6] bbdev: documentation Amr Mokhtar
2017-09-30 1:37 ` [dpdk-dev] [PATCH v1 6/6] bbdev: auxiliary changes to DPDK framework Amr Mokhtar
2017-10-04 16:14 ` Burakov, Anatoly
2017-10-16 9:00 ` Mokhtar, Amr [this message]
2017-10-16 10:03 ` [dpdk-dev] [PATCH v1 1/6] bbdev: librte_bbdev library De Lara Guarch, Pablo
2017-10-18 2:25 ` Mokhtar, Amr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D3765A8CDB52A4C8B410430AA19CB236EC41037@IRSMSX101.ger.corp.intel.com \
--to=amr.mokhtar@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).