From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: "Dewar, Alan" <ad759e@intl.att.com>,
"'alangordondewar@gmail.com'" <alangordondewar@gmail.com>
Cc: "'dev@dpdk.org'" <dev@dpdk.org>, 'Alan Dewar' <alan.dewar@att.com>
Subject: Re: [dpdk-dev] [PATCH v4] sched: make RED scaling configurable
Date: Wed, 3 Jan 2018 16:20:39 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BAF86FB@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <3F9268EEC0E43747A5FFFC6B48EF0321FBE645@gbcdcmbx03.intl.att.com>
> > > +int
> > > +rte_red_set_scaling(uint16_t max_red_queue_length);
> > > +
> > > +/**
> > > + * @brief Reset the RED scaling factor - only for use by RED
> > > +unit-tests
> > > + *
> > > + * @return Operation status
> > > + */
> > > +void
> > > +rte_red_reset_scaling(void);
> >
> > As stated above, this function is probably not useful and my vote is to
> remove it.
> >
>
> It is needed by the revised unit-test program. This function can't be moved
> into the unit-test program because it needs to reset variables that are
> statically declared within rte_red.c
>
>
Hi Alan,
We only put API that makes sense for a real app, not for unit test.
About unit tests: Each test in the unit test suite should start from scratch, i.e. create a RED object from scratch, configure it, use it, free it rather than use RED objects created by previous tests. We need to avoid the latter approach, as it is creating fake dependencies between tests that alter the overall test results. Each test should be independent, and not rely on previous tests. Makes sense?
Regards,
Cristian
next prev parent reply other threads:[~2018-01-03 16:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 13:41 [dpdk-dev] [PATCH] " alangordondewar
2017-09-11 15:51 ` Kantecki, Tomasz
2017-09-13 10:15 ` [dpdk-dev] [PATCH v2] " alangordondewar
2017-09-18 22:03 ` Kantecki, Tomasz
2017-09-20 13:12 ` [dpdk-dev] [PATCH v3] " alangordondewar
2017-09-25 10:36 ` Dumitrescu, Cristian
2017-09-26 8:02 ` Dewar, Alan
2017-10-03 9:21 ` [dpdk-dev] [PATCH v4] " alangordondewar
2017-10-03 17:15 ` Dumitrescu, Cristian
2018-01-02 16:21 ` Dumitrescu, Cristian
2018-01-02 16:43 ` Dumitrescu, Cristian
2018-01-03 14:29 ` Dewar, Alan
2018-01-03 16:20 ` Dumitrescu, Cristian [this message]
2018-01-04 13:34 ` Dewar, Alan
2018-01-04 18:25 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D891267BAF86FB@IRSMSX108.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=ad759e@intl.att.com \
--cc=alan.dewar@att.com \
--cc=alangordondewar@gmail.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).