From: "Kantecki, Tomasz" <tomasz.kantecki@intel.com>
To: "alangordondewar@gmail.com" <alangordondewar@gmail.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Alan Dewar <alan.dewar@att.com>,
"Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] sched: make RED scaling configurable
Date: Mon, 18 Sep 2017 22:03:33 +0000 [thread overview]
Message-ID: <E79CF84CF47B0B42B66F4F5835125F9CAAAEB155@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <1505297744-15240-1-git-send-email-alan.dewar@att.com>
> -----Original Message-----
> From: alangordondewar@gmail.com [mailto:alangordondewar@gmail.com]
> Sent: Wednesday, September 13, 2017 11:16 AM
> To: Kantecki, Tomasz <tomasz.kantecki@intel.com>
> Cc: dev@dpdk.org; Alan Dewar <alan.dewar@att.com>
> Subject: [PATCH v2] sched: make RED scaling configurable
>
> From: Alan Dewar <alan.dewar@att.com>
>
> The RED code stores the maximum threshold is a 32-bit integer as a
> pseudo fixed-point floating number with 10 fractional bits. Twelve
> other bits are used to encode the filter weight, leaving just 10 bits
> for the queue length. This limits the maximum queue length supported
> by RED queues as 1024 packets.
>
> Move the "hard" definitions from red.h into config/common_base so that
> RED scaling can be configured during build.
>
> Modified the RED unit-tests to use the new "soft" definition of
> maximum-threshold from config/common_base in tests where it previously
> used a hard coded limit of 1023.
>
> The RED unit-tests all successfully pass when the maximum-threshold is
> configured as 8191 and the RED scaling factor is dropped to seven.
>
> Real-world testing has involved RED queue lengths of 8192 with multiple
> different settings of the RED config parameters: min_th, max_th, wq_log2
> and maxp_inv.
>
> Signed-off-by: Alan Dewar <alan.dewar@att.com>
> ---
Thanks! The patch looks good to me.
The only thing that potentially could be added is a brief description of the parameters in the common_base file.
Acked-by: Tomasz Kantecki <tomasz.kantecki@intel.com>
--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263
This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.
next prev parent reply other threads:[~2017-09-18 22:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-01 13:41 [dpdk-dev] [PATCH] " alangordondewar
2017-09-11 15:51 ` Kantecki, Tomasz
2017-09-13 10:15 ` [dpdk-dev] [PATCH v2] " alangordondewar
2017-09-18 22:03 ` Kantecki, Tomasz [this message]
2017-09-20 13:12 ` [dpdk-dev] [PATCH v3] " alangordondewar
2017-09-25 10:36 ` Dumitrescu, Cristian
2017-09-26 8:02 ` Dewar, Alan
2017-10-03 9:21 ` [dpdk-dev] [PATCH v4] " alangordondewar
2017-10-03 17:15 ` Dumitrescu, Cristian
2018-01-02 16:21 ` Dumitrescu, Cristian
2018-01-02 16:43 ` Dumitrescu, Cristian
2018-01-03 14:29 ` Dewar, Alan
2018-01-03 16:20 ` Dumitrescu, Cristian
2018-01-04 13:34 ` Dewar, Alan
2018-01-04 18:25 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E79CF84CF47B0B42B66F4F5835125F9CAAAEB155@IRSMSX101.ger.corp.intel.com \
--to=tomasz.kantecki@intel.com \
--cc=alan.dewar@att.com \
--cc=alangordondewar@gmail.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).