DPDK patches and discussions
 help / color / mirror / Atom feed

From: "Chen, Jing D" <jing.d.chen@intel.com>
To: Chenghu Yao <yao.chenghu@zte.com.cn>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/fm10k/base: add a break statement
Date: Thu, 22 Dec 2016 05:22:22 +0000	[thread overview]
Message-ID: <4341B239C0EFF9468EE453F9E9F4604D3C5C6866@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1482289505-47591-1-git-send-email-yao.chenghu@zte.com.cn>

Hi, Chenghu,


> -----Original Message-----
> From: Chenghu Yao [mailto:yao.chenghu@zte.com.cn]
> Sent: Wednesday, December 21, 2016 11:05 AM
> To: Chen, Jing D <jing.d.chen@intel.com>
> Cc: dev@dpdk.org; Chenghu Yao <yao.chenghu@zte.com.cn>
> Subject: [PATCH] net/fm10k/base: add a break statement
> 
> In function fm10k_mbx_create_reply(), the last case branch
> has no break statement.
> 
> Signed-off-by: Chenghu Yao <yao.chenghu@zte.com.cn>
> ---
>  drivers/net/fm10k/base/fm10k_mbx.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/fm10k/base/fm10k_mbx.c
> b/drivers/net/fm10k/base/fm10k_mbx.c
> index 2e70434..45d6ddb 100644
> --- a/drivers/net/fm10k/base/fm10k_mbx.c
> +++ b/drivers/net/fm10k/base/fm10k_mbx.c
> @@ -1084,6 +1084,7 @@ STATIC s32 fm10k_mbx_create_reply(struct fm10k_hw
> *hw,
>  	case FM10K_STATE_CLOSED:
>  		/* generate new header based on data */
>  		fm10k_mbx_create_disconnect_hdr(mbx);
> +		break;
>  	default:
>  		break;
>  	}

Thanks for contributing code. But there are 2 problems here.

1. You are modifying base code under 'base' directory. It assumed READ ONLY because
    there is another Intel team are maintaining it.
2. Without your change, the code won't have any negative effect. Yes, I appreciate your
    change to make it stronger.

So, I'd to say 'NAC' for this patch.

next prev parent reply	other threads:[~2016-12-22  5:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21  3:05 Chenghu Yao
2016-12-22  5:22 ` Chen, Jing D [this message]
2016-12-22  6:01   ` [dpdk-dev] 答复: " yao.chenghu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4341B239C0EFF9468EE453F9E9F4604D3C5C6866@shsmsx102.ccr.corp.intel.com \
    --to=jing.d.chen@intel.com \
    --cc=dev@dpdk.org \
    --cc=yao.chenghu@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).