From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: keith.wiles@intel.com, stable@dpdk.org
Subject: [dpdk-stable] [PATCH v2] malloc: fix duplicate mem event notification
Date: Tue, 11 Dec 2018 16:48:28 +0000 [thread overview]
Message-ID: <4934d38eb70f2951f9212bd4d7e35ceb9d982321.1544546857.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <a3807707cec73b13b25cdd623440fbcb61f02134.1543501068.git.anatoly.burakov@intel.com>
We already trigger a mem event notification inside the walk function,
no need to do it twice.
Fixes: f32c7c9de961 ("malloc: enable event callbacks for external memory")
Cc: stable@dpdk.org
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
Notes:
v2:
- Fixed code style
lib/librte_eal/common/rte_malloc.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c
index 0da5ad5e8..5f07b981a 100644
--- a/lib/librte_eal/common/rte_malloc.c
+++ b/lib/librte_eal/common/rte_malloc.c
@@ -517,13 +517,8 @@ sync_memory(const char *heap_name, void *va_addr, size_t len, bool attach)
if (wa.result < 0) {
rte_errno = -wa.result;
ret = -1;
- } else {
- /* notify all subscribers that a new memory area was added */
- if (attach)
- eal_memalloc_mem_event_notify(RTE_MEM_EVENT_ALLOC,
- va_addr, len);
+ } else
ret = 0;
- }
unlock:
rte_rwlock_read_unlock(&mcfg->memory_hotplug_lock);
return ret;
--
2.17.1
next prev parent reply other threads:[~2018-12-11 16:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 14:21 [dpdk-stable] [PATCH] " Anatoly Burakov
2018-11-29 14:54 ` [dpdk-stable] [dpdk-dev] " Wiles, Keith
2018-11-29 15:36 ` Burakov, Anatoly
2018-11-29 15:47 ` Wiles, Keith
2018-11-29 17:05 ` Ferruh Yigit
2018-11-29 15:18 ` [dpdk-stable] " Anatoly Burakov
2018-11-29 15:36 ` [dpdk-stable] [dpdk-dev] " Burakov, Anatoly
2018-12-11 16:48 ` Anatoly Burakov [this message]
2018-12-20 14:29 ` [dpdk-stable] [PATCH v2] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4934d38eb70f2951f9212bd4d7e35ceb9d982321.1544546857.git.anatoly.burakov@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).