From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] memalloc: do not leave unmapped holes in EAL virtual memory area
Date: Fri, 1 Jun 2018 12:00:29 +0100 [thread overview]
Message-ID: <4ad00805-bf12-7426-4040-6a44c51226f2@intel.com> (raw)
In-Reply-To: <1527857469-159391-1-git-send-email-dariuszx.stojaczyk@intel.com>
On 01-Jun-18 1:51 PM, Dariusz Stojaczyk wrote:
> EAL reserves a huge area in virtual address space
> to provide virtual address contiguity for e.g.
> future memory extensions (memory hotplug). During
> memory hotplug, if the hugepage mmap succeeds but
> doesn't suffice EAL's requiriments, the EAL would
> unmap this mapping straight away, leaving a hole in
> its virtual memory area and making it available
> to everyone. As EAL still thinks it owns the entire
> region, it may try to mmap it later with MAP_FIXED,
> possibly overriding a user's mapping that was made
> in the meantime.
>
> This patch ensures each hole is mapped back by EAL,
> so that it won't be available to anyone else.
>
> Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
> ---
Generally, if the commit is a bugfix, reference to the original commit
that introduces the issue should be part of the commit message. See DPDK
contribution guidelines [1] and "git fixline" [2]. Also, this bug is
present in 18.05, so you should also Cc: stable@dpdk.org (same applies
for all of your other patches for memalloc).
[1] http://dpdk.org/doc/guides/contributing/patches.html
[2] http://dpdk.org/dev
> lib/librte_eal/linuxapp/eal/eal_memalloc.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/lib/librte_eal/linuxapp/eal/eal_memalloc.c b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
> index 8c11f98..b959ea5 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_memalloc.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_memalloc.c
> @@ -39,6 +39,7 @@
> #include "eal_filesystem.h"
> #include "eal_internal_cfg.h"
> #include "eal_memalloc.h"
> +#include "eal_private.h"
>
> /*
> * not all kernel version support fallocate on hugetlbfs, so fall back to
> @@ -490,6 +491,8 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id,
> int ret = 0;
> int fd;
> size_t alloc_sz;
> + int flags;
> + void *new_addr;
>
> /* takes out a read lock on segment or segment list */
> fd = get_seg_fd(path, sizeof(path), hi, list_idx, seg_idx);
> @@ -585,6 +588,20 @@ alloc_seg(struct rte_memseg *ms, void *addr, int socket_id,
>
> mapped:
> munmap(addr, alloc_sz);
> + flags = MAP_FIXED;
> +#ifdef RTE_ARCH_PPC_64
> + flags |= MAP_HUGETLB;
> +#endif
> + new_addr = eal_get_virtual_area(addr, &alloc_sz, alloc_sz, 0, flags);
Page size shouldn't be zero, should be alloc_sz.
> + if (new_addr != addr) {
> + if (new_addr != NULL) {
> + munmap(new_addr, alloc_sz);
> + }
> + /* We're leaving a hole in our virtual address space. If
> + * somebody else maps this hole now, we might accidentally
> + * override it in the future. */
> + rte_panic("can't mmap holes in our virtual address space");
I don't think rte_panic() here makes sense. First of all, we're now
striving to not panic inside DPDK libraries, especially once
initialization has already finished. But more importantly, when you
reach this panic, you're deep in the memory allocation process, which
means you hold a write lock to DPDK memory hotplug. If you crash now,
the lock will never be released and subsequent memory hotplug requests
will just deadlock.
What's worse is you may be inside a secondary process, synchronizing the
memory map with that of a primary, which means that even if you release
the lock here, you're basically releasing someone else's lock, so
behavior will be undefined at that point.
I think an error message with the highest possible log level should
suffice (CRIT?), as there's really nothing more we can do here.
That said, how likely is this scenario?
> + }
> resized:
> if (internal_config.single_file_segments) {
> resize_hugefile(fd, path, list_idx, seg_idx, map_offset,
>
Generally, if the above is fixed, i'm OK with the patch.
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-06-01 11:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 12:51 Dariusz Stojaczyk
2018-06-01 11:00 ` Burakov, Anatoly [this message]
2018-06-01 12:22 ` Stojaczyk, DariuszX
2018-06-01 14:59 ` Burakov, Anatoly
2018-06-01 12:51 ` [dpdk-dev] [PATCH 2/2] memalloc: keep in mind a failed MAP_FIXED mmap may still perform an unmap Dariusz Stojaczyk
2018-06-01 11:08 ` Burakov, Anatoly
2018-06-01 12:41 ` Stojaczyk, DariuszX
2018-06-01 13:37 ` [dpdk-dev] [PATCH 1/2] memalloc: do not leave unmapped holes in EAL virtual memory area Dariusz Stojaczyk
2018-06-01 13:39 ` [dpdk-dev] [PATCH v2 " Dariusz Stojaczyk
2018-06-01 10:24 ` Stojaczyk, DariuszX
2018-06-01 11:14 ` Burakov, Anatoly
2018-06-01 12:59 ` [dpdk-dev] [PATCH v3 " Dariusz Stojaczyk
2018-06-01 12:59 ` [dpdk-dev] [PATCH v3 2/2] memalloc: keep in mind a failed MAP_FIXED mmap may still perform an unmap Dariusz Stojaczyk
2018-06-01 15:07 ` Burakov, Anatoly
2018-06-01 15:06 ` [dpdk-dev] [PATCH v3 1/2] memalloc: do not leave unmapped holes in EAL virtual memory area Burakov, Anatoly
2018-07-12 21:42 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ad00805-bf12-7426-4040-6a44c51226f2@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dariuszx.stojaczyk@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).