From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v7 00/28] remove pci driver from vdevs
Date: Mon, 2 Nov 2015 05:28:50 +0000 [thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E6028621B5A5E8@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1446217733-9887-1-git-send-email-bernard.iremonger@intel.com>
Hi, Bernard
Could we merge some patch together? I see lots of patches are simple and
doing the same thing but in different NIC, merge them almost have no
affect of review, what's more it will make reviewers more comfortable
with less and simple patches.
Then we could have a clean patch set with almost 5 patches, not totally 28.
librte_eal: add RTE_KDRV_NONE for vdevs
librte_ether: add fields from rte_pci_driver to rte_eth_dev_data
drivers: copy pci device info to eth_dev data
librte_ether: remove branches on pci_dev
drivers: remove pci device
At least, we could merge serial patches "xxxx:copy pci device info to
eth_dev data" to "drivers: copy pci device info to eth_dev data" in my mind.
Just an advise, but better to have.
Thanks,
Michael
On 2015/10/30 23:09, Bernard Iremonger wrote:
> There is a dummy pci driver in the vdev PMD's at present.
> This patch set removes the pci driver from the vdev PMD's.
> Changes have been made to librte_ether to handle vdevs and pdevs in the same way.
>
> The following vdev PMD's have had the pci driver removed:
>
> null
> ring
> bonding
> pcap
> af_packet
> xenvirt
> mpipe
>
> All the pdev PMD's have been modified to copy the pci device info into eth_dev data.
>
> Changes in v7:
> rebase to latest code.
>
> Changes in v6:
> Initialise data->drv_name with the PMD driver name in the vdevs.
> Remove two more branches on pci_dev from the bonding vdev.
>
> Changes in v5:
> rebase to latest code.
> refactor patches to avoid potential problems with git bisect.
>
> Changes in v4:
> rebase to latest code.
> add doxygen comments to rte_ethdev.h
> update release notes in patch 0002.
>
> Changes in v3:
> rebase to latest code.
> restructure patches 0002 and 0003 to fix compile issue in patch 0002.
>
> Changes in V2:
> rebase to latest code.
> fix compile error in rte_ethdev.c when debug disabled.
> remove Intel copyright from bnx2x, cxgbe, enic, mlx4, mpipe and null PMD's.
>
> Bernard Iremonger (28):
> librte_eal: add RTE_KDRV_NONE for vdevs
> librte_ether: add fields from rte_pci_driver to rte_eth_dev_data
> librte_ether: add function rte_eth_copy_dev_info
> ixgbe: copy pci device info to eth_dev data
> e1000: copy pci device info to eth_dev data
> i40e: copy pci device info to eth_dev data
> fm10k: copy pci device info to eth_dev data
> bnx2x: copy pci device info to eth_dev data
> cxgbe: copy pci device info to eth_dev data
> enic: copy pci device info to eth_dev data
> mlx4: copy pci device info to eth_dev data
> virtio: copy pci device info to eth_dev data
> vmxnet3: copy pci device info to eth_dev data
> null: copy device info to eth_dev data
> ring: copy device info to eth_dev data
> pcap: copy device info to eth_dev data
> af_packet: copy device info to eth_dev data
> xenvirt: copy device info to eth_dev data
> mpipe: copy device info to eth_dev data
> bonding: copy device info to eth_dev data
> librte_ether: remove branches on pci_dev
> null: remove pci device
> ring: remove pci device
> pcap: remove pci device
> af_packet: remove pci device
> xenvirt: remove pci device
> mpipe: remove pci device
> bonding: remove pci device
>
> doc/guides/rel_notes/release_2_2.rst | 4 ++
> drivers/net/af_packet/rte_eth_af_packet.c | 20 ++++------
> drivers/net/bnx2x/bnx2x_ethdev.c | 3 ++
> drivers/net/bonding/rte_eth_bond_8023ad.c | 4 +-
> drivers/net/bonding/rte_eth_bond_alb.c | 2 +-
> drivers/net/bonding/rte_eth_bond_api.c | 60 +++++++++---------------------
> drivers/net/bonding/rte_eth_bond_pmd.c | 18 ++++-----
> drivers/net/bonding/rte_eth_bond_private.h | 2 +-
> drivers/net/cxgbe/cxgbe_ethdev.c | 3 ++
> drivers/net/e1000/em_ethdev.c | 3 ++
> drivers/net/e1000/igb_ethdev.c | 5 +++
> drivers/net/enic/enic_ethdev.c | 1 +
> drivers/net/fm10k/fm10k_ethdev.c | 2 +
> drivers/net/i40e/i40e_ethdev.c | 3 ++
> drivers/net/i40e/i40e_ethdev_vf.c | 2 +
> drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++
> drivers/net/mlx4/mlx4.c | 3 ++
> drivers/net/mpipe/mpipe_tilegx.c | 10 +++--
> drivers/net/null/rte_eth_null.c | 29 ++++-----------
> drivers/net/pcap/rte_eth_pcap.c | 31 +++++----------
> drivers/net/ring/rte_eth_ring.c | 37 ++++--------------
> drivers/net/virtio/virtio_ethdev.c | 3 ++
> drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +
> drivers/net/xenvirt/rte_eth_xenvirt.c | 18 ++++-----
> lib/librte_eal/common/include/rte_pci.h | 3 +-
> lib/librte_ether/rte_ethdev.c | 54 +++++++++++++++------------
> lib/librte_ether/rte_ethdev.h | 29 +++++++++++++++
> lib/librte_ether/rte_ether_version.map | 7 ++++
> 28 files changed, 185 insertions(+), 177 deletions(-)
>
next prev parent reply other threads:[~2015-11-02 5:30 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PATCH v7>
2015-10-30 15:08 ` Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 01/28] librte_eal: add RTE_KDRV_NONE for vdevs Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 02/28] librte_ether: add fields from rte_pci_driver to rte_eth_dev_data Bernard Iremonger
2015-11-01 21:12 ` Thomas Monjalon
2015-11-02 10:36 ` Iremonger, Bernard
2015-11-02 16:32 ` Thomas Monjalon
2015-11-02 16:44 ` Iremonger, Bernard
2015-11-02 17:42 ` Thomas Monjalon
2015-11-01 21:41 ` Thomas Monjalon
2015-11-02 10:33 ` Iremonger, Bernard
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 03/28] librte_ether: add function rte_eth_copy_dev_info Bernard Iremonger
2015-11-01 21:30 ` Thomas Monjalon
2015-11-02 10:24 ` Iremonger, Bernard
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 04/28] ixgbe: copy pci device info to eth_dev data Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 05/28] e1000: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 06/28] i40e: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 07/28] fm10k: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 08/28] bnx2x: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 09/28] cxgbe: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 10/28] enic: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 11/28] mlx4: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 12/28] virtio: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 13/28] vmxnet3: " Bernard Iremonger
2015-10-31 8:39 ` Yong Wang
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 14/28] null: copy " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 15/28] ring: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 16/28] pcap: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 17/28] af_packet: " Bernard Iremonger
2015-10-30 15:17 ` John W. Linville
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 18/28] xenvirt: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 19/28] mpipe: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 20/28] bonding: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 21/28] librte_ether: remove branches on pci_dev Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 22/28] null: remove pci device Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 23/28] ring: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 24/28] pcap: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 25/28] af_packet: " Bernard Iremonger
2015-10-30 15:19 ` John W. Linville
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 26/28] xenvirt: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 27/28] mpipe: " Bernard Iremonger
2015-10-30 15:08 ` [dpdk-dev] [PATCH v7 28/28] bonding: " Bernard Iremonger
2015-11-01 21:35 ` Thomas Monjalon
2015-11-02 10:27 ` Iremonger, Bernard
2015-10-30 15:21 ` [dpdk-dev] [PATCH v7 00/28] remove pci driver from vdevs Thomas Monjalon
2015-10-30 15:28 ` Iremonger, Bernard
2015-11-02 5:28 ` Qiu, Michael [this message]
2015-11-02 7:35 ` Thomas Monjalon
2015-11-02 10:13 ` Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533710CFB86FA344BFBF2D6802E6028621B5A5E8@SHSMSX101.ccr.corp.intel.com \
--to=michael.qiu@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).