From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH 0/2] net/softnic: add flow classification support
Date: Fri, 8 Dec 2017 09:50:08 +0000 [thread overview]
Message-ID: <54CBAA185211B4429112C315DA58FF6D33296C27@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <65d69e3e-dfee-1c25-23d9-a8265e59e7ea@intel.com>
HI Ferruh,
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, December 7, 2017 9:02 PM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>; dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: Re: [PATCH 0/2] net/softnic: add flow classification support
>
> On 11/30/2017 12:08 PM, Jasvinder Singh wrote:
> > This patchset extends the softnic device by implementing the software
> > fallback for flow classification as defined using Flow APIs. When
> > feature is enabled, softnic classifies and executes actions on the
> > received packets based on flow rules specified using rte_flow.h.
> >
> > The motivation behind this feature is to implement metering and
> > policing function in softnic which requires each flow to be classified
> > at the preceding stage of the packet processing pipeline. Another
> > aspect is to support classification of the greater number of flows
> > (For e.g. 64K) which is not feasible in some hardware due to resource
> > limitation such as memory, etc.
> >
> > This feature, inherently, uses the abstraction provided by dpdk
> > librte_table library to create hash table for classification, and
> > allows users to validate, add and delete flow rules. Current version
> > does not implement all functions and will be completed in the next
> > version.
> >
> > Jasvinder Singh (2):
> > net/softnic: add flow classification support
> > net/softnic: add flow classification ops
>
> Hi Jasvinder,
>
> I was about to ask adding documentation for "software fallback for flow
> classification" but it seems there is no documentation at all for softnic, it
> seems we missed it, and softnic is a complex PMD which requires some
> documentation I believe.
> Can you please add documentation including new flow classification fallback
> info?
>
> And I am getting some build errors [1][2].
>
> Thanks,
> ferruh
>
> [1]
> .../dpdk/drivers/net/softnic/rte_eth_softnic_fc.c:558:3: error: implicit
> conversion from enumeration type 'enum rte_tm_error_type' to different
> enumeration type 'enum rte_flow_error_type' [-Werror,-Wenum-
> conversion]
> RTE_TM_ERROR_TYPE_UNSPECIFIED,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> .../dpdk/drivers/net/softnic/rte_eth_softnic_fc.c:577:3: error: implicit
> conversion from enumeration type 'enum rte_tm_error_type' to different
> enumeration type 'enum rte_flow_error_type' [-Werror,-Wenum-
> conversion]
> RTE_TM_ERROR_TYPE_UNSPECIFIED,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> .../dpdk/drivers/net/softnic/rte_eth_softnic_fc.c:596:3: error: implicit
> conversion from enumeration type 'enum rte_tm_error_type' to different
> enumeration type 'enum rte_flow_error_type' [-Werror,-Wenum-
> conversion]
> RTE_TM_ERROR_TYPE_UNSPECIFIED,
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Copy-paste error :(
will fix this.
> [2]
> .../dpdk/drivers/net/softnic/rte_eth_softnic_fc.c: In function
> ‘pmd_flow_create’:
> .../dpdk/drivers/net/softnic/rte_eth_softnic_fc.c:584:2: error: argument 1
> null where non-null expected [-Werror=nonnull]
> memcpy((void *)f->pattern, (const void *)pattern, sizeof(*f->pattern));
>
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ~~~~~~~~~~~~~
Will fix this.
Regarding documentation, I have to add that in programmer's guide.
Thanks,
Jasvinder
prev parent reply other threads:[~2017-12-08 9:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 20:08 Jasvinder Singh
2017-11-30 20:08 ` [dpdk-dev] [PATCH 1/2] net/softnic: enable flow classification function Jasvinder Singh
2017-12-07 21:02 ` Ferruh Yigit
2017-12-07 22:16 ` Thomas Monjalon
2017-12-08 9:53 ` Singh, Jasvinder
2017-11-30 20:08 ` [dpdk-dev] [PATCH 2/2] net/softnic: add flow classification ops Jasvinder Singh
2017-12-07 21:02 ` [dpdk-dev] [PATCH 0/2] net/softnic: add flow classification support Ferruh Yigit
2017-12-08 9:50 ` Singh, Jasvinder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBAA185211B4429112C315DA58FF6D33296C27@IRSMSX103.ger.corp.intel.com \
--to=jasvinder.singh@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).