DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Singh, Jasvinder" <jasvinder.singh@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v4] librte_pipeline: add support for packet redirection at action handlers
Date: Mon, 7 Mar 2016 11:29:14 +0000	[thread overview]
Message-ID: <54CBAA185211B4429112C315DA58FF6DDD0FD9@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <13895624.4YkCxv7Jex@xps13>

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Monday, March 7, 2016 11:02 AM
> To: Singh, Jasvinder <jasvinder.singh@intel.com>
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4] librte_pipeline: add support for packet
> redirection at action handlers
> 
> Hi Jasvinder,
> 
> Don't hesitate to leave some blank lines in your message, it's free :)

I will avail free service ;) thanks
 
> 2016-03-03 11:01, Jasvinder Singh:
> > Currently, there is no mechanism that allows the pipeline ports
> > (in/out) and table action handlers to override the default forwarding
> > decision (as previously configured per input port or in the table
> > entry). Therefore, new pipeline API functions have been added which
> > allows action handlers to hijack packets and remove them from the
> > pipeline processing, and then either drop them or send them out of the
> > pipeline on any output port. The port
> > (in/out) and table action handler prototypes have been changed for
> > making use of these new API functions. This feature will be helpful to
> > implement functions such as exception handling (e.g. TTL =0), load
> balancing etc.
> > Changes are made to the ports and table action handlers defined in
> > app/test_pipeline and ip_pipeline sample application.
> 
> I have the feeling it would be easier to parse if the structure changes were
> done in a separate commit, then introduce the new function.

I will send v5 as you advice.

> You have forgotten to remove the deprecation notice.

I think, I have updated the deprecation notice for the pipeline input port, output port
and table action handlers prototype. Do you mean anything else than this?


Thanks,
Jasvinder

  reply	other threads:[~2016-03-07 11:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25 14:11 [dpdk-dev] [PATCH 1/2] " Jasvinder Singh
2016-01-25 14:11 ` [dpdk-dev] [PATCH 2/2] modify action handlers in test_pipeline and ip_pipeline Jasvinder Singh
2016-02-29 14:50 ` [dpdk-dev] [PATCH v2 1/2] librte_pipeline: add support for packet redirection at action handlers Jasvinder Singh
2016-02-29 14:50   ` [dpdk-dev] [PATCH v2 2/2] modify action handlers in test_pipeline and ip_pipeline Jasvinder Singh
2016-03-02 20:41   ` [dpdk-dev] [PATCH v3 1/2] librte_pipeline: add support for packet redirection at action handlers Jasvinder Singh
2016-03-02 20:41     ` [dpdk-dev] [PATCH v3 2/2] modify action handlers in test_pipeline and ip_pipeline Jasvinder Singh
2016-03-03  9:35     ` [dpdk-dev] [PATCH v3 1/2] librte_pipeline: add support for packet redirection at action handlers Panu Matilainen
2016-03-03  9:58       ` Singh, Jasvinder
2016-03-03 11:01     ` [dpdk-dev] [PATCH v4] " Jasvinder Singh
2016-03-07 11:01       ` Thomas Monjalon
2016-03-07 11:29         ` Singh, Jasvinder [this message]
2016-03-07 11:38           ` Thomas Monjalon
2016-03-08 18:07       ` [dpdk-dev] [PATCH v5 1/2] " Jasvinder Singh
2016-03-08 18:07         ` [dpdk-dev] [PATCH v5 2/2] librte_pipeline: add new API functions for pipeline " Jasvinder Singh
2016-03-10  0:21           ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CBAA185211B4429112C315DA58FF6DDD0FD9@IRSMSX103.ger.corp.intel.com \
    --to=jasvinder.singh@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).