From: Kevin Traynor <ktraynor@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
"Chautru, Nicolas" <nicolas.chautru@intel.com>,
"Vargas, Hernan" <hernan.vargas@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"gakhil@marvell.com" <gakhil@marvell.com>,
"Rix, Tom" <trix@redhat.com>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
xuemingl@nvidia.com, luca.boccassi@microsoft.com
Subject: Re: [PATCH v1 06/11] test/bbdev: assert failed test for queue configure
Date: Mon, 23 Oct 2023 16:10:13 +0100 [thread overview]
Message-ID: <56551ac9-4ab9-fb93-f925-760c78b599ef@redhat.com> (raw)
In-Reply-To: <8c26747d-28d7-41f7-948f-3f9e1d1315c3@redhat.com>
On 23/10/2023 10:07, Maxime Coquelin wrote:
> With LTS maintainers actually added... sorry.
>
> On 10/23/23 11:05, Maxime Coquelin wrote:
>>
>>
>> On 10/19/23 14:12, Chautru, Nicolas wrote:
>>> Hi Maxime,
>>>
>>>> -----Original Message-----
>>>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>>>> Sent: Thursday, October 19, 2023 10:47 AM
>>>> To: Chautru, Nicolas <nicolas.chautru@intel.com>; Vargas, Hernan
>>>> <hernan.vargas@intel.com>; dev@dpdk.org; gakhil@marvell.com; Rix, Tom
>>>> <trix@redhat.com>
>>>> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>
>>>> Subject: Re: [PATCH v1 06/11] test/bbdev: assert failed test for
>>>> queue configure
>>>>
>>>> Hi Nicolas,
>>>>
>>>> On 10/19/23 10:41, Chautru, Nicolas wrote:
>>>>> Hi Maxime,
>>>>>
>>>>> Do we really want to make these kind of changes on to the stable
>>>>> release, it
>>>> tends to artificially increase the amount of churn on the stable
>>>> release which
>>>> can be counterproductive for such changes which don't add much value
>>>> if any
>>>> to user/developper.
>>>>> Happy to follow your suggestion but a general feedback is lack of
>>>>> appetite for
>>>> very large amount of changes in stable patches which inhibit
>>>> adoption, so
>>>> would expect to put things there that we would genuinely flag as a bug.
>>>>> Kindly share your thoughts.
>>>>
>>>> Checking for configuration failure in a test application is quite
>>>> useful in my
>>>> opinion, as it can help catching regressions, isn't it?
>>>
>>> I don’t personally think this (or for other commit on that serie) hits
>>> that bar for being required in stable release. This ends up being
>>> counterproductive having stable release with a huge amount of commits
>>> that are not really required, and it ends up being a reason for people
>>> not to move to stable release.
>>> But if you are really convinced, ok to follow your reco.
>>
>> Adding LTS maintainers if they want to step in.
>>
>> Personally, I think ot should be backported.
>>
We wrote the policy [0] with exactly this type of discussion in mind :-)
"All patches accepted on the main branch with a Fixes: tag should be
backported to the relevant stable/LTS branches, unless the submitter
indicates otherwise. If there are exceptions, they will be discussed on
the mailing lists."
The idea behind the policy is to try and avoid spending time on
subjective discussions about how bad the bug being fixed should be
before it is backported, and to avoid different LTS maintainers making
different judgements about the same fixes on different branches.
So we try to keep it simple - if it's a bugfix, backport it. If there's
a specific reason not too, fine.
So if it's fixing something, please add the Fixes: tag and we'll take it
from there into the LTS.
thanks,
Kevin.
[0]
http://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be-backported
>> Maxime
>>
>>>>
>>>> Maxime
>>>>> Thanks
>>>>> Nic
>>>>>
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>>>>>> Sent: Tuesday, October 17, 2023 9:43 PM
>>>>>> To: Vargas, Hernan <hernan.vargas@intel.com>; dev@dpdk.org;
>>>>>> gakhil@marvell.com; Rix, Tom <trix@redhat.com>
>>>>>> Cc: Chautru, Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z
>>>>>> <qi.z.zhang@intel.com>
>>>>>> Subject: Re: [PATCH v1 06/11] test/bbdev: assert failed test for
>>>>>> queue configure
>>>>>>
>>>>>>
>>>>>>
>>>>>> On 9/29/23 20:13, Hernan Vargas wrote:
>>>>>>> Stop test if rte_bbdev_queue_configure fails to configure queue.
>>>>>>>
>>>>>>> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
>>>>>>> ---
>>>>>>> app/test-bbdev/test_bbdev.c | 3 ++-
>>>>>>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>>>>>>
>>>>>>> diff --git a/app/test-bbdev/test_bbdev.c
>>>>>>> b/app/test-bbdev/test_bbdev.c index 65805977aead..cf224dca5d04
>>>>>>> 100644
>>>>>>> --- a/app/test-bbdev/test_bbdev.c
>>>>>>> +++ b/app/test-bbdev/test_bbdev.c
>>>>>>> @@ -366,7 +366,8 @@ test_bbdev_configure_stop_queue(void)
>>>>>>> * - queue should be started if deferred_start ==
>>>>>>> */
>>>>>>> ts_params->qconf.deferred_start = 0;
>>>>>>> - rte_bbdev_queue_configure(dev_id, queue_id, &ts_params->qconf);
>>>>>>> + TEST_ASSERT_SUCCESS(rte_bbdev_queue_configure(dev_id, queue_id,
>>>>>> &ts_params->qconf),
>>>>>>> + "Failed test for rte_bbdev_queue_configure");
>>>>>>> rte_bbdev_start(dev_id);
>>>>>>>
>>>>>>> TEST_ASSERT_SUCCESS(return_value =
>>>>>> rte_bbdev_queue_info_get(dev_id,
>>>>>>
>>>>>> If should be a fix IMO.
>>>>>> With fixes tag added and stable cc'ed:
>>>>>>
>>>>>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>>>>>
>>>>>> Thanks,
>>>>>> Maxime
>>>>>
>>>
>
next prev parent reply other threads:[~2023-10-23 15:10 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 18:13 [PATCH v1 00/11] test-bbdev changes for 23.11 Hernan Vargas
2023-09-29 18:13 ` [PATCH v1 01/11] test/bbdev: fix python script subprocess Hernan Vargas
2023-10-17 19:05 ` Maxime Coquelin
2023-09-29 18:13 ` [PATCH v1 02/11] test/bbdev: update python script parameters Hernan Vargas
2023-10-17 19:07 ` Maxime Coquelin
2023-10-19 9:01 ` Chautru, Nicolas
2023-10-19 9:19 ` Maxime Coquelin
2023-10-19 12:09 ` Chautru, Nicolas
2023-10-19 12:20 ` Maxime Coquelin
2023-10-27 20:02 ` Chautru, Nicolas
2023-11-02 17:00 ` Maxime Coquelin
2023-11-02 18:18 ` Chautru, Nicolas
2023-11-03 9:48 ` Maxime Coquelin
2023-09-29 18:13 ` [PATCH v1 03/11] test/bbdev: rename macros from acc200 to vrb Hernan Vargas
2023-10-17 19:30 ` Maxime Coquelin
2023-09-29 18:13 ` [PATCH v1 04/11] test/bbdev: handle exception for LLR generation Hernan Vargas
2023-10-17 19:30 ` Maxime Coquelin
2023-09-29 18:13 ` [PATCH v1 05/11] test/bbdev: improve test log messages Hernan Vargas
2023-10-17 19:40 ` Maxime Coquelin
2023-09-29 18:13 ` [PATCH v1 06/11] test/bbdev: assert failed test for queue configure Hernan Vargas
2023-10-17 19:43 ` Maxime Coquelin
2023-10-19 8:41 ` Chautru, Nicolas
2023-10-19 8:47 ` Maxime Coquelin
2023-10-19 12:12 ` Chautru, Nicolas
2023-10-23 9:05 ` Maxime Coquelin
2023-10-23 9:07 ` Maxime Coquelin
2023-10-23 15:10 ` Kevin Traynor [this message]
2023-09-29 18:13 ` [PATCH v1 07/11] test/bbdev: ldpc encoder concatenation vector Hernan Vargas
2023-10-17 19:44 ` Maxime Coquelin
2023-09-29 18:13 ` [PATCH v1 08/11] test/bbdev: increase max burst size Hernan Vargas
2023-10-17 19:45 ` Maxime Coquelin
2023-09-29 18:13 ` [PATCH v1 09/11] test/bbdev: add MLD support Hernan Vargas
2023-10-17 20:03 ` Maxime Coquelin
2023-09-29 18:13 ` [PATCH v1 10/11] test/bbdev: support new FFT capabilities Hernan Vargas
2023-10-17 20:06 ` Maxime Coquelin
2023-09-29 18:13 ` [PATCH v1 11/11] test/bbdev: support 4 bit LLR compression Hernan Vargas
2023-10-17 20:08 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56551ac9-4ab9-fb93-f925-760c78b599ef@redhat.com \
--to=ktraynor@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=luca.boccassi@microsoft.com \
--cc=maxime.coquelin@redhat.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=trix@redhat.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).