From: Olivier MATZ <olivier.matz@6wind.com>
To: "Simon Kågström" <simon.kagstrom@netinsight.net>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: pass EXTRA_CFLAGS to AUTO_CPUFLAGS to enable local modifications
Date: Fri, 4 Dec 2015 11:15:40 +0100 [thread overview]
Message-ID: <566167CC.3040303@6wind.com> (raw)
In-Reply-To: <56614AE8.2010200@netinsight.net>
Hi Simon,
On 12/04/2015 09:12 AM, Simon Kågström wrote:
> Hi Olivier!
>
> Does this commit look OK now with the changes you proposed?
>
> Thanks,
> // Simon
>
> On 2015-11-24 08:50, Simon Kagstrom wrote:
>> We have encountered a CPU where the AES-NI instruction set is disabled
>> due to export restrictions. Since the build machine and target machine
>> is different, using -native configs doesn't work, and on this CPU, the
>> application refuses to run due to the AES CPU flags being amiss.
>>
>> The patch passes EXTRA_CFLAGS to the figure-out-cpu-flags helper,
>> which allows us to add -mno-aes to the compile flags and resolve this
>> problem.
>>
>> Signed-off-by: Simon Kagstrom <simon.kagstrom@netinsight.net>
>> ---
>> ChangeLog:
>>
>> v2:
>> * Put EXTRA_CFLAGS after MACHINE_CFLAGS to enable overriding values
>>
>> mk/rte.cpuflags.mk | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk
>> index bec7bdd..4b30c6b 100644
>> --- a/mk/rte.cpuflags.mk
>> +++ b/mk/rte.cpuflags.mk
>> @@ -33,7 +33,7 @@
>> # used to set the RTE_CPUFLAG_* environment variables giving details
>> # of what instruction sets the target cpu supports.
>>
>> -AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) -dM -E - < /dev/null)
>> +AUTO_CPUFLAGS := $(shell $(CC) $(MACHINE_CFLAGS) $(EXTRA_CFLAGS) -dM -E - < /dev/null)
>>
>> # adding flags to CPUFLAGS
>>
>>
Acked-by: Olivier Matz <olivier.matz@6wind.com>
next prev parent reply other threads:[~2015-12-04 10:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 7:50 Simon Kagstrom
2015-12-04 8:12 ` Simon Kågström
2015-12-04 10:15 ` Olivier MATZ [this message]
2015-12-04 18:53 ` Thomas Monjalon
2015-12-07 8:33 ` Panu Matilainen
2015-12-07 11:47 ` Simon Kågström
2015-12-07 11:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=566167CC.3040303@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=simon.kagstrom@netinsight.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).