From: Thomas Monjalon <thomas@monjalon.net>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
Cc: wathsala.vithanage@arm.com, jspewock@iol.unh.edu,
probb@iol.unh.edu, Honnappa.Nagarahalli@arm.com,
lijuan.tu@intel.com, bruce.richardson@intel.com, dev@dpdk.org
Subject: Re: [PATCH v1 1/2] dts: fabric requirements
Date: Tue, 11 Apr 2023 16:48:47 +0200 [thread overview]
Message-ID: <5667444.DvuYhMxLoT@thomas> (raw)
In-Reply-To: <CAOb5WZb_bF=qCR3i4q-f2bMjKbg+0kpCwohyepVJv93v9ZRLUA@mail.gmail.com>
04/04/2023 13:51, Juraj Linkeš:
> On Mon, Apr 3, 2023 at 5:18 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> > 03/04/2023 16:56, Juraj Linkeš:
> > > On Mon, Apr 3, 2023 at 2:33 PM Thomas Monjalon <thomas@monjalon.net>
> > wrote:
> > >
> > > > 03/04/2023 13:46, Juraj Linkeš:
> > > > > Replace pexpect with Fabric.
> > > >
> > > > You should squash these lines with the move to Fabric.
> > > >
> > > > > Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
> > > > > ---
> > > > > dts/poetry.lock | 553
> > +++++++++++++++++++++++++++++++++++++++------
> > > >
> > > > Do we really need *all* these lines?
> > > > I see a lot of lines about Windows and MacOSX which are not supported
> > in
> > > > DTS.
> > > > It is so long that it looks impossible to review.
> > > >
> > > >
> > > This is a generated file and doesn't need to be reviewed.
> >
> > In general, I don't like storing generated files.
> >
>
> Me neither, but this one is specifically designed to be stored in a
> repository:
> https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control
>
>
> >
> > > I separated the
> > > dependencies part so that the code part is easier to review. If you
> > want, I
> > > can squash the two commits.
> >
> > What happens if we manually remove the useless lines?
> >
> >
> The lock file is there so that everyone installs exactly the same versions
> of dependencies. We can specify the versions of dependencies in
> pyproject.toml, but we won't control the versions of dependencies of
> dependencies this way. If we remove the changes to the lock file, then we
> won't be storing tested versions, everyone would be using slightly
> different versions and we may potentially need to address versioning issues
> in the future - best to prevent that with a lock file.
You didn't answer about removing the usuless lines, like unneeded Windows support.
next prev parent reply other threads:[~2023-04-11 14:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 11:46 Juraj Linkeš
2023-04-03 11:46 ` [PATCH v1 2/2] dts: replace pexpect with fabric Juraj Linkeš
2023-04-24 13:35 ` [PATCH v2] " Juraj Linkeš
2023-04-28 19:03 ` Jeremy Spewock
2023-05-02 13:00 ` Juraj Linkeš
2023-05-03 17:54 ` Jeremy Spewock
2023-06-09 9:46 ` [PATCH v3] " Juraj Linkeš
2023-06-21 18:33 ` Jeremy Spewock
2023-07-05 19:59 ` Jeremy Spewock
2023-07-12 16:34 ` Thomas Monjalon
2023-07-09 1:45 ` Patrick Robb
2023-04-03 12:33 ` [PATCH v1 1/2] dts: fabric requirements Thomas Monjalon
2023-04-03 14:56 ` Juraj Linkeš
2023-04-03 15:17 ` Thomas Monjalon
2023-04-04 11:51 ` Juraj Linkeš
2023-04-11 14:48 ` Thomas Monjalon [this message]
2023-04-12 13:42 ` Juraj Linkeš
2023-04-12 15:24 ` Thomas Monjalon
2023-04-12 15:38 ` Honnappa Nagarahalli
2023-04-13 6:50 ` Juraj Linkeš
2023-04-13 7:49 ` Juraj Linkeš
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5667444.DvuYhMxLoT@thomas \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jspewock@iol.unh.edu \
--cc=juraj.linkes@pantheon.tech \
--cc=lijuan.tu@intel.com \
--cc=probb@iol.unh.edu \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).