From: Markus Theil <markus.theil@tu-ilmenau.de>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH 1/2] build: allow to conditionally build apps
Date: Thu, 13 Oct 2022 17:11:38 +0200 [thread overview]
Message-ID: <56efd282-60eb-cfae-78bf-c601c4ea5856@tu-ilmenau.de> (raw)
In-Reply-To: <Y0ba+WHRcBOxvPgk@bricha3-MOBL.ger.corp.intel.com>
On 10/12/22 17:19, Bruce Richardson wrote:
> On Wed, Oct 12, 2022 at 04:47:03PM +0200, Markus Theil wrote:
>> Makes apps configureable from meson, like already
>> possible for drivers.
>>
>> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
>> ---
>> app/meson.build | 17 ++++++++++++-----
>> meson_options.txt | 4 ++++
>> 2 files changed, 16 insertions(+), 5 deletions(-)
>>
>> diff --git a/app/meson.build b/app/meson.build
>> index 93d8c15032..4d9c8ee814 100644
>> --- a/app/meson.build
>> +++ b/app/meson.build
>> @@ -1,6 +1,9 @@
>> # SPDX-License-Identifier: BSD-3-Clause
>> # Copyright(c) 2017-2019 Intel Corporation
>>
>> +enabled_apps = get_option('enable_apps')
>> +disabled_apps = get_option('disable_apps')
>> +
>> apps = [
>> 'dumpcap',
>> 'pdump',
>> @@ -27,7 +30,11 @@ if get_option('default_library') == 'static' and not is_windows
>> endif
>>
>> foreach app:apps
>> - build = true
>> + build = enabled_apps == '' or enabled_apps.contains(app)
>> + # let disabled_apps override enabled_apps
>> + if disabled_apps != ''
>> + build = build and not disabled_apps.contains(app)
>> + endif
>> name = app
>> sources = []
>> includes = []
>> @@ -41,6 +48,10 @@ foreach app:apps
>> ext_deps = []
>> deps = []
>>
>> + if not build
>> + continue
>> + endif
>> +
>> subdir(name)
>>
>> if build
>> @@ -56,10 +67,6 @@ foreach app:apps
>> endforeach
>> endif
>>
>> - if not build
>> - continue
>> - endif
>> -
> Does this block not still need to be kept? Is it possible that build could
> be set to false in the subdir or other logic?
I will move the block to its old position in the next revision. Thanks
for the hint.
> /Bruce
next prev parent reply other threads:[~2022-10-13 15:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 14:47 Markus Theil
2022-10-12 14:47 ` [PATCH 2/2] build: export dpdk_includes for subproject usage Markus Theil
2022-10-12 15:21 ` Bruce Richardson
2022-10-13 15:12 ` Markus Theil
2022-10-12 15:19 ` [PATCH 1/2] build: allow to conditionally build apps Bruce Richardson
2022-10-13 15:11 ` Markus Theil [this message]
2022-10-13 16:36 ` Bruce Richardson
2022-10-13 15:31 ` [PATCH v2 " Markus Theil
2022-10-13 15:31 ` [PATCH v2 2/2] build: export dpdk_includes for subproject usage Markus Theil
2022-10-13 15:41 ` Stephen Hemminger
2022-10-13 15:35 ` [PATCH v3 1/2] build: allow to conditionally build apps Markus Theil
2022-10-14 7:51 ` [PATCH v4 " Markus Theil
2022-10-14 7:51 ` [PATCH v4 2/2] build: export dpdk_includes for subproject usage Markus Theil
2022-10-14 8:45 ` Bruce Richardson
2022-10-14 8:44 ` [PATCH v4 1/2] build: allow to conditionally build apps Bruce Richardson
2022-10-28 12:31 ` David Marchand
2022-10-27 13:13 ` David Marchand
2022-10-27 14:22 ` David Marchand
2022-10-28 6:43 ` Markus Theil
2022-10-13 15:35 ` [PATCH v3 2/2] build: export dpdk_includes for subproject usage Markus Theil
2022-10-13 16:38 ` Bruce Richardson
2022-10-14 7:56 ` Markus Theil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56efd282-60eb-cfae-78bf-c601c4ea5856@tu-ilmenau.de \
--to=markus.theil@tu-ilmenau.de \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).