From: Markus Theil <markus.theil@tu-ilmenau.de>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Thorben Roemer <thorben.roemer@secunet.com>
Subject: Re: [PATCH 2/2] build: export dpdk_includes for subproject usage.
Date: Thu, 13 Oct 2022 17:12:58 +0200 [thread overview]
Message-ID: <9458923c-6de8-5553-99a6-4193156b7869@tu-ilmenau.de> (raw)
In-Reply-To: <Y0bbfLNkxnwWUm19@bricha3-MOBL.ger.corp.intel.com>
On 10/12/22 17:21, Bruce Richardson wrote:
> On Wed, Oct 12, 2022 at 04:47:04PM +0200, Markus Theil wrote:
>> From: Thorben Roemer <thorben.roemer@secunet.com>
>>
>> In order to perform things like LTO more easily in
>> our DPDK applications, we use DPDK as a meson subproject.
>> Also export includes in order to be usable in this context.
>>
>> Signed-off-by: Thorben Roemer <thorben.roemer@secunet.com>
>> ---
>> drivers/meson.build | 1 +
>> lib/meson.build | 1 +
>> meson.build | 1 +
>> 3 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/meson.build b/drivers/meson.build
>> index 216971f4e2..d19b47df12 100644
>> --- a/drivers/meson.build
>> +++ b/drivers/meson.build
>> @@ -95,6 +95,7 @@ foreach subpath:subdirs
>> objs = []
>> cflags = default_cflags
>> includes = [include_directories(drv_path)]
>> + dpdk_includes += [include_directories(drv_path)]
> I am not sure that by default we should include all the driver directories.
> At most, we should only include those drivers which have header files to be
> made public. I think initially though we should only export library paths.
I tried to only include libraries. At least for our DPDK-based
application, the bonding and i40e includes are needed. I therefore tried
to include all drivers exporting symbols to the dpdk_includes list in
the following revision.
> /Bruce
>
next prev parent reply other threads:[~2022-10-13 15:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 14:47 [PATCH 1/2] build: allow to conditionally build apps Markus Theil
2022-10-12 14:47 ` [PATCH 2/2] build: export dpdk_includes for subproject usage Markus Theil
2022-10-12 15:21 ` Bruce Richardson
2022-10-13 15:12 ` Markus Theil [this message]
2022-10-12 15:19 ` [PATCH 1/2] build: allow to conditionally build apps Bruce Richardson
2022-10-13 15:11 ` Markus Theil
2022-10-13 16:36 ` Bruce Richardson
2022-10-13 15:31 ` [PATCH v2 " Markus Theil
2022-10-13 15:31 ` [PATCH v2 2/2] build: export dpdk_includes for subproject usage Markus Theil
2022-10-13 15:41 ` Stephen Hemminger
2022-10-13 15:35 ` [PATCH v3 1/2] build: allow to conditionally build apps Markus Theil
2022-10-14 7:51 ` [PATCH v4 " Markus Theil
2022-10-14 7:51 ` [PATCH v4 2/2] build: export dpdk_includes for subproject usage Markus Theil
2022-10-14 8:45 ` Bruce Richardson
2022-10-14 8:44 ` [PATCH v4 1/2] build: allow to conditionally build apps Bruce Richardson
2022-10-28 12:31 ` David Marchand
2022-10-27 13:13 ` David Marchand
2022-10-27 14:22 ` David Marchand
2022-10-28 6:43 ` Markus Theil
2022-10-13 15:35 ` [PATCH v3 2/2] build: export dpdk_includes for subproject usage Markus Theil
2022-10-13 16:38 ` Bruce Richardson
2022-10-14 7:56 ` Markus Theil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9458923c-6de8-5553-99a6-4193156b7869@tu-ilmenau.de \
--to=markus.theil@tu-ilmenau.de \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thorben.roemer@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).