From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
Cc: jerin.jacob@caviumnetworks.com, thomas.monjalon@6wind.com,
bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] doc: announce ABI change for mbuf structure
Date: Wed, 20 Jul 2016 09:54:06 +0100 [thread overview]
Message-ID: <578F3C2E.1050909@intel.com> (raw)
In-Reply-To: <1468998974-3040-1-git-send-email-olivier.matz@6wind.com>
On 7/20/2016 8:16 AM, Olivier Matz wrote:
> For 16.11, the mbuf structure will be modified implying ABI breakage.
> Some discussions already took place here:
> http://www.dpdk.org/dev/patchwork/patch/12878/
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>
> v1->v2:
> - reword the sentences to keep things more open, as suggested by Bruce
>
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index f502f86..b9f5a93 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -41,3 +41,9 @@ Deprecation Notices
> * The mempool functions for single/multi producer/consumer are deprecated and
> will be removed in 16.11.
> It is replaced by rte_mempool_generic_get/put functions.
> +
> +* ABI changes are planned for 16.11 in the ``rte_mbuf`` structure: some fields
> + may be reordered to facilitate the writing of ``data_off``, ``refcnt``, and
> + ``nb_segs`` in one operation, because some platforms have an overhead if the
> + store address is not naturally aligned. Other mbuf fields, such as the
> + ``port`` field, may be moved or removed as part of this mbuf work.
>
Not directly related to this patch, but generally for deprecation
notices, does it make sense to tag explicitly which library effected, like:
* librte_mbuf [perhaps with version here]:
Explanation about deprecation ...
For this case it is more clear which library effected, but sometimes
that is not obvious from deprecation notice.
Also when checked for if specific library effected, it is harder to find
with current notes.
Thanks,
ferruh
next prev parent reply other threads:[~2016-07-20 8:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 14:01 [dpdk-dev] [PATCH] " Olivier Matz
2016-07-19 14:40 ` Bruce Richardson
2016-07-19 15:04 ` Olivier Matz
2016-07-19 15:07 ` Richardson, Bruce
2016-07-19 15:28 ` Olivier Matz
2016-07-20 7:16 ` [dpdk-dev] [PATCH v2] " Olivier Matz
2016-07-20 8:54 ` Ferruh Yigit [this message]
2016-07-27 8:33 ` Thomas Monjalon
2016-07-28 18:04 ` Thomas Monjalon
2016-07-27 9:34 ` Ananyev, Konstantin
2016-07-28 2:35 ` John Daley (johndale)
2016-07-28 2:39 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=578F3C2E.1050909@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=olivier.matz@6wind.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).