From: "Eelco Chaudron" <echaudro@redhat.com>
To: "Alejandro Lucero" <alejandro.lucero@netronome.com>
Cc: dev@dpdk.org, stable@dpdk.org, anatoly.burakov@intel.com,
maxime.coquelin@redhat.com, ferruh.yigit@intel.com,
"Andrew Rybchenko" <arybchenko@solarflare.com>
Subject: Re: [dpdk-stable] [PATCH v3 2/6] ethdev: add function for checking IOVAs by a device
Date: Tue, 10 Jul 2018 10:57:39 +0200 [thread overview]
Message-ID: <5BCBEF5B-AA29-4F18-A95B-D5C5478B0432@redhat.com> (raw)
In-Reply-To: <1530708838-2682-3-git-send-email-alejandro.lucero@netronome.com>
On 4 Jul 2018, at 14:53, Alejandro Lucero wrote:
> A PMD should invoke this function for checking memsegs iovas are
> within
> the supported range by the device.
>
> Signed-off-by: Alejandro Lucero <alejandro.lucero@netronome.com>
Agree with Andrew here, why not call rte_eal_check_dma_mask() directly
in nfp_net_txq_full()?
> ---
> lib/librte_ether/rte_ethdev.h | 13 +++++++++++++
> lib/librte_ether/rte_ethdev_version.map | 1 +
> 2 files changed, 14 insertions(+)
>
> diff --git a/lib/librte_ether/rte_ethdev.h
> b/lib/librte_ether/rte_ethdev.h
> index eba11ca..e51a432 100644
> --- a/lib/librte_ether/rte_ethdev.h
> +++ b/lib/librte_ether/rte_ethdev.h
> @@ -2799,6 +2799,19 @@ int rte_eth_dev_set_vlan_ether_type(uint16_t
> port_id,
> int rte_eth_dev_set_vlan_pvid(uint16_t port_id, uint16_t pvid, int
> on);
>
> /**
> + * check device dma mask within expected range based on dma mask.
> + *
> + * @param maskbits
> + * mask length in bits
> + *
> + */
> +static inline int
> +rte_eth_dev_check_dma_mask(uint8_t maskbits)
> +{
> + return rte_eal_check_dma_mask(maskbits);
> +}
> +
> +/**
> *
> * Retrieve a burst of input packets from a receive queue of an
> Ethernet
> * device. The retrieved packets are stored in *rte_mbuf* structures
> whose
> diff --git a/lib/librte_ether/rte_ethdev_version.map
> b/lib/librte_ether/rte_ethdev_version.map
> index e9681ac..0b11b8a 100644
> --- a/lib/librte_ether/rte_ethdev_version.map
> +++ b/lib/librte_ether/rte_ethdev_version.map
> @@ -191,6 +191,7 @@ DPDK_17.08 {
> DPDK_17.11 {
> global:
>
> + rte_eth_dev_check_dma_mask;
> rte_eth_dev_get_sec_ctx;
> rte_eth_dev_pool_ops_supported;
> rte_eth_dev_reset;
> --
> 1.9.1
next prev parent reply other threads:[~2018-07-10 8:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-04 12:53 [dpdk-stable] [PATCH v3 0/6] use IOVAs check based on DMA mask Alejandro Lucero
2018-07-04 12:53 ` [dpdk-stable] [PATCH v3 1/6] mem: add function for checking memsegs IOVAs addresses Alejandro Lucero
2018-07-10 8:56 ` Eelco Chaudron
2018-07-10 9:34 ` Alejandro Lucero
2018-07-10 10:06 ` Eelco Chaudron
2018-07-10 10:52 ` Alejandro Lucero
2018-07-10 11:14 ` Eelco Chaudron
2018-07-10 11:33 ` Burakov, Anatoly
2018-07-10 11:43 ` Alejandro Lucero
2018-07-10 11:55 ` Eelco Chaudron
2018-07-10 11:40 ` Alejandro Lucero
2018-07-04 12:53 ` [dpdk-stable] [PATCH v3 2/6] ethdev: add function for checking IOVAs by a device Alejandro Lucero
2018-07-07 17:30 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2018-07-10 8:57 ` Eelco Chaudron [this message]
2018-07-10 9:42 ` [dpdk-stable] " Alejandro Lucero
2018-07-10 9:44 ` Alejandro Lucero
2018-07-04 12:53 ` [dpdk-stable] [PATCH v3 3/6] bus/pci: use IOVAs check when setting IOVA mode Alejandro Lucero
2018-07-10 10:14 ` Eelco Chaudron
2018-07-10 15:37 ` Alejandro Lucero
2018-07-04 12:53 ` [dpdk-stable] [PATCH v3 4/6] mem: use address hint for mapping hugepages Alejandro Lucero
2018-07-10 11:15 ` Eelco Chaudron
2018-07-04 12:53 ` [dpdk-stable] [PATCH v3 5/6] net/nfp: check hugepages IOVAs based on DMA mask Alejandro Lucero
2018-07-10 10:17 ` Eelco Chaudron
2018-07-04 12:53 ` [dpdk-stable] [PATCH v3 6/6] net/nfp: support IOVA VA mode Alejandro Lucero
2018-07-10 10:18 ` Eelco Chaudron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5BCBEF5B-AA29-4F18-A95B-D5C5478B0432@redhat.com \
--to=echaudro@redhat.com \
--cc=alejandro.lucero@netronome.com \
--cc=anatoly.burakov@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).