DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mattias Rönnblom" <hofors@lysator.liu.se>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>
Subject: Re: [PATCH 09/15] eal: make seqcount and seqlock stable
Date: Wed, 9 Aug 2023 21:47:47 +0200	[thread overview]
Message-ID: <5ed8965f-1e2c-9c28-2cd2-fbf2bda9f6e3@lysator.liu.se> (raw)
In-Reply-To: <20230809164312.308093-10-stephen@networkplumber.org>

On 2023-08-09 18:43, Stephen Hemminger wrote:
> These were add back in 22.07 release.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>   lib/eal/include/rte_seqcount.h | 23 -----------------------
>   lib/eal/include/rte_seqlock.h  | 21 ---------------------
>   2 files changed, 44 deletions(-)
> 

Acked-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>

> diff --git a/lib/eal/include/rte_seqcount.h b/lib/eal/include/rte_seqcount.h
> index ff62708e1b7b..6390a5a72f7c 100644
> --- a/lib/eal/include/rte_seqcount.h
> +++ b/lib/eal/include/rte_seqcount.h
> @@ -40,15 +40,11 @@ typedef struct {
>   #define RTE_SEQCOUNT_INITIALIZER { .sn = 0 }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * Initialize the sequence counter.
>    *
>    * @param seqcount
>    *   A pointer to the sequence counter.
>    */
> -__rte_experimental
>   static inline void
>   rte_seqcount_init(rte_seqcount_t *seqcount)
>   {
> @@ -56,9 +52,6 @@ rte_seqcount_init(rte_seqcount_t *seqcount)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * Begin a read-side critical section.
>    *
>    * A call to this function marks the beginning of a read-side critical
> @@ -100,8 +93,6 @@ rte_seqcount_init(rte_seqcount_t *seqcount)
>    *
>    * @see rte_seqcount_read_retry()
>    */
> -
> -__rte_experimental
>   static inline uint32_t
>   rte_seqcount_read_begin(const rte_seqcount_t *seqcount)
>   {
> @@ -113,9 +104,6 @@ rte_seqcount_read_begin(const rte_seqcount_t *seqcount)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * End a read-side critical section.
>    *
>    * A call to this function marks the end of a read-side critical
> @@ -145,8 +133,6 @@ rte_seqcount_read_begin(const rte_seqcount_t *seqcount)
>    *
>    * @see rte_seqcount_read_begin()
>    */
> -
> -__rte_experimental
>   static inline bool
>   rte_seqcount_read_retry(const rte_seqcount_t *seqcount, uint32_t begin_sn)
>   {
> @@ -171,9 +157,6 @@ rte_seqcount_read_retry(const rte_seqcount_t *seqcount, uint32_t begin_sn)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * Begin a write-side critical section.
>    *
>    * A call to this function marks the beginning of a write-side
> @@ -195,8 +178,6 @@ rte_seqcount_read_retry(const rte_seqcount_t *seqcount, uint32_t begin_sn)
>    *
>    * @see rte_seqcount_write_end()
>    */
> -
> -__rte_experimental
>   static inline void
>   rte_seqcount_write_begin(rte_seqcount_t *seqcount)
>   {
> @@ -213,9 +194,6 @@ rte_seqcount_write_begin(rte_seqcount_t *seqcount)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * End a write-side critical section.
>    *
>    * A call to this function marks the end of the write-side critical
> @@ -227,7 +205,6 @@ rte_seqcount_write_begin(rte_seqcount_t *seqcount)
>    *
>    * @see rte_seqcount_write_begin()
>    */
> -__rte_experimental
>   static inline void
>   rte_seqcount_write_end(rte_seqcount_t *seqcount)
>   {
> diff --git a/lib/eal/include/rte_seqlock.h b/lib/eal/include/rte_seqlock.h
> index fcbb9c586668..589c98188529 100644
> --- a/lib/eal/include/rte_seqlock.h
> +++ b/lib/eal/include/rte_seqlock.h
> @@ -114,9 +114,6 @@ typedef struct {
>   	}
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * Initialize the seqlock.
>    *
>    * This function initializes the seqlock, and leaves the writer-side
> @@ -125,7 +122,6 @@ typedef struct {
>    * @param seqlock
>    *   A pointer to the seqlock.
>    */
> -__rte_experimental
>   static inline void
>   rte_seqlock_init(rte_seqlock_t *seqlock)
>   {
> @@ -134,9 +130,6 @@ rte_seqlock_init(rte_seqlock_t *seqlock)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * Begin a read-side critical section.
>    *
>    * See rte_seqcount_read_retry() for details.
> @@ -150,8 +143,6 @@ rte_seqlock_init(rte_seqlock_t *seqlock)
>    * @see rte_seqlock_read_retry()
>    * @see rte_seqcount_read_retry()
>    */
> -
> -__rte_experimental
>   static inline uint32_t
>   rte_seqlock_read_begin(const rte_seqlock_t *seqlock)
>   {
> @@ -159,9 +150,6 @@ rte_seqlock_read_begin(const rte_seqlock_t *seqlock)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * End a read-side critical section.
>    *
>    * See rte_seqcount_read_retry() for details.
> @@ -177,7 +165,6 @@ rte_seqlock_read_begin(const rte_seqlock_t *seqlock)
>    *
>    * @see rte_seqlock_read_begin()
>    */
> -__rte_experimental
>   static inline bool
>   rte_seqlock_read_retry(const rte_seqlock_t *seqlock, uint32_t begin_sn)
>   {
> @@ -185,9 +172,6 @@ rte_seqlock_read_retry(const rte_seqlock_t *seqlock, uint32_t begin_sn)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * Begin a write-side critical section.
>    *
>    * A call to this function acquires the write lock associated @p
> @@ -212,7 +196,6 @@ rte_seqlock_read_retry(const rte_seqlock_t *seqlock, uint32_t begin_sn)
>    *
>    * @see rte_seqlock_write_unlock()
>    */
> -__rte_experimental
>   static inline void
>   rte_seqlock_write_lock(rte_seqlock_t *seqlock)
>   	__rte_exclusive_lock_function(&seqlock->lock)
> @@ -224,9 +207,6 @@ rte_seqlock_write_lock(rte_seqlock_t *seqlock)
>   }
>   
>   /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>    * End a write-side critical section.
>    *
>    * A call to this function marks the end of the write-side critical
> @@ -238,7 +218,6 @@ rte_seqlock_write_lock(rte_seqlock_t *seqlock)
>    *
>    * @see rte_seqlock_write_lock()
>    */
> -__rte_experimental
>   static inline void
>   rte_seqlock_write_unlock(rte_seqlock_t *seqlock)
>   	__rte_unlock_function(&seqlock->lock)

  reply	other threads:[~2023-08-09 19:47 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 16:42 [PATCH 00/15] eal: mark older API's stable Stephen Hemminger
2023-08-09 16:42 ` [PATCH 01/15] eal: make bitops a stable API Stephen Hemminger
2023-08-09 17:58   ` Tyler Retzlaff
2023-08-09 20:07     ` Stephen Hemminger
2023-08-09 21:59       ` Tyler Retzlaff
2023-08-09 16:42 ` [PATCH 02/15] eal: mark rte_dev API's as stable Stephen Hemminger
2023-08-09 16:42 ` [PATCH 03/15] eal: make rte_class API's stable Stephen Hemminger
2023-08-09 16:42 ` [PATCH 04/15] eal: make rte_version_XXX " Stephen Hemminger
2023-08-10  8:24   ` Bruce Richardson
2023-08-09 16:42 ` [PATCH 05/15] eal: make rte_drand a stable API Stephen Hemminger
2023-08-09 16:42 ` [PATCH 06/15] eal: make rte_service_lcore_may_be_active stable Stephen Hemminger
2023-08-10  9:08   ` Van Haaren, Harry
2023-08-09 16:42 ` [PATCH 07/15] eal: make rte_devargs_reset stable Stephen Hemminger
2023-08-09 16:43 ` [PATCH 08/15] eal: make pflock API stable Stephen Hemminger
2023-08-09 16:43 ` [PATCH 09/15] eal: make seqcount and seqlock stable Stephen Hemminger
2023-08-09 19:47   ` Mattias Rönnblom [this message]
2023-08-09 16:43 ` [PATCH 10/15] eal: mark rte_intr_XXX API's as stable Stephen Hemminger
2023-08-09 16:43 ` [PATCH 11/15] eal: mark rte_atomic128_cmp_exchange " Stephen Hemminger
2023-08-09 17:50   ` Tyler Retzlaff
2023-08-09 16:43 ` [PATCH 12/15] eal: make most rte_thread API's stable Stephen Hemminger
2023-08-09 17:53   ` Tyler Retzlaff
2023-08-09 16:43 ` [PATCH 13/15] eal: mark rte_power " Stephen Hemminger
2023-08-09 16:43 ` [PATCH 14/15] eal: mark rte_eal_vfio_get_token stable Stephen Hemminger
2023-08-09 17:55   ` Tyler Retzlaff
2023-08-09 16:43 ` [PATCH 15/15] eal: mark rte_vect simd bandwidth API as stable Stephen Hemminger
2023-10-18 19:29 ` [PATCH 00/15] eal: mark older API's stable David Marchand
2023-10-20 21:41 ` [PATCH v2 00/14] eal: mark older API's as stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 01/14] eal: make bitops a stable API Stephen Hemminger
2023-10-23  2:31     ` Joyce Kong
2023-10-20 21:41   ` [PATCH v2 02/14] eal: mark rte_dev API's as stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 03/14] eal: make rte_class API's stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 04/14] eal: make rte_drand a stable API Stephen Hemminger
2023-10-23 16:12     ` Mattias Rönnblom
2023-10-20 21:41   ` [PATCH v2 05/14] eal: make rte_service_lcore_may_be_active stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 06/14] eal: make rte_devargs_reset stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 07/14] eal: make pflock API stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 08/14] eal: make seqcount and seqlock stable Stephen Hemminger
2023-10-23 16:14     ` Mattias Rönnblom
2023-10-20 21:41   ` [PATCH v2 09/14] eal: mark rte_intr_XXX API's as stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 10/14] eal: mark rte_atomic128_cmp_exchange " Stephen Hemminger
2023-10-23  3:00     ` Ruifeng Wang
2023-10-20 21:41   ` [PATCH v2 11/14] eal: mark rte_power API's stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 12/14] eal: mark rte_eal_vfio_get_token stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 13/14] eal: mark rte_vect simd bandwidth API as stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 14/14] eal: make rte_version API's stable Stephen Hemminger
2023-10-23  9:13   ` [PATCH v2 00/14] eal: mark older API's as stable Bruce Richardson
2023-11-14 13:10   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ed8965f-1e2c-9c28-2cd2-fbf2bda9f6e3@lysator.liu.se \
    --to=hofors@lysator.liu.se \
    --cc=dev@dpdk.org \
    --cc=mattias.ronnblom@ericsson.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).