DPDK patches and discussions
 help / color / mirror / Atom feed
From: Joyce Kong <Joyce.Kong@arm.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
Subject: RE: [PATCH v2 01/14] eal: make bitops a stable API
Date: Mon, 23 Oct 2023 02:31:16 +0000	[thread overview]
Message-ID: <AS4PR08MB7712EC0678440EC0040135ED92D8A@AS4PR08MB7712.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20231020214119.255491-2-stephen@networkplumber.org>

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Saturday, October 21, 2023 5:41 AM
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Cristian
> Dumitrescu <cristian.dumitrescu@intel.com>; Joyce Kong
> <Joyce.Kong@arm.com>
> Subject: [PATCH v2 01/14] eal: make bitops a stable API
>
> These were added in 20.05 release.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Reviewed-by: Joyce Kong <joyce.kong@arm.com>

> ---
>  lib/eal/include/rte_bitmap.h |  8 --------  lib/eal/include/rte_bitops.h | 40 -----
> -------------------------------
>  2 files changed, 48 deletions(-)
>
> diff --git a/lib/eal/include/rte_bitmap.h b/lib/eal/include/rte_bitmap.h index
> 46a822768d50..ec819595624c 100644
> --- a/lib/eal/include/rte_bitmap.h
> +++ b/lib/eal/include/rte_bitmap.h
> @@ -203,9 +203,6 @@ rte_bitmap_init(uint32_t n_bits, uint8_t *mem,
> uint32_t mem_size)  }
>
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>   * Bitmap clear slab overhead bits.
>   *
>   * @param slabs
> @@ -215,7 +212,6 @@ rte_bitmap_init(uint32_t n_bits, uint8_t *mem,
> uint32_t mem_size)
>   * @param pos
>   *   The start bit position in the slabs to be cleared.
>   */
> -__rte_experimental
>  static inline void
>  __rte_bitmap_clear_slab_overhead_bits(uint64_t *slabs, uint32_t slab_size,
>                                     uint32_t pos)
> @@ -235,9 +231,6 @@ __rte_bitmap_clear_slab_overhead_bits(uint64_t
> *slabs, uint32_t slab_size,  }
>
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change without prior notice.
> - *
>   * Bitmap initialization with all bits set
>   *
>   * @param n_bits
> @@ -249,7 +242,6 @@ __rte_bitmap_clear_slab_overhead_bits(uint64_t
> *slabs, uint32_t slab_size,
>   * @return
>   *   Handle to bitmap instance.
>   */
> -__rte_experimental
>  static inline struct rte_bitmap *
>  rte_bitmap_init_with_all_set(uint32_t n_bits, uint8_t *mem, uint32_t
> mem_size)  { diff --git a/lib/eal/include/rte_bitops.h
> b/lib/eal/include/rte_bitops.h index 6b8ae8d3acf6..29d24b3a780e 100644
> --- a/lib/eal/include/rte_bitops.h
> +++ b/lib/eal/include/rte_bitops.h
> @@ -42,9 +42,6 @@ extern "C" {
>  /*------------------------ 32-bit relaxed operations ------------------------*/
>
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change, or be removed, without prior
> notice
> - *
>   * Get the target bit from a 32-bit value without memory ordering.
>   *
>   * @param nr
> @@ -54,7 +51,6 @@ extern "C" {
>   * @return
>   *   The target bit.
>   */
> -__rte_experimental
>  static inline uint32_t
>  rte_bit_relaxed_get32(unsigned int nr, volatile uint32_t *addr)  { @@ -65,9
> +61,6 @@ rte_bit_relaxed_get32(unsigned int nr, volatile uint32_t *addr)  }
>
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change, or be removed, without prior
> notice
> - *
>   * Set the target bit in a 32-bit value to 1 without memory ordering.
>   *
>   * @param nr
> @@ -75,7 +68,6 @@ rte_bit_relaxed_get32(unsigned int nr, volatile uint32_t
> *addr)
>   * @param addr
>   *   The address holding the bit.
>   */
> -__rte_experimental
>  static inline void
>  rte_bit_relaxed_set32(unsigned int nr, volatile uint32_t *addr)  { @@ -86,9
> +78,6 @@ rte_bit_relaxed_set32(unsigned int nr, volatile uint32_t *addr)  }
>
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change, or be removed, without prior
> notice
> - *
>   * Clear the target bit in a 32-bit value to 0 without memory ordering.
>   *
>   * @param nr
> @@ -96,7 +85,6 @@ rte_bit_relaxed_set32(unsigned int nr, volatile uint32_t
> *addr)
>   * @param addr
>   *   The address holding the bit.
>   */
> -__rte_experimental
>  static inline void
>  rte_bit_relaxed_clear32(unsigned int nr, volatile uint32_t *addr)  { @@ -107,9
> +95,6 @@ rte_bit_relaxed_clear32(unsigned int nr, volatile uint32_t *addr)  }
>
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change, or be removed, without prior
> notice
> - *
>   * Return the original bit from a 32-bit value, then set it to 1 without
>   * memory ordering.
>   *
> @@ -120,7 +105,6 @@ rte_bit_relaxed_clear32(unsigned int nr, volatile
> uint32_t *addr)
>   * @return
>   *   The original bit.
>   */
> -__rte_experimental
>  static inline uint32_t
>  rte_bit_relaxed_test_and_set32(unsigned int nr, volatile uint32_t *addr)
> { @@ -133,9 +117,6 @@ rte_bit_relaxed_test_and_set32(unsigned int nr,
> volatile uint32_t *addr)  }
>
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change, or be removed, without prior
> notice
> - *
>   * Return the original bit from a 32-bit value, then clear it to 0 without
>   * memory ordering.
>   *
> @@ -146,7 +127,6 @@ rte_bit_relaxed_test_and_set32(unsigned int nr,
> volatile uint32_t *addr)
>   * @return
>   *   The original bit.
>   */
> -__rte_experimental
>  static inline uint32_t
>  rte_bit_relaxed_test_and_clear32(unsigned int nr, volatile uint32_t *addr)
> { @@ -161,9 +141,6 @@ rte_bit_relaxed_test_and_clear32(unsigned int nr,
> volatile uint32_t *addr)
>  /*------------------------ 64-bit relaxed operations ------------------------*/
>
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change, or be removed, without prior
> notice
> - *
>   * Get the target bit from a 64-bit value without memory ordering.
>   *
>   * @param nr
> @@ -173,7 +150,6 @@ rte_bit_relaxed_test_and_clear32(unsigned int nr,
> volatile uint32_t *addr)
>   * @return
>   *   The target bit.
>   */
> -__rte_experimental
>  static inline uint64_t
>  rte_bit_relaxed_get64(unsigned int nr, volatile uint64_t *addr)  { @@ -184,9
> +160,6 @@ rte_bit_relaxed_get64(unsigned int nr, volatile uint64_t *addr)  }
>
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change, or be removed, without prior
> notice
> - *
>   * Set the target bit in a 64-bit value to 1 without memory ordering.
>   *
>   * @param nr
> @@ -194,7 +167,6 @@ rte_bit_relaxed_get64(unsigned int nr, volatile
> uint64_t *addr)
>   * @param addr
>   *   The address holding the bit.
>   */
> -__rte_experimental
>  static inline void
>  rte_bit_relaxed_set64(unsigned int nr, volatile uint64_t *addr)  { @@ -205,9
> +177,6 @@ rte_bit_relaxed_set64(unsigned int nr, volatile uint64_t *addr)  }
>
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change, or be removed, without prior
> notice
> - *
>   * Clear the target bit in a 64-bit value to 0 without memory ordering.
>   *
>   * @param nr
> @@ -215,7 +184,6 @@ rte_bit_relaxed_set64(unsigned int nr, volatile
> uint64_t *addr)
>   * @param addr
>   *   The address holding the bit.
>   */
> -__rte_experimental
>  static inline void
>  rte_bit_relaxed_clear64(unsigned int nr, volatile uint64_t *addr)  { @@ -226,9
> +194,6 @@ rte_bit_relaxed_clear64(unsigned int nr, volatile uint64_t *addr)  }
>
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change, or be removed, without prior
> notice
> - *
>   * Return the original bit from a 64-bit value, then set it to 1 without
>   * memory ordering.
>   *
> @@ -239,7 +204,6 @@ rte_bit_relaxed_clear64(unsigned int nr, volatile
> uint64_t *addr)
>   * @return
>   *   The original bit.
>   */
> -__rte_experimental
>  static inline uint64_t
>  rte_bit_relaxed_test_and_set64(unsigned int nr, volatile uint64_t *addr)
> { @@ -252,9 +216,6 @@ rte_bit_relaxed_test_and_set64(unsigned int nr,
> volatile uint64_t *addr)  }
>
>  /**
> - * @warning
> - * @b EXPERIMENTAL: this API may change, or be removed, without prior
> notice
> - *
>   * Return the original bit from a 64-bit value, then clear it to 0 without
>   * memory ordering.
>   *
> @@ -265,7 +226,6 @@ rte_bit_relaxed_test_and_set64(unsigned int nr,
> volatile uint64_t *addr)
>   * @return
>   *   The original bit.
>   */
> -__rte_experimental
>  static inline uint64_t
>  rte_bit_relaxed_test_and_clear64(unsigned int nr, volatile uint64_t *addr)  {
> --
> 2.39.2

IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.

  reply	other threads:[~2023-10-23  2:31 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-09 16:42 [PATCH 00/15] eal: mark older API's stable Stephen Hemminger
2023-08-09 16:42 ` [PATCH 01/15] eal: make bitops a stable API Stephen Hemminger
2023-08-09 17:58   ` Tyler Retzlaff
2023-08-09 20:07     ` Stephen Hemminger
2023-08-09 21:59       ` Tyler Retzlaff
2023-08-09 16:42 ` [PATCH 02/15] eal: mark rte_dev API's as stable Stephen Hemminger
2023-08-09 16:42 ` [PATCH 03/15] eal: make rte_class API's stable Stephen Hemminger
2023-08-09 16:42 ` [PATCH 04/15] eal: make rte_version_XXX " Stephen Hemminger
2023-08-10  8:24   ` Bruce Richardson
2023-08-09 16:42 ` [PATCH 05/15] eal: make rte_drand a stable API Stephen Hemminger
2023-08-09 16:42 ` [PATCH 06/15] eal: make rte_service_lcore_may_be_active stable Stephen Hemminger
2023-08-10  9:08   ` Van Haaren, Harry
2023-08-09 16:42 ` [PATCH 07/15] eal: make rte_devargs_reset stable Stephen Hemminger
2023-08-09 16:43 ` [PATCH 08/15] eal: make pflock API stable Stephen Hemminger
2023-08-09 16:43 ` [PATCH 09/15] eal: make seqcount and seqlock stable Stephen Hemminger
2023-08-09 19:47   ` Mattias Rönnblom
2023-08-09 16:43 ` [PATCH 10/15] eal: mark rte_intr_XXX API's as stable Stephen Hemminger
2023-08-09 16:43 ` [PATCH 11/15] eal: mark rte_atomic128_cmp_exchange " Stephen Hemminger
2023-08-09 17:50   ` Tyler Retzlaff
2023-08-09 16:43 ` [PATCH 12/15] eal: make most rte_thread API's stable Stephen Hemminger
2023-08-09 17:53   ` Tyler Retzlaff
2023-08-09 16:43 ` [PATCH 13/15] eal: mark rte_power " Stephen Hemminger
2023-08-09 16:43 ` [PATCH 14/15] eal: mark rte_eal_vfio_get_token stable Stephen Hemminger
2023-08-09 17:55   ` Tyler Retzlaff
2023-08-09 16:43 ` [PATCH 15/15] eal: mark rte_vect simd bandwidth API as stable Stephen Hemminger
2023-10-18 19:29 ` [PATCH 00/15] eal: mark older API's stable David Marchand
2023-10-20 21:41 ` [PATCH v2 00/14] eal: mark older API's as stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 01/14] eal: make bitops a stable API Stephen Hemminger
2023-10-23  2:31     ` Joyce Kong [this message]
2023-10-20 21:41   ` [PATCH v2 02/14] eal: mark rte_dev API's as stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 03/14] eal: make rte_class API's stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 04/14] eal: make rte_drand a stable API Stephen Hemminger
2023-10-23 16:12     ` Mattias Rönnblom
2023-10-20 21:41   ` [PATCH v2 05/14] eal: make rte_service_lcore_may_be_active stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 06/14] eal: make rte_devargs_reset stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 07/14] eal: make pflock API stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 08/14] eal: make seqcount and seqlock stable Stephen Hemminger
2023-10-23 16:14     ` Mattias Rönnblom
2023-10-20 21:41   ` [PATCH v2 09/14] eal: mark rte_intr_XXX API's as stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 10/14] eal: mark rte_atomic128_cmp_exchange " Stephen Hemminger
2023-10-23  3:00     ` Ruifeng Wang
2023-10-20 21:41   ` [PATCH v2 11/14] eal: mark rte_power API's stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 12/14] eal: mark rte_eal_vfio_get_token stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 13/14] eal: mark rte_vect simd bandwidth API as stable Stephen Hemminger
2023-10-20 21:41   ` [PATCH v2 14/14] eal: make rte_version API's stable Stephen Hemminger
2023-10-23  9:13   ` [PATCH v2 00/14] eal: mark older API's as stable Bruce Richardson
2023-11-14 13:10   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AS4PR08MB7712EC0678440EC0040135ED92D8A@AS4PR08MB7712.eurprd08.prod.outlook.com \
    --to=joyce.kong@arm.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).