From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, shreyansh.jain@nxp.com,
Akhil Goyal <akhil.goyal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 7/7] build: add meson support for dpaaX platforms
Date: Thu, 1 Mar 2018 11:40:00 +0530 [thread overview]
Message-ID: <62b44634-c2e5-eb91-03b1-68b356835a3e@nxp.com> (raw)
In-Reply-To: <20180228144409.GA10572@bricha3-MOBL3.ger.corp.intel.com>
On 2/28/2018 8:14 PM, Bruce Richardson wrote:
> On Tue, Feb 27, 2018 at 10:55:52PM +0530, Hemant Agrawal wrote:
>> Signed-off-by: Akhil Goyal <akhil.goyal@nxp.com>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>
> Thanks for this. Some comments inline below.
>
> /Bruce
<snip>..
>> diff --git a/drivers/bus/fslmc/meson.build b/drivers/bus/fslmc/meson.build
>> new file mode 100644
>> index 0000000..87475ee
>> --- /dev/null
>> +++ b/drivers/bus/fslmc/meson.build
>> @@ -0,0 +1,28 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright 2018 NXP
>> +
>> +if host_machine.system() != 'linux'
>> + build = false
>> +endif
>> +
>> +deps += ['eal', 'ethdev', 'eventdev']
>
> Another minor nit - eal isn't strictly necessary here as both ethdev and
> eventdev already depend on it, and dependencies are recursive.
> Explicitly calling out all dependencies is not wrong, but in previous
> prototyping I found that meson takes a lot longer to run when it has to
> sort through all the dependency chains. That's why in other libs and
> drivers I tried to keep the dependency lists to a minimum.
> As well as this, EAL is a standard dependency, so it's already in the
> deps array at this point.
>
yes, it worked.
>> +sources = files('qbman/qbman_portal.c',
>> + 'qbman/qbman_debug.c',
>> + 'mc/dpmng.c',
>> + 'mc/dpbp.c',
>> + 'mc/dpio.c',
>> + 'mc/mc_sys.c',
>> + 'mc/dpcon.c',
>> + 'mc/dpci.c',
>> + 'portal/dpaa2_hw_dpio.c',
>> + 'portal/dpaa2_hw_dpbp.c',
>> + 'portal/dpaa2_hw_dpci.c',
>> + 'fslmc_vfio.c',
>> + 'fslmc_bus.c')
>> +
>> +allow_experimental_apis = true
>> +
>> +includes += include_directories('../../../lib/librte_eal/linuxapp/eal')
>
> Is this not covered by the dependency on eal? Is it accessing things
> directly in the EAL internals?
We are accessing eal_vfio.h. so it is needed.
../drivers/bus/fslmc/fslmc_vfio.h:12:10: fatal error: eal_vfio.h: No
such file or directory
#include <eal_vfio.h>
>
>> +includes += include_directories('mc', 'qbman/include', 'portal')
>> +dpdk_conf.set('CONFIG_RTE_ARCH_ARM_TUNE', 'cortex-a72')
>
> This setting seems strange here? How is it used, and why set only inside
> this particular driver?
>
We can remove it
>> +cflags += ['-D_GNU_SOURCE']
>> diff --git a/drivers/bus/meson.build b/drivers/bus/meson.build
>> index c6af500..2187f6b 100644
>> --- a/drivers/bus/meson.build
>> +++ b/drivers/bus/meson.build
>> @@ -1,7 +1,7 @@
>> # SPDX-License-Identifier: BSD-3-Clause
>> # Copyright(c) 2017 Intel Corporation
>>
>> -drivers = ['pci', 'vdev']
>> -std_deps = ['eal']
>> +drivers = ['pci', 'vdev', 'fslmc', 'dpaa']
>
> Please keep alphabetical order.
>
>> +std_deps = ['eal', 'kvargs']
>
> No big issue with this line change, but did you consider just making
> kvargs a dependency of the fslmc and dpaa buses directly, rather than
> making pci and vdev also depend on them?
>
Yes. it will work
next prev parent reply other threads:[~2018-03-01 6:10 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 17:25 [dpdk-dev] [PATCH 0/7] meson build support for dpaaX Hemant Agrawal
2018-02-27 17:25 ` [dpdk-dev] [PATCH 1/7] event/dpaa: fix include header Hemant Agrawal
2018-02-27 17:25 ` [dpdk-dev] [PATCH 2/7] dpaa: prepare for 32 bit compilation Hemant Agrawal
2018-02-27 17:25 ` [dpdk-dev] [PATCH 3/7] dpaa2: " Hemant Agrawal
2018-02-27 17:25 ` [dpdk-dev] [PATCH 4/7] bus/fslmc: add 32 bit functional support for ARM Hemant Agrawal
2018-02-27 17:25 ` [dpdk-dev] [PATCH 5/7] bus/dpaa: enabling dpaa compilation for other platforms Hemant Agrawal
2018-02-27 17:25 ` [dpdk-dev] [PATCH 6/7] bus/fslmc: enabling dpaa2 " Hemant Agrawal
2018-02-28 14:45 ` Bruce Richardson
2018-02-28 16:02 ` Hemant Agrawal
2018-02-28 16:33 ` Richardson, Bruce
2018-02-27 17:25 ` [dpdk-dev] [PATCH 7/7] build: add meson support for dpaaX platforms Hemant Agrawal
2018-02-28 14:44 ` Bruce Richardson
2018-03-01 6:10 ` Hemant Agrawal [this message]
2018-03-01 14:15 ` Thomas Monjalon
2018-03-09 16:49 ` Thomas Monjalon
2018-03-09 17:42 ` Hemant Agrawal
2018-03-01 7:33 ` [dpdk-dev] [PATCH v2 00/10] meson build support for dpaaX Hemant Agrawal
2018-03-01 7:33 ` [dpdk-dev] [PATCH v2 01/10] event/dpaa: fix include header Hemant Agrawal
2018-03-01 7:33 ` [dpdk-dev] [PATCH v2 02/10] bus/dpaa: fix the BE compilation issue Hemant Agrawal
2018-03-01 12:22 ` Shreyansh Jain
2018-03-01 7:33 ` [dpdk-dev] [PATCH v2 03/10] dpaa: prepare for 32 bit compilation Hemant Agrawal
2018-03-01 7:33 ` [dpdk-dev] [PATCH v2 04/10] dpaa2: " Hemant Agrawal
2018-03-01 7:33 ` [dpdk-dev] [PATCH v2 05/10] bus/fslmc: add 32 bit functional support for ARM Hemant Agrawal
2018-03-01 7:33 ` [dpdk-dev] [PATCH v2 06/10] bus/dpaa: enabling dpaa compilation for other platforms Hemant Agrawal
2018-03-01 7:33 ` [dpdk-dev] [PATCH v2 07/10] bus/fslmc: enabling dpaa2 " Hemant Agrawal
2018-03-01 7:33 ` [dpdk-dev] [PATCH v2 08/10] config: add dpaaX build support in common linuxapp Hemant Agrawal
2018-03-09 17:11 ` Thomas Monjalon
2018-03-09 17:22 ` Hemant Agrawal
2018-03-01 7:33 ` [dpdk-dev] [PATCH v2 09/10] build: add meson support for dpaaX platforms Hemant Agrawal
2018-03-01 7:33 ` [dpdk-dev] [PATCH v2 10/10] build: add meson cross compile config for dpaaX Hemant Agrawal
2018-03-14 7:55 ` [dpdk-dev] [PATCH v3 00/10] meson build support " Hemant Agrawal
2018-03-14 7:55 ` [dpdk-dev] [PATCH v3 01/10] event/dpaa: fix include header Hemant Agrawal
2018-03-14 7:55 ` [dpdk-dev] [PATCH v3 02/10] bus/dpaa: fix the BE compilation issue Hemant Agrawal
2018-03-14 7:55 ` [dpdk-dev] [PATCH v3 03/10] dpaa: prepare for 32 bit compilation Hemant Agrawal
2018-03-14 7:56 ` [dpdk-dev] [PATCH v3 04/10] dpaa2: " Hemant Agrawal
2018-03-14 7:56 ` [dpdk-dev] [PATCH v3 05/10] bus/fslmc: add 32 bit functional support for ARM Hemant Agrawal
2018-03-14 7:56 ` [dpdk-dev] [PATCH v3 06/10] bus/dpaa: enabling dpaa compilation for other platforms Hemant Agrawal
2018-03-14 7:56 ` [dpdk-dev] [PATCH v3 07/10] bus/fslmc: enabling dpaa2 " Hemant Agrawal
2018-03-14 7:56 ` [dpdk-dev] [PATCH v3 08/10] config: add dpaaX build support in common linuxapp Hemant Agrawal
2018-03-14 7:56 ` [dpdk-dev] [PATCH v3 09/10] build: add meson support for dpaaX platforms Hemant Agrawal
2018-03-14 7:56 ` [dpdk-dev] [PATCH v3 10/10] build: add meson cross compile config for dpaaX Hemant Agrawal
2018-03-14 9:08 ` [dpdk-dev] [PATCH v3 00/10] meson build support " Bruce Richardson
2018-03-14 9:12 ` Hemant Agrawal
2018-03-15 17:10 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62b44634-c2e5-eb91-03b1-68b356835a3e@nxp.com \
--to=hemant.agrawal@nxp.com \
--cc=akhil.goyal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shreyansh.jain@nxp.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).