From: "Rybalchenko, Kirill" <kirill.rybalchenko@intel.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>,
"Trahe, Fiona" <fiona.trahe@intel.com>,
"Jain, Deepak K" <deepak.k.jain@intel.com>,
"Griffin, John" <john.griffin@intel.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>,
"akhil.goyal@nxp.com" <akhil.goyal@nxp.com>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v3] cryptodev: allocate driver structure statically
Date: Mon, 4 Sep 2017 10:38:32 +0000 [thread overview]
Message-ID: <696B43C21188DF4F9C9091AAE4789B824E29582B@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <20170816024151.15325-1-pablo.de.lara.guarch@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara
> Sent: Wednesday 16 August 2017 03:42
> To: Doherty, Declan <declan.doherty@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>; Jain, Deepak K <deepak.k.jain@intel.com>;
> Griffin, John <john.griffin@intel.com>; jerin.jacob@caviumnetworks.com;
> akhil.goyal@nxp.com; hemant.agrawal@nxp.com
> Cc: dev@dpdk.org; De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev] [PATCH v3] cryptodev: allocate driver structure statically
>
> When register a crypto driver, a cryptodev driver structure was being
> allocated, using malloc.
> Since this call may fail, it is safer to allocate this memory statically in each
> PMD, so driver registration will never fail.
>
> Coverity issue: 158645
>
> Fixes: 7a364faef185 ("cryptodev: remove crypto device type enumeration")
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>
> Changes in v3:
>
> - Added documentation (removed deprecation notice and added API
> Change)
> - Modified title to something more explicit
>
> Changes in v2:
>
> - Allocate statically the cryptodev driver structure,
> instead of using malloc, that can potentially fail.
>
> doc/guides/rel_notes/deprecation.rst | 6 ------
> doc/guides/rel_notes/release_17_11.rst | 5 +++++
> drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 5 ++++-
> drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c | 6 +++++-
> drivers/crypto/armv8/rte_armv8_pmd.c | 9 ++++++---
> drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 5 ++++-
> drivers/crypto/kasumi/rte_kasumi_pmd.c | 5 ++++-
> drivers/crypto/null/null_crypto_pmd.c | 5 ++++-
> drivers/crypto/openssl/rte_openssl_pmd.c | 5 ++++-
> drivers/crypto/qat/rte_qat_cryptodev.c | 7 +++++--
> drivers/crypto/scheduler/scheduler_pmd.c | 5 ++++-
> drivers/crypto/snow3g/rte_snow3g_pmd.c | 5 ++++-
> drivers/crypto/zuc/rte_zuc_pmd.c | 5 ++++-
> lib/librte_cryptodev/rte_cryptodev.c | 18 +++++------------
> lib/librte_cryptodev/rte_cryptodev.h | 20 -------------------
> lib/librte_cryptodev/rte_cryptodev_pmd.h | 30
> +++++++++++++++++++++++++++++
> 16 files changed, 88 insertions(+), 53 deletions(-)
>
Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
next prev parent reply other threads:[~2017-09-04 10:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 2:30 [dpdk-dev] [PATCH] cryptodev: fix NULL pointer dereference Pablo de Lara
2017-07-31 9:18 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2017-07-31 19:33 ` Thomas Monjalon
2017-08-01 7:10 ` De Lara Guarch, Pablo
2017-08-01 8:13 ` Sergio Gonzalez Monroy
2017-08-01 9:35 ` Thomas Monjalon
2017-08-01 10:17 ` Sergio Gonzalez Monroy
2017-08-01 10:48 ` De Lara Guarch, Pablo
2017-08-01 12:36 ` Thomas Monjalon
2017-08-16 2:41 ` [dpdk-dev] [PATCH v3] cryptodev: allocate driver structure statically Pablo de Lara
2017-09-04 10:38 ` Rybalchenko, Kirill [this message]
2017-09-06 10:27 ` De Lara Guarch, Pablo
2017-07-31 12:32 ` [dpdk-dev] [PATCH] cryptodev: fix NULL pointer dereference Sergio Gonzalez Monroy
2017-07-31 15:22 ` Thomas Monjalon
2017-08-01 7:09 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=696B43C21188DF4F9C9091AAE4789B824E29582B@IRSMSX108.ger.corp.intel.com \
--to=kirill.rybalchenko@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=declan.doherty@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=fiona.trahe@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=john.griffin@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).