From: "Rybalchenko, Kirill" <kirill.rybalchenko@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Chilikin, Andrey" <andrey.chilikin@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v3] ethdev: increase flow type limit from 32 to 64
Date: Thu, 18 Jan 2018 09:24:33 +0000 [thread overview]
Message-ID: <696B43C21188DF4F9C9091AAE4789B824E2BA604@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <c97047f6-ce2e-5ebf-df9c-561dc30b9815@intel.com>
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Wednesday 17 January 2018 16:57
> To: Rybalchenko, Kirill <kirill.rybalchenko@intel.com>; dev@dpdk.org
> Cc: Chilikin, Andrey <andrey.chilikin@intel.com>; thomas@monjalon.net
> Subject: Re: [dpdk-dev] [PATCH v3] ethdev: increase flow type limit from 32
> to 64
>
> On 1/15/2018 5:33 PM, Kirill Rybalchenko wrote:
> > Increase the internal limit for flow types from 32 to 64 to support
> > future flow type extensions.
> > Change type of variables from uint32_t[] to uint64_t[]:
> > rte_eth_fdir_info.flow_types_mask
> > rte_eth_hash_global_conf.sym_hash_enable_mask
> > rte_eth_hash_global_conf.valid_bit_mask
> >
> > This modification affects the following components:
> > net/i40e
> > net/ixgbe
> > app/testpmd
> >
> > v2:
> > implement versioning of rte_eth_dev_filter_ctrl function for ABI
> > backward compatibility with version 17.11 and older
> >
> > v3:
> > fix code style warnings
> >
> > Signed-off-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
>
> I suggest keeping deprecation notice and clean versioning in next release,
> does it make sense?
Yes, I think it should be done in this way, just to keep source codes tidy.
next prev parent reply other threads:[~2018-01-18 9:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 12:29 [dpdk-dev] [PATCH] " Kirill Rybalchenko
2017-12-04 17:43 ` Adrien Mazarguil
2018-01-09 15:16 ` Rybalchenko, Kirill
2018-01-10 13:50 ` Thomas Monjalon
2018-01-16 11:13 ` Adrien Mazarguil
2018-01-16 17:23 ` Rybalchenko, Kirill
2018-01-16 18:03 ` Adrien Mazarguil
2018-01-09 14:30 ` Zhang, Helin
2018-01-10 6:51 ` Xing, Beilei
2018-01-15 16:58 ` [dpdk-dev] [PATCH v2] " Kirill Rybalchenko
2018-01-15 17:33 ` [dpdk-dev] [PATCH v3] " Kirill Rybalchenko
2018-01-15 21:27 ` Thomas Monjalon
2018-01-16 9:44 ` Rybalchenko, Kirill
2018-01-16 9:47 ` Thomas Monjalon
2018-01-16 10:31 ` Rybalchenko, Kirill
2018-01-16 10:38 ` Thomas Monjalon
2018-01-17 16:56 ` Ferruh Yigit
2018-01-18 9:24 ` Rybalchenko, Kirill [this message]
2018-01-18 12:25 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=696B43C21188DF4F9C9091AAE4789B824E2BA604@IRSMSX108.ger.corp.intel.com \
--to=kirill.rybalchenko@intel.com \
--cc=andrey.chilikin@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).