From: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e
Date: Fri, 24 Feb 2017 07:23:12 +0000 [thread overview]
Message-ID: <6A0DE07E22DDAD4C9103DF62FEBC09093B5682B7@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20170223225507.69ee0e47@xeon-e3>
Hi Stephen,
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Friday, February 24, 2017 2:55 PM
> To: Lu, Wenzhuo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 0/8] QoS features on i40e
>
> On Fri, 24 Feb 2017 11:24:27 +0800
> Wenzhuo Lu <wenzhuo.lu@intel.com> wrote:
>
> > This patch set enables several QoS features on i40e.
> > 1, VF max bandwidth setting.
> > 2, TC min bandwidth setting on a VF.
> > 3, TC max bandwidth setting on a VF.
> > 4, TC TX scheduling mode setting.
> > As there're no new interface between PF and VF defined, all the
> > settings for VF are done on PF. PF acts as a controller for the VFs.
> >
> > Wenzhuo Lu (8):
> > net/i40e: set VF max bandwidth from PF
> > net/i40e: allocate VF TC bandwidth from PF
> > net/i40e: set VF TC max bandwidth from PF
> > net/i40e: set TC strict priority mode
> > app/testpmd: set VF TX max bandwidth
> > app/testpmd: set VF TC TX min bandwidth
> > app/testpmd: set VF TC TX max bandwidth
> > app/testpmd: set TC strict link priority mode
> >
> > app/test-pmd/cmdline.c | 343 +++++++++++++++++++++
> > doc/guides/nics/i40e.rst | 21 ++
> > doc/guides/rel_notes/release_17_05.rst | 20 ++
> > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 28 ++
> > drivers/net/i40e/i40e_ethdev.c | 449
> ++++++++++++++++++++++++++++
> > drivers/net/i40e/i40e_ethdev.h | 1 +
> > drivers/net/i40e/rte_pmd_i40e.h | 86 ++++++
> > drivers/net/i40e/rte_pmd_i40e_version.map | 10 +
> > 8 files changed, 958 insertions(+)
> >
>
> It is good to allow setting QoS on device, but it looks like this is a device
> specific API, not a generic PMD function. I don't think any feature in DPDK
> should be hardcoded to one device type.
Yes, they're private APIs.
Normally we want to support kernel PF + dpdk VF. As there's no PF - VF interface defined for QoS, These features cannot be implemented on VF now.
Have to put them on PF, and let PF play as a controller.
There's discussion about if we should rich PF host features. So, I put these functions to rte_pmd_i40e.h to show they're experimental and temporary features.
There's another thread started by Cristian for a generic QoS solution. After it's accepted and the PF-VF interfaces are defined by kernel driver. We can use a generic solution to replace this one.
next prev parent reply other threads:[~2017-02-24 7:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 3:24 Wenzhuo Lu
2017-02-24 3:24 ` [dpdk-dev] [PATCH 1/8] net/i40e: set VF max bandwidth from PF Wenzhuo Lu
2017-03-24 5:01 ` Wu, Jingjing
2017-02-24 3:24 ` [dpdk-dev] [PATCH 2/8] net/i40e: allocate VF TC " Wenzhuo Lu
2017-03-24 5:10 ` Wu, Jingjing
2017-02-24 3:24 ` [dpdk-dev] [PATCH 3/8] net/i40e: set VF TC max " Wenzhuo Lu
2017-03-24 5:15 ` Wu, Jingjing
2017-02-24 3:24 ` [dpdk-dev] [PATCH 4/8] net/i40e: set TC strict priority mode Wenzhuo Lu
2017-03-24 5:19 ` Wu, Jingjing
2017-03-24 7:07 ` Lu, Wenzhuo
2017-03-24 9:34 ` Wu, Jingjing
2017-02-24 3:24 ` [dpdk-dev] [PATCH 5/8] app/testpmd: set VF TX max bandwidth Wenzhuo Lu
2017-03-24 5:21 ` Wu, Jingjing
2017-02-24 3:24 ` [dpdk-dev] [PATCH 6/8] app/testpmd: set VF TC TX min bandwidth Wenzhuo Lu
2017-03-24 5:22 ` Wu, Jingjing
2017-02-24 3:24 ` [dpdk-dev] [PATCH 7/8] app/testpmd: set VF TC TX max bandwidth Wenzhuo Lu
2017-03-24 5:22 ` Wu, Jingjing
2017-02-24 3:24 ` [dpdk-dev] [PATCH 8/8] app/testpmd: set TC strict link priority mode Wenzhuo Lu
2017-03-24 5:23 ` Wu, Jingjing
2017-02-24 6:55 ` [dpdk-dev] [PATCH 0/8] QoS features on i40e Stephen Hemminger
2017-02-24 7:23 ` Lu, Wenzhuo [this message]
2017-02-24 9:14 ` [dpdk-dev] [PATCH 0/8] QoS features on i40e - Linux kernel divergence Vincent JARDIN
2017-02-28 5:04 ` Lu, Wenzhuo
2017-03-27 15:13 ` [dpdk-dev] [PATCH 0/8] QoS features on i40e Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6A0DE07E22DDAD4C9103DF62FEBC09093B5682B7@shsmsx102.ccr.corp.intel.com \
--to=wenzhuo.lu@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).